openstack
/
neutron
Code Issues Proposed changes

Fix pylint no-value-for-parameter error 

Four migration sanity tests generate a no-value-for-parameter
error.  Add a directive to ignore it as is done in some of the
alembic migration code.

Trivialfix

Change-Id: I87320c0f7157f160601a4b051734b4c5e49ea3e1
This commit is contained in:
Brian Haley 2018-04-18 14:56:51 -04:00
parent 390cc07c8c
commit 944a306a24
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
neutron/tests/functional/db/test_migrations.py
View File

@ -397,6 +397,9 @@ class TestSanityCheck(testlib_api.SqlTestCaseLight):
with self.engine.connect() as conn:
ha_router_agent_port_bindings.create(conn)
self.addCleanup(self._drop_table, ha_router_agent_port_bindings)
# NOTE(haleyb): without this disabled, pylint complains
# about a missing 'dml' argument.
#pylint: disable=no-value-for-parameter
conn.execute(ha_router_agent_port_bindings.insert(), [
{'port_id': '1234', 'router_id': '12345',
'l3_agent_id': '123'},
@ -419,6 +422,9 @@ class TestSanityCheck(testlib_api.SqlTestCaseLight):
with self.engine.connect() as conn:
routerports.create(conn)
self.addCleanup(self._drop_table, routerports)
# NOTE(haleyb): without this disabled, pylint complains
# about a missing 'dml' argument.
#pylint: disable=no-value-for-parameter
conn.execute(routerports.insert(), [
{'router_id': '1234', 'port_id': '12345',
'port_type': '123'},
@ -441,6 +447,9 @@ class TestSanityCheck(testlib_api.SqlTestCaseLight):
with self.engine.connect() as conn:
floatingips.create(conn)
self.addCleanup(self._drop_table, floatingips)
# NOTE(haleyb): without this disabled, pylint complains
# about a missing 'dml' argument.
#pylint: disable=no-value-for-parameter
conn.execute(floatingips.insert(), [
{'floating_network_id': '12345',
'fixed_port_id': '1234567',
@ -465,6 +474,9 @@ class TestSanityCheck(testlib_api.SqlTestCaseLight):
with self.engine.connect() as conn:
floatingips.create(conn)
self.addCleanup(self._drop_table, floatingips)
# NOTE(haleyb): without this disabled, pylint complains
# about a missing 'dml' argument.
#pylint: disable=no-value-for-parameter
conn.execute(floatingips.insert(), [
{'floating_network_id': '12345',
'fixed_port_id': '1234567',