openstack/neutron
Code Issues Proposed changes

Merge "Return empty BpInfo if missing binding:profile"

Browse Source
This commit is contained in:
Zuul 2024-07-05 04:44:19 +00:00 committed by Gerrit Code Review
commit 964997b960
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/common/ovn/utils.py
View File

@ -433,7 +433,7 @@ def validate_and_get_data_from_binding_profile(port):
if (constants.OVN_PORT_BINDING_PROFILE not in port or
not validators.is_attr_set(
port[constants.OVN_PORT_BINDING_PROFILE])):
BPInfo({}, None, [])
return BPInfo({}, None, [])
param_set = {}
param_dict = {}
vnic_type = port.get(portbindings.VNIC_TYPE, portbindings.VNIC_NORMAL)

5
neutron/tests/unit/common/ovn/test_utils.py
View File

@ -756,6 +756,11 @@ class TestValidateAndGetDataFromBindingProfile(base.BaseTestCase):
{portbindings.VNIC_TYPE: portbindings.VNIC_DIRECT,
constants.OVN_PORT_BINDING_PROFILE: binding_profile}))
def test_valid_input_no_binding_profile(self):
# Confirm that we treat a port without binding:profile as valid
self.assertEqual(utils.BPInfo({}, None, []),
utils.validate_and_get_data_from_binding_profile({}))
def test_unknown_profile_items_pruned(self):
# Confirm that unknown profile items are pruned
self.assertEqual(