openstack/neutron
Code Issues Proposed changes

Merge "Stop logging unnecessary warning on context create"

Browse Source
This commit is contained in:
Jenkins
2013-11-28 12:44:06 +00:00
committed by Gerrit Code Review
parent a191781e7d 5b61df1f53
commit 9cd2000f97
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/context.py
View File

@@ -80,7 +80,7 @@ class ContextBase(common_context.RequestContext):
# Log only once the context has been configured to prevent # Log only once the context has been configured to prevent
# format errors. # format errors.
if kwargs: if kwargs:
LOG.warn(_('Arguments dropped when creating ' LOG.debug(_('Arguments dropped when creating '
'context: %s'), kwargs) 'context: %s'), kwargs)
@property @property

8
neutron/tests/unit/test_neutron_context.py
View File

@@ -43,10 +43,10 @@ class TestNeutronContext(base.BaseTestCase):
self.assertIsNone(ctx.user_name) self.assertIsNone(ctx.user_name)
self.assertIsNone(ctx.tenant_name) self.assertIsNone(ctx.tenant_name)
def test_neutron_context_create_logs_unknown_kwargs(self): def test_neutron_context_create_logs_unknown_kwarg(self):
with mock.patch.object(context.LOG, 'warn') as mock_warn: with mock.patch.object(context.LOG, 'debug') as mock_log:
context.Context('user_id', 'tenant_id', foo='bar') context.Context('user_id', 'tenant_id', foo=None)
self.assertEqual(mock_warn.call_count, 1) self.assertEqual(mock_log.call_count, 1)
def test_neutron_context_create_with_name(self): def test_neutron_context_create_with_name(self):
ctx = context.Context('user_id', 'tenant_id', ctx = context.Context('user_id', 'tenant_id',