From 1e9a3bffd2cf565568ac479710104cd3a4cdae53 Mon Sep 17 00:00:00 2001 From: Slawek Kaplonski Date: Wed, 24 Jun 2020 12:32:14 +0200 Subject: [PATCH] [Fullstack] SG test - first wait until all vms can ping each other In fullstack security group test, after fake VMs are created there check if connectivity to some custom port is working fine with port security disabled. After that there is called "block_until_ping" method for each vms. This patch changes that to first wait if we can ping vms and later do netcat tests. Even if that will not solve problems with failures of this test, we may know more if the issue is caused by netcat or it's just no ICMP connectivity between VMs at all. Change-Id: Ie9e2170c761c9a10f3daa991c3fb77f304bb07e2 Related-Bug: #1742401 --- neutron/tests/fullstack/test_securitygroup.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/neutron/tests/fullstack/test_securitygroup.py b/neutron/tests/fullstack/test_securitygroup.py index b0b57878e22..0946f890bf1 100644 --- a/neutron/tests/fullstack/test_securitygroup.py +++ b/neutron/tests/fullstack/test_securitygroup.py @@ -135,15 +135,15 @@ class TestSecurityGroupsSameNetwork(BaseSecurityGroupsSameNetworkTest): tenant_uuid, subnet_cidr) # 0. check that traffic is allowed when port security is disabled + vms[0].block_until_ping(vms[1].ip) + vms[0].block_until_ping(vms[2].ip) + vms[1].block_until_ping(vms[2].ip) self.assert_connection( vms[1].namespace, vms[0].namespace, vms[0].ip, 3333, net_helpers.NetcatTester.TCP) self.assert_connection( vms[2].namespace, vms[0].namespace, vms[0].ip, 3333, net_helpers.NetcatTester.TCP) - vms[0].block_until_ping(vms[1].ip) - vms[0].block_until_ping(vms[2].ip) - vms[1].block_until_ping(vms[2].ip) # Apply security groups to the ports for port, sg in zip(ports, self.index_to_sg):