openstack
/
neutron
Code Issues Proposed changes

Build metadata_agent.ini reproducibly 

Currently, when metadata_agent.ini is built, the default value for the
directive metadata_workers is the build host's number of CPU. This is
wrong because metadata_agent.ini cannot be built reproducibly, which is
a bug in many distributions.

See for Debian: https://wiki.debian.org/ReproducibleBuilds/About

This patch therefore uses sample_default oslo.config directive to
hardcode a value put in generated configuration file that would not
depend on build environment.

Change-Id: I7292d09b96f90d0477dd4b59766854a733e1da38
Closes-Bug: #1736114
This commit is contained in:
Thomas Goirand 2017-12-04 12:28:35 +01:00 committed by Ihar Hrachyshka
parent acef6d1666
commit a20845048a
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
neutron/conf/agent/metadata/config.py
View File

@ -95,6 +95,7 @@ UNIX_DOMAIN_METADATA_PROXY_OPTS = [
"otherwise.")),
cfg.IntOpt('metadata_workers',
default=host.cpu_count() // 2,
sample_default='<num_of_cpus> / 2',
help=_('Number of separate worker processes for metadata '
'server (defaults to half of the number of CPUs)')),
cfg.IntOpt('metadata_backlog',