openstack
/
neutron
Code Issues Proposed changes

Merge "Corrected wrong ethertype exception message"

This commit is contained in:
Jenkins 2015-12-21 17:10:17 +00:00 committed by Gerrit Code Review
parent 72f6b99211 be14e90541
commit aea286df77
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
neutron/extensions/securitygroup.py
View File

@ -134,6 +134,11 @@ class SecurityGroupConflict(nexception.Conflict):
message = _("Error %(reason)s while attempting the operation.")
class SecurityGroupRuleInvalidEtherType(nexception.InvalidInput):
message = _("Security group rule for ethertype '%(ethertype)s' not "
"supported. Allowed values are %(values)s.")
def convert_protocol(value):
if value is None:
return
@ -161,6 +166,8 @@ def convert_ethertype_to_case_insensitive(value):
for ethertype in sg_supported_ethertypes:
if ethertype.lower() == value.lower():
return ethertype
raise SecurityGroupRuleInvalidEtherType(
ethertype=value, values=sg_supported_ethertypes)
def convert_validate_port_value(port):

8
neutron/tests/unit/extensions/test_securitygroup.py
View File

@ -1559,3 +1559,11 @@ class TestConvertProtocol(base.BaseTestCase):
def test_convert_numeric_protocol_to_string(self):
self.assertIsInstance(ext_sg.convert_protocol(2), str)
class TestConvertEtherType(base.BaseTestCase):
def test_convert_unsupported_ethertype(self):
for val in ['ip', 'ip4', 'ip6', '']:
self.assertRaises(ext_sg.SecurityGroupRuleInvalidEtherType,
ext_sg.convert_ethertype_to_case_insensitive,
val)