openstack/neutron
Code Issues Proposed changes

[Functional] Don't assert that HA router don't have IPs configured

Browse Source 
In functional tests of HA router, in
L3AgentTestFramework._router_lifecycle method there was assertion
that HA router at the beginning don't have IPs configured in
router's namespace.

That could lead to test failure because sometimes keepalived process
switched router from standby to master before this assertion was
done and IPs were already configured.

There is alsmost no value in doing this assertion as it's just after
router was created so it is "normal" that there is no IP addresses
configured yet.
Because of that this patch removes this assertion.

Change-Id: Ib509a7226eb94483a0aaf2d930f329e419b8e135
Closes-Bug: #1816489
(cherry picked from commit e6351ab11e2cfaea18ab963e32052ad110d2b899)
This commit is contained in:
Slawek Kaplonski 2019-03-01 16:11:59 +01:00 committed by Bernard Cafarelli
parent ea3bcca169
commit b0c8dde359
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
neutron/tests/functional/agent/l3/framework.py
View File

@ -275,10 +275,6 @@ class L3AgentTestFramework(base.BaseSudoTestCase):
router.process()
if enable_ha:
port = router.get_ex_gw_port()
interface_name = router.get_external_device_name(port['id'])
self._assert_no_ip_addresses_on_interface(router.ns_name,
interface_name)
common_utils.wait_until_true(lambda: router.ha_state == 'master')
# Keepalived notifies of a state transition when it starts,