From 057e779f6416267f18eb4db74851cc6a3722aed6 Mon Sep 17 00:00:00 2001 From: Bogdan Dobrelya Date: Thu, 10 Feb 2022 11:32:06 +0100 Subject: [PATCH] Log request IDs for matched Nova external events Nova notifier logs for external events only provide the event details without showing its connection to the associated request_id. That complicates debugging of corner cases for external events as we cannot be sure to which exact request a logged event is related. Make the matching request_ids logged alongside external event details, whenever it is available. Signed-off-by: Bogdan Dobrelya Change-Id: I047a28744a0bf52ace9f9a205993c6037a21083c (cherry picked from commit 7cedbdeabae6c520dcdd56007d288cd351fb3269) --- neutron/notifiers/nova.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/neutron/notifiers/nova.py b/neutron/notifiers/nova.py index 804fb73964e..3331f7d5f09 100644 --- a/neutron/notifiers/nova.py +++ b/neutron/notifiers/nova.py @@ -266,11 +266,15 @@ class Notifier(object): except KeyError: response_error = True continue - if code != 200: - LOG.warning("Nova event: %s returned with failed " - "status", event) + if hasattr(response, 'request_ids'): + msg = "Nova event matching {}".format(response.request_ids) else: - LOG.info("Nova event response: %s", event) + msg = "Nova event" + if code != 200: + LOG.warning("%s: %s returned with failed " + "status", msg, event) + else: + LOG.info("%s response: %s", msg, event) if response_error: LOG.error("Error response returned from nova: %s", response)