Browse Source

Remove FT "test_has_offline_migrations_*" tests

"test_has_offline_migrations_pending_contract_scripts" is testing a
non supported branch, "Kilo". The usefulness expired when this branch
was declared EOL.

"test_has_offline_migrations_all_heads_upgraded" is tested in
"test_forbid_offline_migrations_starting_newton". Since "Newton",
no more DB contract migrations are allowed. Both tests are checking
the same behavior.

Due to the time extension and the lack of value of those tests, this
patch removes both.

  test_forbid_offline_migrations_starting_newton [683.133807s]
  test_has_offline_migrations_pending_contract_scripts [123.091853s]

Change-Id: I4846ecdd8312fa2ff915c4461da07a607c7a8f8c
Related-Bug: #1687027
(cherry picked from commit 8522628f2f)
changes/95/784995/1
Rodolfo Alonso Hernandez 2 weeks ago
committed by Rodolfo Alonso
parent
commit
b806dd0aa7
1 changed files with 0 additions and 26 deletions
  1. +0
    -26
      neutron/tests/functional/db/test_migrations.py

+ 0
- 26
neutron/tests/functional/db/test_migrations.py View File

@ -325,25 +325,9 @@ class _TestModelsMigrations(test_migrations.ModelsMigrationsSync):
self.alembic_config, 'upgrade',
'%s@head' % migration.CONTRACT_BRANCH)
def _test_has_offline_migrations(self, revision, expected):
engine = self.get_engine()
cfg.CONF.set_override('connection', engine.url, group='database')
migration.do_alembic_command(self.alembic_config, 'upgrade', revision)
self.assertEqual(expected,
migration.has_offline_migrations(self.alembic_config,
'unused'))
def test_has_offline_migrations_pending_contract_scripts(self):
self._test_has_offline_migrations('kilo', True)
def test_has_offline_migrations_all_heads_upgraded(self):
self._test_has_offline_migrations('heads', False)
# NOTE(ihrachys): if this test fails for you, it probably means that you
# attempt to add an unsafe contract migration script, that is in
# contradiction to blueprint online-upgrades
# TODO(ihrachys): revisit later in Pike+ where some contract scripts may be
# safe again
def test_forbid_offline_migrations_starting_newton(self):
engine = self.get_engine()
cfg.CONF.set_override('connection', engine.url, group='database')
@ -397,16 +381,6 @@ class TestModelsMigrationsMysql(testlib_api.MySQLTestCaseMixin,
def test_branches(self):
super(TestModelsMigrationsMysql, self).test_branches()
@test_base.skip_if_timeout("bug 1687027")
def test_has_offline_migrations_pending_contract_scripts(self):
super(TestModelsMigrationsMysql,
self).test_has_offline_migrations_pending_contract_scripts()
@test_base.skip_if_timeout("bug 1687027")
def test_has_offline_migrations_all_heads_upgraded(self):
super(TestModelsMigrationsMysql,
self).test_has_offline_migrations_all_heads_upgraded()
@test_base.skip_if_timeout("bug 1687027")
def test_models_sync(self):
super(TestModelsMigrationsMysql, self).test_models_sync()


Loading…
Cancel
Save