openstack
/
neutron
Code Issues Proposed changes

Remove redundant initialization and check from DVR RPC mixin 

The initialization, as well as the recurrent checks on whether the agent
is able to handle DVR requests, are not necessary; this is because the
dvr_agent is going to be set at the time the L2 agent starts receiving
RPC messages.

Change-Id: I9caad965d0ff507e2ed93d6432997ad86139ac04
This commit is contained in:
armando-migliaccio 2014-10-14 23:25:58 -07:00 committed by Armando Migliaccio
parent 1aaa8b3446
commit bc4d1054c3
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
neutron/api/rpc/handlers/dvr_rpc.py
View File

@ -115,8 +115,6 @@ class DVRAgentRpcApiMixin(object):
class DVRAgentRpcCallbackMixin(object):
"""Agent-side RPC (implementation) for plugin-to-agent interaction."""
dvr_agent = None
def dvr_mac_address_update(self, context, **kwargs):
"""Callback for dvr_mac_addresses update.
@ -124,7 +122,4 @@ class DVRAgentRpcCallbackMixin(object):
"""
dvr_macs = kwargs.get('dvr_macs', [])
LOG.debug("dvr_macs updated on remote: %s", dvr_macs)
if not self.dvr_agent:
LOG.warn(_("DVR agent binding currently not set."))
return
self.dvr_agent.dvr_mac_address_update(dvr_macs)