From c28207705885490f0b1d7b49694176b24b61225a Mon Sep 17 00:00:00 2001 From: Brian Haley Date: Wed, 20 Sep 2023 15:52:22 -0400 Subject: [PATCH] Fix pointless-string-statement pylint warning For some reason, kilo_initial.py is triggering this warning, so fix it by using comments instead of a docstring. Also updated the template to use comments as well, so any migrations created in the future use them, even though none seem to be causing a similar warning right now. Closes-bug: #2036763 Change-Id: I63b7ac83fdd3ebc6251979f1376daf2105489fdc --- .../db/migration/alembic_migrations/script.py.mako | 12 +++++------- .../alembic_migrations/versions/kilo_initial.py | 9 ++++----- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/neutron/db/migration/alembic_migrations/script.py.mako b/neutron/db/migration/alembic_migrations/script.py.mako index b568c22fa7e..0fcb3d4fce3 100644 --- a/neutron/db/migration/alembic_migrations/script.py.mako +++ b/neutron/db/migration/alembic_migrations/script.py.mako @@ -17,13 +17,11 @@ from alembic import op import sqlalchemy as sa ${imports if imports else ""} -"""${message} - -Revision ID: ${up_revision} -Revises: ${down_revision} -Create Date: ${create_date} - -""" +# ${message} +# +# Revision ID: ${up_revision} +# Revises: ${down_revision} +# Create Date: ${create_date} # revision identifiers, used by Alembic. revision = ${repr(up_revision)} diff --git a/neutron/db/migration/alembic_migrations/versions/kilo_initial.py b/neutron/db/migration/alembic_migrations/versions/kilo_initial.py index f4290e3e758..4ea48db400c 100644 --- a/neutron/db/migration/alembic_migrations/versions/kilo_initial.py +++ b/neutron/db/migration/alembic_migrations/versions/kilo_initial.py @@ -36,12 +36,11 @@ from neutron.db.migration.alembic_migrations import secgroup_init_ops from neutron.db.migration.alembic_migrations import vmware_init_ops from neutron.db.migration.alembic_migrations import vpn_init_ops -"""kilo_initial -Revision ID: kilo -Revises: None - -""" +# kilo_initial +# +# Revision ID: kilo +# Revises: None # revision identifiers, used by Alembic. revision = 'kilo'