openstack
/
neutron
Code Issues Proposed changes

ovsdb monitor: do not die on ovsdb-client stderr output 

That process may generate stderr output (ovs 2.10 with dpdk support will
log about missing optional libraries for example), in which case the
agent will loop forever respawning the ovsdb-client processes.

AsyncProcess already handles processes exiting uncleanly, and logs
stderr output with log_output=True (which is the case for OvsdbMonitor).

As the monitors work on stdout output, disabling die_on_error is enough
to make them work with this behaviour.

Change-Id: I8f2e5b93b9c16f9b288046911b5aeb4938845233
Closes-Bug: #1788865
(cherry picked from commit f6d98a747b)
This commit is contained in:
Bernard Cafarelli 2018-08-27 14:37:15 +02:00
parent bffdbfe20e
commit c704d0d9fa
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/agent/linux/ovsdb_monitor.py
View File

@ -72,7 +72,7 @@ class OvsdbMonitor(async_process.AsyncProcess):
super(OvsdbMonitor, self).__init__(cmd, run_as_root=run_as_root,
respawn_interval=respawn_interval,
log_output=True,
die_on_error=True)
die_on_error=False)
self.new_events = {'added': [], 'removed': []}
def get_events(self):