Remove some useless else statements
Fix useless-else-on-loop, no-else-raise warnings and no-else-continue in some test files. Noticed while making another change. TrivialFix Change-Id: I9f3100ab2fe97275906e52a764a5023039622728
This commit is contained in:
parent
fce1b4c7d7
commit
c794227941
|
@ -525,7 +525,6 @@ class BaseTestCase(DietTestCase):
|
||||||
if e:
|
if e:
|
||||||
if raise_on_exception:
|
if raise_on_exception:
|
||||||
raise e
|
raise e
|
||||||
else:
|
|
||||||
threads_exceptions.append(e)
|
threads_exceptions.append(e)
|
||||||
|
|
||||||
return threads_exceptions
|
return threads_exceptions
|
||||||
|
|
|
@ -40,7 +40,6 @@ class AlwaysTheOtherAgentScheduler(base_scheduler.BaseChanceScheduler,
|
||||||
for agent in resource_hostable_agents:
|
for agent in resource_hostable_agents:
|
||||||
if agent.id in self.last_selected_agent_ids:
|
if agent.id in self.last_selected_agent_ids:
|
||||||
continue
|
continue
|
||||||
else:
|
|
||||||
possible_agents.append(agent)
|
possible_agents.append(agent)
|
||||||
num_agents = min(len(possible_agents), num_agents_needed)
|
num_agents = min(len(possible_agents), num_agents_needed)
|
||||||
self.last_selected_agent_ids = [
|
self.last_selected_agent_ids = [
|
||||||
|
|
|
@ -83,7 +83,6 @@ class BaseOVSTestCase(base.BaseSudoTestCase):
|
||||||
for queue in (queue for queue in queues
|
for queue in (queue for queue in queues
|
||||||
if queue['_uuid'] == queue_id):
|
if queue['_uuid'] == queue_id):
|
||||||
return queue
|
return queue
|
||||||
else:
|
|
||||||
return None
|
return None
|
||||||
return queues
|
return queues
|
||||||
|
|
||||||
|
@ -121,7 +120,6 @@ class BaseOVSTestCase(base.BaseSudoTestCase):
|
||||||
if qos_id:
|
if qos_id:
|
||||||
for qos in (qos for qos in qoses if qos['_uuid'] == qos_id):
|
for qos in (qos for qos in qoses if qos['_uuid'] == qos_id):
|
||||||
return qos
|
return qos
|
||||||
else:
|
|
||||||
return None
|
return None
|
||||||
return qoses
|
return qoses
|
||||||
|
|
||||||
|
|
|
@ -401,7 +401,6 @@ class TestMetadataAgent(base.TestOVNFunctionalBase):
|
||||||
for rule in iptables_mgr.get_rules_for_table('mangle'):
|
for rule in iptables_mgr.get_rules_for_table('mangle'):
|
||||||
if regex.match(rule):
|
if regex.match(rule):
|
||||||
return
|
return
|
||||||
else:
|
|
||||||
self.fail('Rule not found in "mangle" table, in namespace %s' %
|
self.fail('Rule not found in "mangle" table, in namespace %s' %
|
||||||
namespace)
|
namespace)
|
||||||
|
|
||||||
|
|
|
@ -66,7 +66,7 @@ class OVSAgentTestBase(test_ovs_lib.OVSBridgeTestBase,
|
||||||
(l, sep, r) = line.partition(':')
|
(l, sep, r) = line.partition(':')
|
||||||
if not sep:
|
if not sep:
|
||||||
continue
|
continue
|
||||||
elif l in required_keys:
|
if l in required_keys:
|
||||||
trace[l] = r
|
trace[l] = r
|
||||||
for k in required_keys:
|
for k in required_keys:
|
||||||
if k not in trace:
|
if k not in trace:
|
||||||
|
|
|
@ -204,7 +204,6 @@ class GetLinkDevicesTestCase(functional_base.BaseSudoTestCase):
|
||||||
for device in priv_ip_lib.get_link_devices(namespace):
|
for device in priv_ip_lib.get_link_devices(namespace):
|
||||||
if interface_name == linux_utils.get_attr(device, 'IFLA_IFNAME'):
|
if interface_name == linux_utils.get_attr(device, 'IFLA_IFNAME'):
|
||||||
return device
|
return device
|
||||||
else:
|
|
||||||
self.fail('Interface "%s" not found' % interface_name)
|
self.fail('Interface "%s" not found' % interface_name)
|
||||||
|
|
||||||
def test_get_link_devices_veth_different_namespaces(self):
|
def test_get_link_devices_veth_different_namespaces(self):
|
||||||
|
@ -280,7 +279,6 @@ class BaseIpRuleTestCase(functional_base.BaseSudoTestCase):
|
||||||
else:
|
else:
|
||||||
if raise_exception:
|
if raise_exception:
|
||||||
self.fail('Rule with %s was expected' % exception_string)
|
self.fail('Rule with %s was expected' % exception_string)
|
||||||
else:
|
|
||||||
return False
|
return False
|
||||||
|
|
||||||
|
|
||||||
|
|
|
@ -121,9 +121,7 @@ class RuleScopesTestCase(PolicyBaseTestCase):
|
||||||
if len(rule.scope_types) == 1:
|
if len(rule.scope_types) == 1:
|
||||||
# If rule has only one scope, it's fine
|
# If rule has only one scope, it's fine
|
||||||
continue
|
continue
|
||||||
else:
|
expected_scope_types = SCOPE_TYPES_EXCEPTIONS.get(rule_name, [])
|
||||||
expected_scope_types = SCOPE_TYPES_EXCEPTIONS.get(
|
|
||||||
rule_name, [])
|
|
||||||
fail_msg = (
|
fail_msg = (
|
||||||
"Rule %s have scope types %s which are not defined "
|
"Rule %s have scope types %s which are not defined "
|
||||||
"in the exceptions list: %s" % (
|
"in the exceptions list: %s" % (
|
||||||
|
|
|
@ -126,7 +126,6 @@ class TestDbBasePluginIpam(test_db_base.NeutronDbPluginV2TestCase):
|
||||||
if isinstance(request, ipam_req.SpecificAddressRequest):
|
if isinstance(request, ipam_req.SpecificAddressRequest):
|
||||||
if request.address == netaddr.IPAddress(fail_ip):
|
if request.address == netaddr.IPAddress(fail_ip):
|
||||||
raise exception
|
raise exception
|
||||||
else:
|
|
||||||
return str(request.address), subnet_id
|
return str(request.address), subnet_id
|
||||||
else:
|
else:
|
||||||
return auto_ip, subnet_id
|
return auto_ip, subnet_id
|
||||||
|
|
|
@ -1461,7 +1461,6 @@ class L3DvrTestCase(test_db_base_plugin_v2.NeutronDbPluginV2TestCase):
|
||||||
call_info['count'] += 1
|
call_info['count'] += 1
|
||||||
if call_info['count'] == 2:
|
if call_info['count'] == 2:
|
||||||
raise RuntimeError()
|
raise RuntimeError()
|
||||||
else:
|
|
||||||
return orig_update_port(*args, **kwargs)
|
return orig_update_port(*args, **kwargs)
|
||||||
|
|
||||||
# NOTE(trananhkma): expect that update_port() only raises an error
|
# NOTE(trananhkma): expect that update_port() only raises an error
|
||||||
|
|
Loading…
Reference in New Issue