From c95561e2d20867812466c9d5a275f1dc6e3263ac Mon Sep 17 00:00:00 2001 From: Akihiro Motoki Date: Wed, 7 Jun 2017 13:01:03 +0000 Subject: [PATCH] Update pylint disable list to pass pylint 1.7.1 checks Recenly pylint version was bumped to 1.7.1 in global-requirements.txt. Pylint 1.7.1 adds more checks and breaks the neutron pep8 job. This commit adds new checks to the disabled list to avoid the gate breakage. Individual disabled tests can be fixed later. The new disabled list is compatible with pylint 1.4.5, so we can merge this regardless of pylint bump is reverted or not. Closes-Bug: #1696403 Change-Id: If6228d0626413049b82f9d75bcdf3bea7ddacde5 (cherry picked from commit 17ed89cbc12db9d9c8882f1e4162547725d030ec) --- .pylintrc | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.pylintrc b/.pylintrc index df88dbbc390..d95532e7051 100644 --- a/.pylintrc +++ b/.pylintrc @@ -18,6 +18,7 @@ disable= no-member, no-method-argument, no-self-argument, + not-an-iterable, # "W" Warnings for stylistic problems or minor programming issues abstract-method, arguments-differ, @@ -30,6 +31,7 @@ disable= expression-not-assigned, fixme, global-statement, + literal-comparison, no-init, non-parent-init-called, not-callable, @@ -44,19 +46,32 @@ disable= unused-argument, unused-import, unused-variable, + useless-super-delegation, # TODO(dougwig) - disable nonstandard-exception while we have neutron_lib shims nonstandard-exception, # "C" Coding convention violations bad-continuation, + consider-iterating-dictionary, + consider-using-enumerate, invalid-name, + len-as-condition, + misplaced-comparison-constant, missing-docstring, + singleton-comparison, superfluous-parens, + ungrouped-imports, + wrong-import-order, # "R" Refactor recommendations abstract-class-little-used, abstract-class-not-used, + consider-merging-isinstance, + consider-using-ternary, duplicate-code, interface-not-implemented, + no-else-return, no-self-use, + redefined-argument-from-local, + simplifiable-if-statement, too-few-public-methods, too-many-ancestors, too-many-arguments, @@ -64,6 +79,7 @@ disable= too-many-instance-attributes, too-many-lines, too-many-locals, + too-many-nested-blocks, too-many-public-methods, too-many-return-statements, too-many-statements