openstack/neutron
Code Issues Proposed changes

Merge "Add another patch scoping bullet point to effective_neutron"

Browse Source
This commit is contained in:
Jenkins 2015-10-23 22:04:45 +00:00 committed by Gerrit Code Review
commit ca3faa270e
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
doc/source/devref/effective_neutron.rst
View File

@ -237,6 +237,11 @@ Scoping your patch appropriately
in the refactor and changes required for the fix/feature. If it's a bug fix,
try to implement the fix before the refactor to avoid making cherry-picks to
stable branches difficult.
* Consider your reviewers' time before submitting your patch. A patch that
requires many hours or days to review will sit in the "todo" list until
someone has many hours or days free (which may never happen.) If you can
deliver your patch in small but incrementally understandable and testable
pieces you will be more likely to attract reviewers.
Nits and pedantic comments
~~~~~~~~~~~~~~~~~~~~~~~~~~