openstack/neutron
Code Issues Proposed changes

ovs firewall: fix mac learning on the ingress rule table when ovs offload enabled

Browse Source 
In RULES_INGRESS_TABLE table 82 there is a rule for allow established and
related connections. The current rule sends the packet directly to the dest
port without doing a mac learning. This is causing ovs to age out the dest mac
of the remote VM and causing the rule to be changed in flood rule. For the normal
case it fine as they try to avoid high cpu. ovs hardware offload reduce cpu usage
by moving some of the packet processing to nic and flood rule is not offloaded,
therefore it prefre to use the NORMAL action to avoid the flood rule.
We also keep the same logic as today when using explicitly_egress_direct=True
which avoid NORMAL action in the entire pipeline.

Closes-Bug: #1897637

Change-Id: I9b611d62be5d0529e8b35e3d8280baa5be54bc2b
(cherry picked from commit 8fc80b7e13)
This commit is contained in:
Moshe Levi 2020-09-29 00:58:54 +03:00
parent 8654eb2d18
commit cbb949379c
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
neutron/agent/linux/openvswitch_firewall/firewall.py
View File

@ -1310,6 +1310,18 @@ class OVSFirewallDriver(firewall.FirewallDriver):
actions='resubmit(,%d)' % ovs_consts.DROPPED_TRAFFIC_TABLE
)
# NOTE: The OUTPUT action is used instead of NORMAL action to reduce
# cpu utilization, but it causes the datapath rule to be flood rule.
# This is due to mac learning not happened on ingress traffic.
# While this is ok for no offload case, in ovs offload flood rule
# is not offloaded. Therefore, we change the action to be NORMAL in
# offload case. In case the explicitly_egress_direct is used the
# pipeline don't contain action NORMAL so we don't have flood rule
# issue.
actions = 'output:{:d}'.format(port.ofport)
if (self.int_br.br.is_hw_offload_enabled and
not cfg.CONF.AGENT.explicitly_egress_direct):
actions = 'mod_vlan_vid:{:d},normal'.format(port.vlan_tag)
# Allow established and related connections
for state in (ovsfw_consts.OF_STATE_ESTABLISHED_REPLY,
ovsfw_consts.OF_STATE_RELATED):
@ -1320,7 +1332,7 @@ class OVSFirewallDriver(firewall.FirewallDriver):
ct_state=state,
ct_mark=ovsfw_consts.CT_MARK_NORMAL,
ct_zone=port.vlan_tag,
actions='output:{:d}'.format(port.ofport)
actions=actions
)
self._add_flow(
table=ovs_consts.RULES_INGRESS_TABLE,

10
releasenotes/notes/fix-mac-learning-in-case--ovs-offload-26193bf1638fd673.yaml Normal file
View File

@ -0,0 +1,10 @@
---
fixes:
- |
Fixed MAC learning issue when ovs offload enabled. OVS firewall reduce
the usage of normal actions to reduce cpu utilization. This causing flood
rule because there is no MAC learning on ingress traffic. While this ok
for none offload case, when using ovs offload flood rule is not
offloaded. This fix the MAC learning in the offload, so we avoid flood
rule.
`#1897637 <https://bugs.launchpad.net/neutron/+bug/1897637>`_.