From 38cdd93802a84c6a877d989f7f1dceb8eb67b278 Mon Sep 17 00:00:00 2001
From: Anindita Das <anindita.das@intel.com>
Date: Thu, 21 Jul 2016 14:18:41 +0000
Subject: [PATCH] Refactoring config options for extension opts

Refactoring neutron extension config allowedaddresspair opts to be in
neutron/conf so that all the configuration options for extensions
reside in a centralized location. This simplifies the process of
looking up the extension config opts and provides an easy way to import.

Partial-Bug: #1563069

Change-Id: I0a3bf8e903d50513dbdc0734ff4c1a9637bf8c59
---
 neutron/conf/extensions/__init__.py           |  0
 .../conf/extensions/allowedaddresspairs.py    | 28 +++++++++++++++++++
 neutron/extensions/allowedaddresspairs.py     |  9 ++----
 neutron/opts.py                               |  5 ++--
 4 files changed, 33 insertions(+), 9 deletions(-)
 create mode 100644 neutron/conf/extensions/__init__.py
 create mode 100644 neutron/conf/extensions/allowedaddresspairs.py

diff --git a/neutron/conf/extensions/__init__.py b/neutron/conf/extensions/__init__.py
new file mode 100644
index 00000000000..e69de29bb2d
diff --git a/neutron/conf/extensions/allowedaddresspairs.py b/neutron/conf/extensions/allowedaddresspairs.py
new file mode 100644
index 00000000000..1e64bc251dc
--- /dev/null
+++ b/neutron/conf/extensions/allowedaddresspairs.py
@@ -0,0 +1,28 @@
+# Copyright 2013 VMware, Inc.  All rights reserved.
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+
+from oslo_config import cfg
+
+from neutron._i18n import _
+
+
+allowed_address_pair_opts = [
+    #TODO(limao): use quota framework when it support quota for attributes
+    cfg.IntOpt('max_allowed_address_pair', default=10,
+               help=_("Maximum number of allowed address pairs")),
+]
+
+
+def register_allowed_address_pair_opts(cfg=cfg.CONF):
+    cfg.register_opts(allowed_address_pair_opts)
diff --git a/neutron/extensions/allowedaddresspairs.py b/neutron/extensions/allowedaddresspairs.py
index 0914c3315e9..92007bc6237 100644
--- a/neutron/extensions/allowedaddresspairs.py
+++ b/neutron/extensions/allowedaddresspairs.py
@@ -22,14 +22,9 @@ import webob.exc
 from neutron._i18n import _
 from neutron.api import extensions
 from neutron.api.v2 import attributes as attr
+from neutron.conf.extensions import allowedaddresspairs as addr_pair
 
-allowed_address_pair_opts = [
-    #TODO(limao): use quota framework when it support quota for attributes
-    cfg.IntOpt('max_allowed_address_pair', default=10,
-               help=_("Maximum number of allowed address pairs")),
-]
-
-cfg.CONF.register_opts(allowed_address_pair_opts)
+addr_pair.register_allowed_address_pair_opts()
 
 
 class AllowedAddressPairsMissingIP(nexception.InvalidInput):
diff --git a/neutron/opts.py b/neutron/opts.py
index 37b3f190db5..f9d4fcb5fb9 100644
--- a/neutron/opts.py
+++ b/neutron/opts.py
@@ -32,6 +32,7 @@ import neutron.conf.agent.dhcp
 import neutron.conf.agent.l3.config
 import neutron.conf.agent.ovs_conf
 import neutron.conf.common
+import neutron.conf.extensions.allowedaddresspairs
 import neutron.conf.plugins.ml2.drivers.linuxbridge
 import neutron.conf.quota
 import neutron.conf.service
@@ -44,7 +45,6 @@ import neutron.db.l3_dvr_db
 import neutron.db.l3_gwmode_db
 import neutron.db.l3_hamode_db
 import neutron.db.migration.cli
-import neutron.extensions.allowedaddresspairs
 import neutron.extensions.l3
 import neutron.extensions.securitygroup
 import neutron.plugins.ml2.config
@@ -100,7 +100,8 @@ def list_agent_opts():
 def list_extension_opts():
     return [
         ('DEFAULT',
-         neutron.extensions.allowedaddresspairs.allowed_address_pair_opts),
+         neutron.conf.extensions.allowedaddresspairs
+         .allowed_address_pair_opts),
         ('quotas',
          itertools.chain(
              neutron.conf.quota.l3_quota_opts,