openstack
/
neutron
Code Issues Proposed changes

Stops patching an object method which could be gone at cleanup 

Stop patching the qos plugin 'notification_driver_manager' method
and instead substitute for a mock since it's destroyed and reloaded
on every test run.

Closes-Bug: #1489716
Change-Id: I0e84b19bba92a7cbef837de7994a605a78936250
This commit is contained in:
Miguel Angel Ajo 2015-08-28 07:49:28 +02:00
parent 3703a1d4b0
commit ce3fb9065e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
neutron/tests/unit/services/qos/test_qos_plugin.py
View File

@ -46,8 +46,7 @@ class TestQosPlugin(base.BaseQosTestCase):
self.qos_plugin = mgr.get_service_plugins().get(
constants.QOS)
self.notif_driver_m = mock.patch.object(
self.qos_plugin, 'notification_driver_manager').start()
self.qos_plugin.notification_driver_manager = mock.Mock()
self.ctxt = context.Context('fake_user', 'fake_tenant')
self.policy_data = {
@ -69,7 +68,8 @@ class TestQosPlugin(base.BaseQosTestCase):
self.ctxt, **self.rule_data['bandwidth_limit_rule'])
def _validate_notif_driver_params(self, method_name):
method = getattr(self.notif_driver_m, method_name)
method = getattr(self.qos_plugin.notification_driver_manager,
method_name)
self.assertTrue(method.called)
self.assertIsInstance(
method.call_args[0][1], policy_object.QosPolicy)