openstack
/
neutron
Code Issues Proposed changes

[ovn]: fix usage of lrp_set_options api to use **options 

set_gateway_mtu() in ovn_client was passing in options dictionary
to ovsdbapp's nb idl lrp_set_options [1] improperly: it needed it to
be expanded.

[1]: e36f3270e6/ovsdbapp/schema/ovn_northbound/api.py (L559)

Closes-Bug: #1909038
Change-Id: Ib3c8ee48873f3c63c9dc24e4641b392fe7883699
This commit is contained in:
Flavio Fernandes 2020-12-22 16:48:06 -05:00
parent 607f15c1ac
commit d0c5c4764d
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
View File

@ -1621,7 +1621,7 @@ class OVNClient(object):
for port in ports:
lrp_name = utils.ovn_lrouter_port_name(port['id'])
options = self._gen_router_port_options(port, prov_net)
commands.append(self._nb_idl.lrp_set_options(lrp_name, options))
commands.append(self._nb_idl.lrp_set_options(lrp_name, **options))
self._transaction(commands, txn=txn)
def update_network(self, context, network, original_network=None):

2
neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py
View File

@ -1842,7 +1842,7 @@ class TestOVNMechanismDriver(test_plugin.Ml2PluginV2TestCase):
lrp_name = ovn_utils.ovn_lrouter_port_name(port['port']['id'])
self.nb_ovn.lrp_set_options.assert_called_once_with(
lrp_name, expected_opts)
lrp_name, **expected_opts)
def test_update_network_need_to_frag_enabled(self):
ovn_conf.cfg.CONF.set_override('ovn_emit_need_to_frag', True,