openstack
/
neutron
Code Issues Proposed changes

Remove useless check in _rpc_update_firewall 

Firewall_db_mixin.update_firewall returns an updated firewall or raises
an error (if the firewall is not found), that's why checking if its
result is evaluated to False is not required

Change-Id: Ib4e2fa0920783728b8e1cc8597b3edf78e098b52
This commit is contained in:
Cedric Brandily 2014-08-27 11:35:41 +02:00
parent 2f79320552
commit d14797400d
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
neutron/services/firewall/fwaas_plugin.py
View File

@ -182,13 +182,11 @@ class FirewallPlugin(firewall_db.Firewall_db_mixin):
def _rpc_update_firewall(self, context, firewall_id):
status_update = {"firewall": {"status": const.PENDING_UPDATE}}
fw = super(FirewallPlugin, self).update_firewall(context, firewall_id,
status_update)
if fw:
fw_with_rules = (
self._make_firewall_dict_with_rules(context,
firewall_id))
self.agent_rpc.update_firewall(context, fw_with_rules)
super(FirewallPlugin, self).update_firewall(context, firewall_id,
status_update)
fw_with_rules = self._make_firewall_dict_with_rules(context,
firewall_id)
self.agent_rpc.update_firewall(context, fw_with_rules)
def _rpc_update_firewall_policy(self, context, firewall_policy_id):
firewall_policy = self.get_firewall_policy(context, firewall_policy_id)