Removes host file contents from DHCP agent logs

The change I3ad7864eeb2f959549ed356a1e34fa18804395cc addressed a
performance impact by removing logging calls from inside the loop that
creates the hosts file in memory. However, it also introduced the
dumping of said hosts file to the logs.

On deployments with a very high number of ports(>5K), this increases the
load of the node substantially. The problem is worse when a high number
of port updates is received in a short amount of time.

There is also the administrative burden caused by the sheer amount of
data being logged.

If the content of the host file is required for debugging purposes, it
can be found at /opt/stack/data/neutron/dhcp/<net-id>/host

This patch is trivial and only removes the logging of the file contents.
The 'building'/'done building' logging calls may still provide useful


Change-Id: Ie176ef123c194c22dca0967a6acfb9a48c959e6c
Depends-On: I4041478ca09bd124827782774b8520908ef07be0
Closes-Bug: 1557640
(cherry picked from commit ed7411fa1c)
Stephen Eilert 2016-03-15 13:54:23 -07:00 committed by Rawlin Peters
parent 37856aa722
commit d774e70d6b
1 changed files with 1 additions and 2 deletions

View File

@ -671,8 +671,7 @@ class Dnsmasq(DhcpLocalProcess):
(port.mac_address, name, ip_address))
utils.replace_file(filename, buf.getvalue())
LOG.debug('Done building host file %s with contents:\n%s', filename,
LOG.debug('Done building host file %s', filename)
return filename
def _get_client_id(self, port):