From ab62f174095b5d8cdf32134cbca1f3cb79926642 Mon Sep 17 00:00:00 2001 From: Jakub Libosvar Date: Wed, 11 May 2022 17:23:12 -0400 Subject: [PATCH] migration: Fail task if executed script failed Previously the migration playbook continued even if tripleo deploy failed which damaged the environment even more. This patch will make the task fail if deploy fails too. There are also other commands which return code was ignored. Change-Id: Ib27fa676e126503eacb97b24e95aa7cd2982adab Signed-off-by: Jakub Libosvar --- .../playbooks/roles/delete-neutron-resources/tasks/main.yml | 1 - .../playbooks/roles/tripleo-update/tasks/main.yml | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/ovn_migration/tripleo_environment/playbooks/roles/delete-neutron-resources/tasks/main.yml b/tools/ovn_migration/tripleo_environment/playbooks/roles/delete-neutron-resources/tasks/main.yml index 5e58fa9cbeb..869b62e19a0 100644 --- a/tools/ovn_migration/tripleo_environment/playbooks/roles/delete-neutron-resources/tasks/main.yml +++ b/tools/ovn_migration/tripleo_environment/playbooks/roles/delete-neutron-resources/tasks/main.yml @@ -19,4 +19,3 @@ shell: > {{ ovn_migration_temp_dir_del }}/delete-neutron-resources.sh 2>&1 > {{ ovn_migration_temp_dir_del }}/delete-neutron-resources.sh.log - changed_when: true diff --git a/tools/ovn_migration/tripleo_environment/playbooks/roles/tripleo-update/tasks/main.yml b/tools/ovn_migration/tripleo_environment/playbooks/roles/tripleo-update/tasks/main.yml index 8f1a229f6ba..12a0bdfedb1 100644 --- a/tools/ovn_migration/tripleo_environment/playbooks/roles/tripleo-update/tasks/main.yml +++ b/tools/ovn_migration/tripleo_environment/playbooks/roles/tripleo-update/tasks/main.yml @@ -15,10 +15,10 @@ shell: > set -o pipefail && {{ ovn_migration_temp_dir }}/generate-ovn-extras.sh - changed_when: False + args: + creates: $HOME/ovn-extras.yaml - name: Updating the overcloud stack with OVN services shell: > set -o pipefail && {{ overcloud_ovn_deploy_script }} 2>&1 > {{ overcloud_ovn_deploy_script }}.log - changed_when: true