openstack
/
neutron
Code Issues Proposed changes

Remove unused arguments in test methods 

"testtool" library do not pass arguments to the test methods when
executing the tests, except for those ones decorated with mock
patches.

TrivialFix

Change-Id: I623f9a80541b7fd06edce05722577f7cb4d7a653
This commit is contained in:
Rodolfo Alonso Hernandez 2019-12-13 17:17:14 +00:00
parent e04e1d80e4
commit df401ddca1
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
neutron/tests/unit/agent/linux/test_interface.py
View File

@ -491,13 +491,11 @@ class TestOVSInterfaceDriver(TestBase):
mtu=9000)
delete_port.assert_called_once_with('tap0')
def test_unplug(self, bridge=None):
if not bridge:
bridge = 'br-int'
def test_unplug(self):
with mock.patch('neutron.agent.common.ovs_lib.OVSBridge') as ovs_br:
ovs = interface.OVSInterfaceDriver(self.conf)
ovs.unplug('tap0')
ovs_br.assert_has_calls([mock.call(bridge),
ovs_br.assert_has_calls([mock.call('br-int'),
mock.call().delete_port('tap0')])
@ -567,15 +565,14 @@ class TestOVSInterfaceDriverWithVeth(TestOVSInterfaceDriver):
root_dev.assert_has_calls([mock.call.link.set_up()])
ns_dev.assert_has_calls([mock.call.link.set_up()])
def test_plug_new(self, bridge=None, namespace=None):
def test_plug_new(self):
# The purpose of test_plug_new in parent class(TestOVSInterfaceDriver)
# is to test exception(exceptions.ProcessExecutionError), method here
# would not go through that code, So just pass
pass
def test_unplug(self, bridge=None):
if not bridge:
bridge = 'br-int'
def test_unplug(self):
bridge = 'br-int'
with mock.patch('neutron.agent.common.ovs_lib.OVSBridge') as ovs_br:
ovs = interface.OVSInterfaceDriver(self.conf)
ovs.unplug('ns-0', bridge=bridge)