openstack
/
neutron
Code Issues Proposed changes

ml2: remove superfluous %s in LOG.debug() format 

ml2.db.get_dynamic_segment() includes this line:

   LOG.debug("No dynamic segment %s found for "
	     "Network:%(network_id)s, "
	     "Physical network:%(physnet)s, "
	     "segmentation_id:%(segmentation_id)s",
	     {'network_id': network_id,
	      'physnet': physical_network,
	      'segmentation_id': segmentation_id})

Note the superfluous %s in the format string.  At run-time, %s prints
the args hash again and doesn't cause an error, but this is clearly
unintended.

Since there doesn't seem to be any value that was meant to be used
instead, this change simply removes the %s.

Change-Id: I414c7b4497f59927d8b6ec5f057dca19aa4ef122
Closes-Bug: #1404782
This commit is contained in:
Angus Lees 2014-12-22 14:52:42 +11:00
parent fffc6e4712
commit e3492286ca
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/plugins/ml2/db.py
View File

@ -103,7 +103,7 @@ def get_dynamic_segment(session, network_id, physical_network=None,
if record:
return _make_segment_dict(record)
else:
LOG.debug("No dynamic segment %s found for "
LOG.debug("No dynamic segment found for "
"Network:%(network_id)s, "
"Physical network:%(physnet)s, "
"segmentation_id:%(segmentation_id)s",