From ea13f2e83f8c2de3def69b6c883a5c161c3a6180 Mon Sep 17 00:00:00 2001 From: hamalq Date: Thu, 28 May 2020 23:17:28 +0000 Subject: [PATCH] Sync the dns-assignment with the actual designate dns-domain When a port is created the dns-assignment (dns-domain part) was always taken form Neutron config dns_domain which is not always true, since it could be Neutron network dns_domain or the dns_domain sent when creating the port Change-Id: I7f4366ff5a26f73013433bfbfb299fd06294f359 Closes-Bug:1873091 --- neutron/plugins/ml2/extensions/dns_integration.py | 2 ++ .../unit/plugins/ml2/extensions/test_dns_integration.py | 3 +++ .../notes/fix-port-dns-assignment-9d916d77522abd65.yaml | 6 ++++++ 3 files changed, 11 insertions(+) create mode 100644 releasenotes/notes/fix-port-dns-assignment-9d916d77522abd65.yaml diff --git a/neutron/plugins/ml2/extensions/dns_integration.py b/neutron/plugins/ml2/extensions/dns_integration.py index 60d5e06bf12..2bf79f79a52 100644 --- a/neutron/plugins/ml2/extensions/dns_integration.py +++ b/neutron/plugins/ml2/extensions/dns_integration.py @@ -288,6 +288,8 @@ class DNSExtensionDriver(api.ExtensionDriver): if dns_domain and dns_domain != lib_const.DNS_DOMAIN_DEFAULT: if dns_data_db: dns_name = dns_data_db.dns_name + if dns_data_db.current_dns_domain: + dns_domain = dns_data_db.current_dns_domain return dns_name, dns_domain def _get_dns_names_for_port(self, ips, dns_data_db): diff --git a/neutron/tests/unit/plugins/ml2/extensions/test_dns_integration.py b/neutron/tests/unit/plugins/ml2/extensions/test_dns_integration.py index da3c08b9c2a..75783ad0b42 100644 --- a/neutron/tests/unit/plugins/ml2/extensions/test_dns_integration.py +++ b/neutron/tests/unit/plugins/ml2/extensions/test_dns_integration.py @@ -165,6 +165,9 @@ class DNSIntegrationTestCase(test_plugin.Ml2PluginV2TestCase): self.assertEqual(current_dns_name, dns_data_db['current_dns_name']) self.assertEqual(previous_dns_name, dns_data_db['previous_dns_name']) + curr_dns_domain = dns_data_db['current_dns_domain'] + for fqdn in port['dns_assignment']: + self.assertTrue(fqdn['fqdn'].endswith(curr_dns_domain)) if current_dns_name: self.assertEqual(current_dns_domain, dns_data_db['current_dns_domain']) diff --git a/releasenotes/notes/fix-port-dns-assignment-9d916d77522abd65.yaml b/releasenotes/notes/fix-port-dns-assignment-9d916d77522abd65.yaml new file mode 100644 index 00000000000..3a45c69e89c --- /dev/null +++ b/releasenotes/notes/fix-port-dns-assignment-9d916d77522abd65.yaml @@ -0,0 +1,6 @@ +--- +features: + - | + The dns-assignment will reflect the dns-domain defined in the network or + sent by user when creating the port using --dns-domain rather than just + take the dns-domain defined in the neutron configuration