openstack/neutron
Code Issues Proposed changes

Merge "Use elevated context to get default SG from database"

Browse Source
This commit is contained in:
Zuul
2021-08-04 10:41:52 +00:00
committed by Gerrit Code Review
parent 4d205504b8 f6c3747cae
commit ece64f3857
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
neutron/db/securitygroups_db.py
View File

@@ -141,7 +141,14 @@ class SecurityGroupDbMixin(ext_sg.SecurityGroupPluginBase,
reservation.reservation_id) reservation.reservation_id)
# fetch sg from db to load the sg rules with sg model. # fetch sg from db to load the sg rules with sg model.
sg = sg_obj.SecurityGroup.get_object(context, id=sg.id) # NOTE(slaweq): With new system/project scopes it may happen that
# project admin will try to list security groups for different
# project and during that call Neutron will ensure that default
# security group is created. In such case elevated context needs to
# be used here otherwise, SG will not be found and error 500 will
# be returned through the API
get_context = context.elevated() if default_sg else context
sg = sg_obj.SecurityGroup.get_object(get_context, id=sg.id)
secgroup_dict = self._make_security_group_dict(sg) secgroup_dict = self._make_security_group_dict(sg)
self._registry_notify(resources.SECURITY_GROUP, self._registry_notify(resources.SECURITY_GROUP,
events.PRECOMMIT_CREATE, events.PRECOMMIT_CREATE,