From ecfcd4b3931b56fd5d4aefd1e33660efa570b5a8 Mon Sep 17 00:00:00 2001 From: Slawek Kaplonski Date: Thu, 5 Dec 2024 10:02:22 +0100 Subject: [PATCH] [Fullstack] Don't assert no connectivity after host is stopped In the fullstack L3 HA tests, after fake host with router was killed or disconnected (so wasn't stopped gracefully) there was assertion that connectivity using Floating IP is broken for short period of time. This could lead to the race between test and keepalived which is doing failover. If keepalived was fast enough, test could fail at this assertion as failover would already happen and Floating IP would be working fine again. This patch removes that assertion of no connectity as this can't be really controlled by the test and may lead to random failures. It's also not the most important thing in those tests - we should make sure that connectivity is working fine after host is crashed thanks to the failover which should happen and that is tested in the same tests. Closes-bug: #2091021 Change-Id: Ib00c9823e3600bb2c234cbc90cac81723b4eec11 (cherry picked from commit 813e743f0665b30082e3f6789850019dc35bcad7) --- neutron/tests/fullstack/test_l3_agent.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/neutron/tests/fullstack/test_l3_agent.py b/neutron/tests/fullstack/test_l3_agent.py index cd077ed27dc..8cacad992ed 100644 --- a/neutron/tests/fullstack/test_l3_agent.py +++ b/neutron/tests/fullstack/test_l3_agent.py @@ -514,13 +514,6 @@ class TestHAL3Agent(TestL3Agent): elif method == 'shutdown': active_host.shutdown(parent=self.environment) - if method != 'shutdown': - # Ensure connectivity is shortly lost if the failover is not - # graceful - vm.assert_no_ping(external.ip) - - LOG.debug(f'Connectivity lost after {datetime.now() - start}') - # Ensure connectivity is restored vm.block_until_ping(external.ip) LOG.debug(f'Connectivity restored after {datetime.now() - start}')