openstack/neutron
Code Issues Proposed changes

Remove quotes from subshell call in tools/split.sh

Browse Source 
Always no quotes for $() statement.

We don't need quotes to hold blanks in result:
 # i=$(echo 1 2 3)
 # echo $i
 1 2 3
 #

These quotes can make something wrong in some case:
 # i=$(echo '!')
 #
 # i="$(echo '!')"
 -bash: !: event not found
 #

No real problem for current code in split.sh, only to use a
better code style.

Change-Id: Ib86d59e10be0aca4774ad2fc656915a96b1b6c74
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
This commit is contained in:
Zhao Lei 2015-08-07 21:17:20 +08:00
parent 78e6ddb903
commit ed9703e3ed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/split.sh
View File

@ -45,7 +45,7 @@ pruner="git ls-files | grep -v \"$keep_pattern\" | git update-index --force-remo
roots=""
for file in $files_to_keep; do
file_root="$(git rev-list --reverse HEAD -- $file | head -n1)"
file_root=$(git rev-list --reverse HEAD -- $file | head -n1)
fail=0
for root in $roots; do
if git merge-base --is-ancestor $root $file_root; then