openstack/neutron
Code Issues Proposed changes

Remove unused parameter from _update_router_db method

Browse Source 
While gw_info is being passed to _update_router_db method
of various classes it is never actually used, so this is just
a cleanup.

Change-Id: I311f6976c21fa07a7532c3d0bbe56b5e35a18f6e
Closes-Bug: #1526785
This commit is contained in:
Eugene Nikanorov
2015-12-16 16:58:47 +04:00
parent ab8adcf693
commit f0d0d354a7
5 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
neutron/db/l3_db.py
View File

@@ -188,7 +188,7 @@ class L3_NAT_dbonly_mixin(l3.RouterPluginBase):
return self._make_router_dict(router_db) return self._make_router_dict(router_db)
def _update_router_db(self, context, router_id, data, gw_info): def _update_router_db(self, context, router_id, data):
"""Update the DB object.""" """Update the DB object."""
with context.session.begin(subtransactions=True): with context.session.begin(subtransactions=True):
router_db = self._get_router(context, router_id) router_db = self._get_router(context, router_id)
@@ -212,7 +212,7 @@ class L3_NAT_dbonly_mixin(l3.RouterPluginBase):
self._update_router_gw_info(context, id, gw_info) self._update_router_gw_info(context, id, gw_info)
else: else:
candidates = None candidates = None
router_db = self._update_router_db(context, id, r, gw_info) router_db = self._update_router_db(context, id, r)
if candidates: if candidates:
l3_plugin = manager.NeutronManager.get_service_plugins().get( l3_plugin = manager.NeutronManager.get_service_plugins().get(
constants.L3_ROUTER_NAT) constants.L3_ROUTER_NAT)

8
neutron/db/l3_dvr_db.py
View File

@@ -107,7 +107,7 @@ class L3_NAT_with_dvr_db_mixin(l3_db.L3_NAT_db_mixin,
reason=e) reason=e)
def _update_distributed_attr( def _update_distributed_attr(
self, context, router_id, router_db, data, gw_info): self, context, router_id, router_db, data):
"""Update the model to support the dvr case of a router.""" """Update the model to support the dvr case of a router."""
if data.get('distributed'): if data.get('distributed'):
old_owner = l3_const.DEVICE_OWNER_ROUTER_INTF old_owner = l3_const.DEVICE_OWNER_ROUTER_INTF
@@ -116,18 +116,18 @@ class L3_NAT_with_dvr_db_mixin(l3_db.L3_NAT_db_mixin,
rp.port_type = new_owner rp.port_type = new_owner
rp.port.device_owner = new_owner rp.port.device_owner = new_owner
def _update_router_db(self, context, router_id, data, gw_info): def _update_router_db(self, context, router_id, data):
with context.session.begin(subtransactions=True): with context.session.begin(subtransactions=True):
router_db = super( router_db = super(
L3_NAT_with_dvr_db_mixin, self)._update_router_db( L3_NAT_with_dvr_db_mixin, self)._update_router_db(
context, router_id, data, gw_info) context, router_id, data)
migrating_to_distributed = ( migrating_to_distributed = (
not router_db.extra_attributes.distributed and not router_db.extra_attributes.distributed and
data.get('distributed') is True) data.get('distributed') is True)
self._validate_router_migration(context, router_db, data) self._validate_router_migration(context, router_db, data)
router_db.extra_attributes.update(data) router_db.extra_attributes.update(data)
self._update_distributed_attr( self._update_distributed_attr(
context, router_id, router_db, data, gw_info) context, router_id, router_db, data)
if migrating_to_distributed: if migrating_to_distributed:
if router_db['gw_port_id']: if router_db['gw_port_id']:
# If the Legacy router is getting migrated to a DVR # If the Legacy router is getting migrated to a DVR

4
neutron/db/l3_hamode_db.py
View File

@@ -411,7 +411,7 @@ class L3_HA_NAT_db_mixin(l3_dvr_db.L3_NAT_with_dvr_db_mixin,
router_dict['ha_vr_id'] = router_db.extra_attributes.ha_vr_id router_dict['ha_vr_id'] = router_db.extra_attributes.ha_vr_id
return router_dict return router_dict
def _update_router_db(self, context, router_id, data, gw_info): def _update_router_db(self, context, router_id, data):
router_db = self._get_router(context, router_id) router_db = self._get_router(context, router_id)
original_distributed_state = router_db.extra_attributes.distributed original_distributed_state = router_db.extra_attributes.distributed
@@ -427,7 +427,7 @@ class L3_HA_NAT_db_mixin(l3_dvr_db.L3_NAT_with_dvr_db_mixin,
with context.session.begin(subtransactions=True): with context.session.begin(subtransactions=True):
router_db = super(L3_HA_NAT_db_mixin, self)._update_router_db( router_db = super(L3_HA_NAT_db_mixin, self)._update_router_db(
context, router_id, data, gw_info) context, router_id, data)
ha_not_changed = (requested_ha_state is None or ha_not_changed = (requested_ha_state is None or
requested_ha_state == original_ha_state) requested_ha_state == original_ha_state)

2
neutron/tests/unit/db/test_l3_dvr_db.py
View File

@@ -122,7 +122,7 @@ class L3DvrTestCase(test_db_base_plugin_v2.NeutronDbPluginV2TestCase):
return_value={'agents': [agent]}) return_value={'agents': [agent]})
self.mixin._unbind_router = mock.Mock() self.mixin._unbind_router = mock.Mock()
router_db = self.mixin._update_router_db( router_db = self.mixin._update_router_db(
self.ctx, router_id, distributed, mock.ANY) self.ctx, router_id, distributed)
# Assert that the DB value has changed # Assert that the DB value has changed
self.assertTrue(router_db.extra_attributes.distributed) self.assertTrue(router_db.extra_attributes.distributed)
self.assertEqual(1, self.assertEqual(1,

3
neutron/tests/unit/db/test_l3_hamode_db.py
View File

@@ -88,8 +88,7 @@ class L3HATestFramework(testlib_api.SqlTestCase):
data['distributed'] = distributed data['distributed'] = distributed
if admin_state is not None: if admin_state is not None:
data['admin_state_up'] = admin_state data['admin_state_up'] = admin_state
return self.plugin._update_router_db(ctx, router_id, return self.plugin._update_router_db(ctx, router_id, data)
data, None)
def _bind_router(self, router_id): def _bind_router(self, router_id):
with self.admin_ctx.session.begin(subtransactions=True): with self.admin_ctx.session.begin(subtransactions=True):