openstack
/
neutron
Code Issues Proposed changes

Removed spurious check for ip version 

We may assume that _add_ingress_ra_rule() receives only RA (=IPv6)
ports, so no need to check IP version one more time.

The corresponding IP version filter is already applied in
_select_ra_ips_for_network_ids().

Change-Id: Ibde56a2eb32eed468defdd02a44cc3360ce82e53
This commit is contained in:
Ihar Hrachyshka 2014-12-16 16:23:40 +01:00
parent 5de1d2ed67
commit ffa793b27c
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
neutron/db/securitygroups_rpc_base.py
View File

@ -411,9 +411,6 @@ class SecurityGroupServerRpcMixin(sg_db.SecurityGroupDbMixin):
def _add_ingress_ra_rule(self, port, ips):
ra_ips = ips.get(port['network_id'])
for ra_ip in ra_ips:
if not netaddr.IPAddress(ra_ip).version == 6:
return
ra_rule = {'direction': 'ingress',
'ethertype': q_const.IPv6,
'protocol': q_const.PROTO_NAME_ICMP_V6,