7 Commits (master)

Author	SHA1	Message	Date
Boden R	9bbe9911c4	remove neutron.common.constants ... All of the externally consumed variables from neutron.common.constants now live in neutron-lib. This patch removes neutron.common.constants and switches all uses over to lib. NeutronLibImpact Depends-On: https://review.openstack.org/#/c/647836/ Change-Id: I3c2f28ecd18996a1cee1ae3af399166defe9da87	4 years ago
SapanaJadhav	d8807e2fa9	Wrong path of rpc_api.rst in class docstring ... Changing rpc_api.rst file path from doc/source/devref/rpc_api.rst to /doc/source/contributor/internals/rpc_api.rst. Because rpc_api.rst file is located at this path doc/source/contributor/internals/rpc_api.rst. Closes-Bug #1722072 Change-Id: Ic243aab9e3428bfec69db61a94b4129cd768e233	6 years ago
Armando Migliaccio	17563a802e	Adopt neutron-lib plugin directory ... Neutron Manager is loaded at the very startup of the neutron server process and with it plugins are loaded and stored for lookup purposes as their references are widely used across the entire neutron codebase. Rather than holding these references directly in NeutronManager this patch refactors the code so that these references are held by a plugin directory. This allows subprojects and other parts of the Neutron codebase to use the directory in lieu of the manager. The result is a leaner, cleaner, and more decoupled code. Usage pattern [1,2] can be translated to [3,4] respectively. [1] manager.NeutronManager.get_service_plugins()[FOO] [2] manager.NeutronManager.get_plugin() [3] directory.get_plugin(FOO) [4] directory.get_plugin() The more entangled part is in the neutron unit tests, where the use of the manager can be simplified as mocking is typically replaced by a call to the directory add_plugin() method. This is safe as each test case gets its own copy of the plugin directory. That said, unit tests that look more like API tests and that rely on the entire plugin machinery, need some tweaking to avoid stumbling into plugin loading failures. Due to the massive use of the manager, deprecation warnings are considered impractical as they cause logs to bloat out of proportion. Follow-up patches that show how to adopt the directory in neutron subprojects are tagged with topic:plugin-directory. NeutronLibImpact Partially-implements: blueprint neutron-lib Change-Id: I7331e914234c5f0b7abe836604fdd7e4067551cf	7 years ago
Ihar Hrachyshka	7a2a85623d	oslo: migrate to namespace-less import paths ... Oslo project decided to move away from using oslo.* namespace for all their libraries [1], so we should migrate to new import path. This patch applies new paths for: - oslo.config - oslo.db - oslo.i18n - oslo.messaging - oslo.middleware - oslo.rootwrap - oslo.serialization - oslo.utils Added hacking check to enforce new import paths for all oslo libraries. Updated setup.cfg entry points. We'll cleanup old imports from oslo-incubator modules on demand or if/when oslo officially deprecates old namespace in one of the next cycles. [1]: https://blueprints.launchpad.net/oslo-incubator/+spec/drop-namespace-packages Depends-On: https://review.openstack.org/#/c/147248/ Depends-On: https://review.openstack.org/#/c/152292/ Depends-On: https://review.openstack.org/#/c/147240/ Closes-Bug: #1409733 Change-Id: If0dce29a0980206ace9866112be529436194d47e	8 years ago
Russell Bryant	caedc3ee05	Scope metadata rpc api using a messaging namespace ... This patch does a couple of things. First it adds docstrings to the client/server pair of the rpc interface used by the metadata service to make calls back into the Neutron server. The docs tell you where the other side of the interface is found in the code, and where docs are that give more info on the rules for changing them. The second thing done in this patch is to scope this interface using a messaging namespace. Right now some plugins expose several interfaces via the default namespace. This effectively means they are a single API and should be managed with a single version stream. It's much more managable to just treat these as separate interfaces and this change makes that explicit and functionally true. Now when a method is invoked, the only classes considered for handling that request will be ones marked with the right namespace. Part of blueprint rpc-docs-and-namespaces. Change-Id: I3330229bf85b01d50c90e9ca064ae5e0fae83509	9 years ago
Russell Bryant	f7f2aa931f	Drop several uses of RpcCallback ... This patch drops several uses of the RpcCallback compatibility class. All of these were trivial and straight forward conversions so I batched them up. There are still several other uses of RpcCallback, but the conversions are were not necessarily trivial, and may be broken in one way or another, so I wanted to address them separately. In particular, the use of mixin classes means that there could be cases where the version declaration is being stepped on, so they need to be investigated more closely. Part of blueprint drop-rpc-compat. Change-Id: I0977aee863d4fcc6a14a025215c6e41fe38a87f0	9 years ago
Oleg Bondarev	a19ec4a732	Use RPC instead of neutron client in metadata agent ... RPC is a standard way of interacting between Neutron server and agents Using neutron client is also inefficient as it results in unneeded keystone load and may become a bottleneck at scale DocImpact When upgrading, one should upgrade neutron server first, then metadata agent. However there is a fallback in case metadata agent fails to get info from server by rpc - it will return to using neutron client. Closes-Bug: #1092043 Change-Id: Ib75568643e6062543c0ff8cf80fba1b40b4fe82f	9 years ago