309 Commits

Author SHA1 Message Date
Ryan Moats
44cc4b9a63 Fix capitalization nit in patch 230218
Fixes the Neutron capitalization nit found by Paul Carver
in patch 230218 after it was in the gate.

Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Change-Id: I27481b70dbd313ba1fa54708d46db8b99a7e670d
2015-10-06 07:42:04 -05:00
Jenkins
9769466fef Merge "Add a note about agent/server compat to 'effective neutron'" 2015-10-06 11:27:40 +00:00
Jenkins
e7ccd8ae36 Merge "Add note about negative feedback to 'effective neutron'" 2015-10-06 09:37:29 +00:00
Jenkins
c3da8fbec8 Merge "Document self.assertEqual(expected, observed) pattern" 2015-10-06 07:52:49 +00:00
Kevin Benton
56c5732347 Add note about negative feedback to 'effective neutron'
Change-Id: I7808d23779c09f492eef5f024e19285820db57b0
2015-10-05 23:40:00 -07:00
Kevin Benton
a711ce8f00 Add a note about agent/server compat to 'effective neutron'
Change-Id: I4e7476c4cf29aa0eb2722885c7d407d8ea197f1b
2015-10-05 23:39:29 -07:00
Jenkins
863c41ba68 Merge "Use assertIn and assertNotIn" 2015-10-06 00:19:43 +00:00
Cedric Brandily
2429dd917f Document self.assertEqual(expected, observed) pattern
Tests should use the following pattern to help reviewers:

  self.assertEqual(expected, observed)

This change documents it in effective_neutron.rst and corrects some test
modules[1] including nonobvious ones[2] as an example.

[1] neutron.tests.unit.agent.l3.test_.*
[2] neutron.tests.unit.agent.l3.test_router_processing_queue

Change-Id: I6d6363541e3fef6f66e808aab00507825205b209
2015-10-06 01:03:53 +02:00
Cedric Brandily
49746ca474 Use assertIn and assertNotIn
Neutron tests should use:

  self.assertIn(value, list)
  self.assertNotIn(value, list)

instead of:

  self.assertTrue(value in list)
  self.assertFalse(value in list)

because assertIn and assertNotIn raise more meaningful errors:

  self.assertIn(3, [1, 2]
  >>> MismatchError: 3 not in [1, 2]

  self.assertTrue(3 in [1, 2])
  >>> AssertionError: False is not true

Closes-Bug: #1218713

Change-Id: Ic8492a88935bf005feb9dae726a4bee604a8bd09
2015-10-05 20:47:18 +02:00
Jenkins
65a227514e Merge "Changes in Neutron defect management" 2015-10-05 15:32:46 +00:00
armando-migliaccio
06298824f0 Changes in Neutron defect management
This patch proposes some changes to the way we manage
bugs in Neutron, and how defect management is to be shared
across the Neutron team.

Change-Id: I51bf74cef11dc17b88c18a2007306b913da9f981
2015-10-02 09:56:27 -07:00
Jenkins
6d9b5fc6ce Merge "Add more commit msg tips to 'effective neutron'" 2015-10-02 07:49:39 +00:00
Kevin Benton
b4a16e06bb Add more commit msg tips to 'effective neutron'
This adds a few more tips to the commit message guidelines in
the effective neutron devref.

Change-Id: I31ae7cb4303ff36aa9359d3fe284dde9a7ed8757
2015-10-01 23:59:47 -04:00
Jenkins
986df5b3e6 Merge "Effective Neutron: add link to logging guidelines" 2015-10-02 01:52:03 +00:00
armando-migliaccio
523b4105d4 Effective Neutron: add link to low-hanging-fruit bugs
To draw attention to newbies where it matters

Change-Id: Iabab0b4f1e6e901f122c793a64d74fc4412c7e39
2015-10-01 12:52:46 -07:00
armando-migliaccio
32eaeb79a7 Effective Neutron: add link to logging guidelines
Change-Id: If9a3e3827d1c917331d4fa321a5ada63993087fe
2015-10-01 11:06:12 -07:00
Jenkins
9ccefdac56 Merge "Add devref for alembic milestone tagging" 2015-09-30 21:24:23 +00:00
JuPing
824b4dc8ac Fix the bug of "Error spelling of 'accomodate'"
The word "accomodate " should be spelled as "accommodate".
So it is changed.

Change-Id: Ie0aae93973c0efec34c3d4baf0d3d2783c6eeef8
Closes-Bug: #1501216
2015-10-01 00:16:18 +08:00
gong yong sheng
e1147e63a5 Fix URL target problem
Change-Id: I7290801b110ff5d6f896bd122342ed7ad9eca014
2015-09-30 11:47:12 +08:00
Henry Gessau
10b4e0964a Add devref for alembic milestone tagging
Related-Bug: #1499033

Change-Id: Iff58622c56be2c64cfb5659d20c4eae2f45a318c
2015-09-29 23:25:49 -04:00
Jenkins
f2e1de964c Merge "Devref for authorization policies enforcement" 2015-09-29 04:16:34 +00:00
armando-migliaccio
d9e9a64e56 Adding trailing underscores to devref links
These were missed and it led to bad rendering.

Change-Id: If2ae0e542b16d9c82cbbdcb854b8b3612f64199a
2015-09-28 11:28:32 -07:00
Salvatore Orlando
b3b41d4141 Devref for authorization policies enforcement
This patch adds a policy.rst document which describes how the
neutron.policy module works, how it uses oslo_policy and how
it's wired in API controllers.

The patch also remove an obsolete docstring from neutron/policy.py

Change-Id: I3353a23f4e97824a5a91eaedf57a91ace031a9de
2015-09-26 00:25:37 -07:00
Jenkins
6f5ffa4673 Merge "Add --verbose to subset of cmds in neutron-db-manage" 2015-09-24 17:03:14 +00:00
Ryan Moats
3044f320f1 Fix a few nits with the dashboard pages
1. Use correct title in gate pipeline page
2. Update lbaasv2 job name in check pipeline page

Change-Id: Ie94ecf0b2fde9a8faebf8637ba77691fde6307d4
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
2015-09-23 11:50:48 -05:00
Akihiro Motoki
63ed6aaecd Fix the broken link in devref docs
The link to Dashboard is broken in the generated docuemnt
http://docs.openstack.org/developer/neutron/
This patch fixes it and addresses warnings so that
tox -e docs works.

Also add a reference to Gerrit Dashboard Creator
so that developers can customize it to what they want.

Change-Id: Ic45ab48e68af9e5e8255161fe9eb2354ae124f50
2015-09-23 10:10:06 -05:00
Ryan Moats
f12537fb89 Add neutron subproject & stable branch gerrit review links
Add links to gerrit URLs that will list reviews for both neutron
subprojects as well as stable branches.

Change-Id: I3b6ab4e57e904dc19ef6e7d116c8b0465e53c21b
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
2015-09-22 13:38:47 -05:00
Ryan Moats
e917a01a7e Link dashboards into generated documentation
Move the dashboard directory under the source tree so that
it is available on generated builds. In addition, recast
image pages as RST so that they will be rendered

Change-Id: I316128491e8dae70ac06e260f5bdd8f440d285aa
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
2015-09-22 13:38:28 -05:00
Ryan Moats
2eafd3c8ac Add neutron/master review link to dashboard/index.html
Add a link to gerrit that provide a summary of outstanding
neutron/master reviews

Change-Id: Ic79eedffc6c0bc761757525e6d7c812f9a470158
2015-09-22 13:38:08 -05:00
Ryan Moats
91df8c7284 Create dashboard page with gate jobs statistics
Also added index.html page to allow selection of which graphs
to show.  Linking to existing RST comes in a child patch

Change-Id: I6edd7976ae009fc0279238b30ca5223088b6d81d
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
2015-09-22 10:23:44 -05:00
Ryan Moats
a23492b526 Rename check pipeline dashboards
The title and filename of the original graphite dashboards is
incorrect - it should refer to the check pipeline.

Change-Id: Ib17bce084e9a83f1a3db33c47cb7e141e7f5903c
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
2015-09-21 11:18:13 -05:00
Matt Thompson
b08c3d57a9 Add --verbose to subset of cmds in neutron-db-manage
This commit updates neutron/db/migration/cli.py such that --verbose can
be passed to the following commands:

- current
- history
- branches

We also update tests in neutron/tests/unit/db/test_migration.py and add
a new test for 'neutron-db-manage branches' as that appears to be
untested.

Lastly, we add a brief description of the newly added capability to
doc/source/devref/alembic_migrations.rst.

Change-Id: I9fc136055b422f12a22c1365f52f17df53219820
Closes-Bug: #1488021
2015-09-18 13:01:45 +00:00
armando-migliaccio
515ac13fb3 Add skeleton to 'Effective Neutron' devref
Have you ever wondered why you were making the same mistakes
over and over again and wondered how you can remind yourself not
to repeat them again?

Have you ever felt like you posted review comments on some other
patch, only to see that the same anti-pattern was adopted in
someone else's?

Have you wondered what the heck that test was meant to validate?

Does that sound familiar to you? Yes? Great, we have the answer
for you! 'Effective Neutron' is the solution to all your problems!
From now on, everytime you bang your head against the monitor, do
not despair! You may find the answer to your grief in our collective
guide!

Go check it out!

(Your mileage may vary -- add your disclaimer here)

Change-Id: If1b8c1d04e1204985a4f9febb775c4fdb20305e9
2015-09-17 17:26:23 -07:00
Jenkins
a8d364cb18 Merge "No network devices on network attached qos policies" 2015-09-16 22:49:26 +00:00
Miguel Angel Ajo
fe236bdaad No network devices on network attached qos policies
Network devices, like internal router legs, or dhcp ports
should not be affected by bandwidth limiting rules.

This patch disables application of network attached policies
to network/neutron owned ports.

Closes-bug: #1486039
DocImpact

Change-Id: I75d80227f1e6c4b3f5fa7762b8dc3b0c0f1abd46
2015-09-16 15:11:04 +02:00
Jenkins
eb4bf4cc29 Merge "sub_project_guidelines: Add richer documentation" 2015-09-15 14:33:47 +00:00
Kyle Mestery
b01f2f0825 sub_project_guidelines: Add richer documentation
Add additional documentation around releasing sub-projects.

Change-Id: I71f31b6b8ed085066491e181074b467435f8d66d
Signed-off-by: Kyle Mestery <mestery@mestery.com>
2015-09-14 17:19:46 +00:00
Ryan Moats
bfebc9f8af Fix typo: Large Ops, not Large Opts
Change-Id: I73e64e19275f002fcc2ae2e903611835bfd98f8a
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
2015-09-14 11:31:10 -05:00
Salvatore Orlando
14ef151fe0 Restore reservations in API controller
This patch restores the reservation logic in the API controller,
as the DB issues arising from the pymysql switch has been solved.

Change-Id: I98b40925fdceba13d6a2b5a4d0c5793aeb5cf077
Related-Bug: #1486134
Related-Blueprint: better-quotas
2015-09-11 14:44:02 -07:00
Assaf Muller
bcafe20a14 Add l2pop support to full stack tests
Add the l2pop mechanism driver to the ML2 plugin configuration, and set
l2_population = True, in the OVS agent configuration.
Each test class can enable or disable l2pop in its environment.

Change-Id: If4f2bf07883b763073b5a53f1aa557acb131d176
2015-09-10 14:31:35 +00:00
Assaf Muller
a885c4075a Add tunneling support to full stack tests
* EnvironmentDescription class now accepts 'network_type'.
  It sets the ML2 segmentation type, passes it to the OVS agents
  configuration files, and sets up the host configuration. If
  tunnelling type is selected, it sets up a veth pair with an IP
  address from the 240.0.0.1+ range. The addressed end of
  this pair is configured as the local_ip for tunneling purposes
  in each of the OVS agents. If network type is not tunnelled, it
  sets up provider bridges instead and interconnects them.
* For now we run the basic L3 HA test with VLANs and tunneling just
  so we have something to show for.
* I started using scenarios in fullstack tests to run the same test
  with VLANs or tunneling, and because test names are used for log
  dirs, and testscenarios changes test names to include characters
  that are not shell friendly (Space, parenthesis), I 'sanitized'
  some of those characters.

Change-Id: Ic45cc27396452111678cf85ab26b07275846ce44
2015-09-10 14:30:21 +00:00
Jenkins
9ace00747e Merge "Remove implicit registration of *-aas service providers" 2015-09-05 04:50:27 +00:00
Jenkins
35a9d72f46 Merge "Enable most unit tests for py34 job" 2015-09-04 20:55:18 +00:00
Ihar Hrachyshka
ef409d9da2 Enable most unit tests for py34 job
* Skip TestWSGIServerWithSSL[1] for Python 3 since it seems wsgi + ssl +
  eventlet setup does not behave correctly now,
* Skip test_json_with_utf8[2] until we solve unicode/utf8 encode/decode,
* Fix some more tests to pass for py3,
* Replace print by print() in docs/docstrings.

[1] neutron.tests.unit.test_wsgi (bug 1482633)
[2] neutron.tests.unit.test_wsgi.JSONDictSerializerTest (bug 1491824)

Related-Bug: #1482633
Related-Bug: #1491824
Blueprint: neutron-python3
Co-Authored-By: Cyril Roelandt <cyril@redhat.com>
Co-Authored-By: Cedric Brandily <zzelle@gmail.com>
Co-Authored-By: sonu.kumar <sonu.kumar@nectechnologies.in>
Change-Id: I26e513d4dcf473f4cd79728382fc94af3d901b5d
2015-09-04 08:30:22 +00:00
armando-migliaccio
9022fb1ae8 Remove implicit registration of *-aas service providers
Implicit registration can be dropped when explicit registration
for load balancer and vpn is implemented. Firewall does not
use service providers and the ServiceTypeManager, so the
precautionary step can be dropped altogether.

Support for configuring providers via the service_providers section
in neutron.conf, is no longer available, hence clear the stale
entry points.

DocImpact

Closes-bug: #1473110

Change-Id: I5e1d254b9a3a24121d9e9d3cb82f877d44079296
2015-09-02 16:13:59 +00:00
Jenkins
43c00a9f65 Merge "[neutron-db-manage] Introduce contract and expand commands" 2015-09-01 02:54:23 +00:00
Jenkins
9ff6f849b2 Merge "Add lieutenants contact for networking-calico" 2015-08-31 22:35:12 +00:00
Neil Jerram
8a588dc95e Add lieutenants contact for networking-calico
Change-Id: Idc688a380e82ea6a385efc7b459b46e2daed0b4a
2015-08-31 11:16:24 +01:00
Neil Jerram
81c2a7787f Adding networking-calico to sub_projects document
Change-Id: I537936dcc1723c76c12e816ff04645abaa7a8431
2015-08-31 11:10:53 +01:00
Jenkins
85e60859ba Merge "Adding networking-onos to sub_projects document" 2015-08-30 06:17:19 +00:00