Fixes the Neutron capitalization nit found by Paul Carver
in patch 230218 after it was in the gate.
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
Change-Id: I27481b70dbd313ba1fa54708d46db8b99a7e670d
Tests should use the following pattern to help reviewers:
self.assertEqual(expected, observed)
This change documents it in effective_neutron.rst and corrects some test
modules[1] including nonobvious ones[2] as an example.
[1] neutron.tests.unit.agent.l3.test_.*
[2] neutron.tests.unit.agent.l3.test_router_processing_queue
Change-Id: I6d6363541e3fef6f66e808aab00507825205b209
Neutron tests should use:
self.assertIn(value, list)
self.assertNotIn(value, list)
instead of:
self.assertTrue(value in list)
self.assertFalse(value in list)
because assertIn and assertNotIn raise more meaningful errors:
self.assertIn(3, [1, 2]
>>> MismatchError: 3 not in [1, 2]
self.assertTrue(3 in [1, 2])
>>> AssertionError: False is not true
Closes-Bug: #1218713
Change-Id: Ic8492a88935bf005feb9dae726a4bee604a8bd09
This patch proposes some changes to the way we manage
bugs in Neutron, and how defect management is to be shared
across the Neutron team.
Change-Id: I51bf74cef11dc17b88c18a2007306b913da9f981
This patch adds a policy.rst document which describes how the
neutron.policy module works, how it uses oslo_policy and how
it's wired in API controllers.
The patch also remove an obsolete docstring from neutron/policy.py
Change-Id: I3353a23f4e97824a5a91eaedf57a91ace031a9de
1. Use correct title in gate pipeline page
2. Update lbaasv2 job name in check pipeline page
Change-Id: Ie94ecf0b2fde9a8faebf8637ba77691fde6307d4
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
The link to Dashboard is broken in the generated docuemnt
http://docs.openstack.org/developer/neutron/
This patch fixes it and addresses warnings so that
tox -e docs works.
Also add a reference to Gerrit Dashboard Creator
so that developers can customize it to what they want.
Change-Id: Ic45ab48e68af9e5e8255161fe9eb2354ae124f50
Add links to gerrit URLs that will list reviews for both neutron
subprojects as well as stable branches.
Change-Id: I3b6ab4e57e904dc19ef6e7d116c8b0465e53c21b
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
Move the dashboard directory under the source tree so that
it is available on generated builds. In addition, recast
image pages as RST so that they will be rendered
Change-Id: I316128491e8dae70ac06e260f5bdd8f440d285aa
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
Also added index.html page to allow selection of which graphs
to show. Linking to existing RST comes in a child patch
Change-Id: I6edd7976ae009fc0279238b30ca5223088b6d81d
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
The title and filename of the original graphite dashboards is
incorrect - it should refer to the check pipeline.
Change-Id: Ib17bce084e9a83f1a3db33c47cb7e141e7f5903c
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
This commit updates neutron/db/migration/cli.py such that --verbose can
be passed to the following commands:
- current
- history
- branches
We also update tests in neutron/tests/unit/db/test_migration.py and add
a new test for 'neutron-db-manage branches' as that appears to be
untested.
Lastly, we add a brief description of the newly added capability to
doc/source/devref/alembic_migrations.rst.
Change-Id: I9fc136055b422f12a22c1365f52f17df53219820
Closes-Bug: #1488021
Have you ever wondered why you were making the same mistakes
over and over again and wondered how you can remind yourself not
to repeat them again?
Have you ever felt like you posted review comments on some other
patch, only to see that the same anti-pattern was adopted in
someone else's?
Have you wondered what the heck that test was meant to validate?
Does that sound familiar to you? Yes? Great, we have the answer
for you! 'Effective Neutron' is the solution to all your problems!
From now on, everytime you bang your head against the monitor, do
not despair! You may find the answer to your grief in our collective
guide!
Go check it out!
(Your mileage may vary -- add your disclaimer here)
Change-Id: If1b8c1d04e1204985a4f9febb775c4fdb20305e9
Network devices, like internal router legs, or dhcp ports
should not be affected by bandwidth limiting rules.
This patch disables application of network attached policies
to network/neutron owned ports.
Closes-bug: #1486039
DocImpact
Change-Id: I75d80227f1e6c4b3f5fa7762b8dc3b0c0f1abd46
This patch restores the reservation logic in the API controller,
as the DB issues arising from the pymysql switch has been solved.
Change-Id: I98b40925fdceba13d6a2b5a4d0c5793aeb5cf077
Related-Bug: #1486134
Related-Blueprint: better-quotas
Add the l2pop mechanism driver to the ML2 plugin configuration, and set
l2_population = True, in the OVS agent configuration.
Each test class can enable or disable l2pop in its environment.
Change-Id: If4f2bf07883b763073b5a53f1aa557acb131d176
* EnvironmentDescription class now accepts 'network_type'.
It sets the ML2 segmentation type, passes it to the OVS agents
configuration files, and sets up the host configuration. If
tunnelling type is selected, it sets up a veth pair with an IP
address from the 240.0.0.1+ range. The addressed end of
this pair is configured as the local_ip for tunneling purposes
in each of the OVS agents. If network type is not tunnelled, it
sets up provider bridges instead and interconnects them.
* For now we run the basic L3 HA test with VLANs and tunneling just
so we have something to show for.
* I started using scenarios in fullstack tests to run the same test
with VLANs or tunneling, and because test names are used for log
dirs, and testscenarios changes test names to include characters
that are not shell friendly (Space, parenthesis), I 'sanitized'
some of those characters.
Change-Id: Ic45cc27396452111678cf85ab26b07275846ce44
Implicit registration can be dropped when explicit registration
for load balancer and vpn is implemented. Firewall does not
use service providers and the ServiceTypeManager, so the
precautionary step can be dropped altogether.
Support for configuring providers via the service_providers section
in neutron.conf, is no longer available, hence clear the stale
entry points.
DocImpact
Closes-bug: #1473110
Change-Id: I5e1d254b9a3a24121d9e9d3cb82f877d44079296