156 Commits

Author SHA1 Message Date
YAMAMOTO Takashi
6f696f8082 tools/split.sh: Tweak commit message
No period in the summary line.

Change-Id: Ic79bc85a92b43c60894b9e7e3423beeca5d832a8
Related: blueprint core-vendor-decomposition
2015-01-20 14:19:16 +09:00
Ihar Hrachyshka
35d838ff60 Migrate to oslo.concurrency
Namespaces are not used anymore, so imports are for oslo_concurrency,
not oslo.concurrency.

lockutils direct call is not supported anymore, so using shipped
lockutils-wrapper instead.

Use ExternalLockFixture to set lock_path for unit testing.

Updated cache and cache/_backends module from oslo-incubator to use
oslo.concurrency and not incubator version of lockutils module.

Dropped lockutils incubator module that is now moved to oslo.concurrency. Not
dropping fixture module that includes lockutils fixture since other fixtures
are still used in the tree.

Closes-Bug: #1387092
Change-Id: I2ba2295f8f5d55f272a9d23555940586b25b5a1c
2015-01-15 21:01:06 +01:00
YAMAMOTO Takashi
a640318bda misc-sanity-checks.sh: Some cleanups
Some cleanups for commit 4fdda65a5b9f379af997e1e971865ccfa7a93156.

- Don't assume the path of mktemp command.  It's /usr/bin/mktemp
  for some platforms. eg. NetBSD.  Also, always provide a template
  as it's necessary for some platforms, eg. OS X.  This snippet was
  taken from the example in NetBSD's mktemp(1).
- Move a comment to the appropriate place.
- Improve a regex to ignore more comments.
- As the pattern for find -path is not a regex, no escape is necessary
  for period.

Closes-Bug: #1405584
Change-Id: Ia8358f0f7ebe9bc445ce5aa3c4f340546f37db05
2015-01-14 12:52:06 +09:00
armando-migliaccio
9391526a58 Add developer documentation for plugins/drivers contributions
This is the initial step to provide documentation and
how-to for developers interested in contributing plugins and
drivers according to the core-vendor-decomp proposal.

Partially-implements: blueprint core-vendor-decomposition

Change-Id: Ib8b6cc5fd72eb1b8b4b4b2bdbda132062c81cbc1
2015-01-05 16:36:48 -08:00
armando-migliaccio
4fdda65a5b Clean-up sanity checks done via shell scripts
Move the various checks done via shell into a single file;
this is cleaner and we'll have a lot more space to explain
what is going on.

Related-bug: #1404605

Change-Id: Ibb451c6a25217f37b73983c30891f55b35f143cd
2014-12-23 16:25:06 -08:00
Matthew Treinish
65b8daffd1 Switch to using subunit-trace from tempest-lib
This commit removes the local copy of subunit-trace and instead uses
the version packaged with tempest-lib.

Change-Id: Ia7b57c6fc092514d9fbe4e71f580a4b189dc68b0
2014-12-10 18:35:45 -05:00
YAMAMOTO Takashi
846ae08d87 tox.ini: Prevent casual addition of bash dependency
While bash is not available on every environments, there seems to be
a tendency to introduce more bash dependency very casually.  This check
is intended to be a reminder to give people a chance to consider
alternatives.

Related-Bug: #1398266
Change-Id: I5103e0d7c111880d9a02dd93de56c567066ed14c
2014-12-05 03:25:47 +00:00
YAMAMOTO Takashi
828afa4afa pretty_tox.sh: Portablity improvement
A recent change (commit 0d5a11d9c722870f9c5e31a993219c7e240b4e19)
introduced bash dependency.  It broke my environment, where bash
is not available.  This change aims to restore it.

As far as I undestand, the change in question requires bash for
the "pipefail" feature.  Fortunately there's a more portable
well-known trick for the purpose.

Closes-Bug: #1398266
Change-Id: Id3561d81462923d20ad39584ba4cf8e1a294a8a8
2014-12-02 13:27:46 +09:00
Russell Bryant
0d5a11d9c7 Show progress output while running unit tests
This patch imports some magic to enable showing test output as the
tests run.  Seeing output showing tests as they execute is reassuring
that the test run is continuing to make progress.  This originated in
tempest and was then brought over to Nova in this commit:

  https://review.openstack.org/#/c/121914/

Note the justification in that commit to just copy it instead of move
it to a shared repo.

To get the old behavior where you only get output when something
fails, you can set the TRACE_FAILONLY env var.  That originated in
this commit in Nova:

  https://review.openstack.org/#/c/123801/

Change-Id: I6a079ad5f630383650c0f9dee09e04250d0e2c5a
2014-11-20 21:05:32 +00:00
liu-sheng
b30c47233d Remove the useless vim modelines
Change-Id: I41286e0b8f74c90b7078c3d3fb041b6586d95ab0
Closes-Bug: #1229324
2014-06-21 15:07:31 +08:00
Jenkins
9ebb84c04f Merge "Corrects broken format strings in check_i18n.py" 2014-01-07 14:11:59 +00:00
Wu Wenxiang
ab97446132 Remove unused imports
Remove unused imports in tools/install_venv.py

Change-Id: Ia2fbb4ece5c8bcdee96503f0f853f826ae4f3dfa
Closes-Bug: #1265267
2014-01-01 22:01:27 +08:00
Jay Pipes
f778931252 Corrects broken format strings in check_i18n.py
In tools/check_i18n.py, the error messages printed out
had format strings that included 5 interpolations, but only
four variables were supplied. This patch simply corrects that
mismatch by including the name of the predicate or checker
that failed.

Closes-Bug: #1263813
Change-Id: I5cacee9ea000f56a9ef45f07367e85f20fa333c7
2013-12-24 08:14:48 -05:00
Mark McLoughlin
a764f78327 Remove obsolete redhat-eventlet.patch
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on
why this exists.

As of this fix:

  https://github.com/eventlet/eventlet/pull/34

which was released in eventlet 0.13, we no longer need the patch.

This has now been removed from oslo-incubator, so this is really just
syncing that removal.

Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
2013-10-09 21:47:48 +01:00
Chang Bo Guo
a37b4133b7 Use built-in print() instead of print statement
In python 3 print statement is not supported, so we should use
only print() functions.

This patch also removes print in unit test, left by accident

Fixes bug 1226943

Change-Id: I5ace50cb9e149682344b4c986ef9318f8dc50f72
2013-09-21 07:30:33 -07:00
ZhiQiang Fan
9842dcb34c Fix message i18n error
Partial-Bug: #1217100

Using tools/check_i18n.py to scan source directory, and fix most of
the errors.

- Message internationalization
- First letter must be capital
- Using comma instead of percent in LOG.xxx

Note: all extension's description are not touched in this patch,
can be fixed after discussing.
Note: all nicira/check_nvp_config.py print messages are not fixed.

Change-Id: I79ef06fd42f6780beb5019c592662536c2a51864
2013-09-08 15:58:12 +08:00
ZhiQiang Fan
8b9cc772ea Enclose command args in with_venv.sh
Change-Id: I6d2ca2f8fca951fe2d90265da8728438dd7d7567
Closes-Bug: #1220937
2013-09-05 06:14:18 +08:00
Mark McClain
e094041d15 git remove old non-working packaging files
implements bug: 1198774

Change-Id: Iebd3eb22dd7e3b93131c298e01ac4bcf1fea004e
2013-07-07 22:18:45 -04:00
Jenkins
75f03f3ae0 Merge "Sync install_venv_common from oslo" 2013-07-07 04:11:31 +00:00
Mark McClain
ee3fe4e836 Rename Quantum to Neutron
This change renames everything to Neutron while providing backwards
compatible adjustments for Grizzly configuration files.

implements blueprint: remove-use-of-quantum

Change-Id: Ie7d07ba7c89857e13d4ddc8f0e9b68de020a3d19
2013-07-06 15:02:43 -04:00
Monty Taylor
e4e92cd4b9 Sync install_venv_common from oslo
Change-Id: I4c14c9907d6195ab4f50ab9351ab14e4d93c4ec2
2013-07-05 22:18:02 -04:00
HenryVIII
5586fc3973 Remove unit tests that are no longer run.
A long time ago, quantum/tests/unit became the home for all unit
tests, but these ones in the Cisco plugin directory got left
behind. They have suffered bit-rot and need to be removed.

Also:
- Move the fake Nexus driver to new home.
- Filed new bugs to track the task of improving unit test coverage of
  Cisco plugin code.

Fixes: bug #1174311
Change-Id: I372e24aebbe1804e5b6ce62984bfd76b030a44b1
2013-06-13 20:48:45 -04:00
Gary Kotton
6261364651 Update with latest OSLO code
Change-Id: I54c0f6fa0489f0ef20187adf87f720e48ce1626c
2013-06-12 13:22:31 +00:00
Zhenguo Niu
47846a7a63 Rename requires files to standard names.
Rename tools/pip-requires to requirements.txt and tools/test-requires
to test-requirements.txt. These are standard files, and tools in the
general world are growing intelligence about them.

Fixes: bug #1179008
Change-Id: I6f8a11988982133249d443403f63b4f8724e156e
2013-05-30 22:15:24 +00:00
Bob Kukura
f572a5eb93 Initial Modular L2 plugin implementation.
The Modular L2 Plugin uses drivers to support separately extensible
sets of network types and of mechanisms for accessing networks of
those types. This is an initial implementation that has been tested
with the openvswitch and linuxbridge agents, and should also work with
the hyperv agent. See quantum/plugins/ml2/README for details.

Implements: blueprint modular-l2
Change-Id: Ia8cae480180f0990af7d5e5e56f29eaeac205e0e
2013-05-29 09:21:54 -04:00
Mark McLoughlin
3102bd700a Revert dependency on oslo.config 1.2.0
Fixes bug #1185174

This reverts commit b8b2c4e, 2f13345, 362bd7f, 8da2fb7 and 956b873.

We don't yet have the infrastructure in place to use latest oslo.config
in the gate or even get the correct metadata for it in our packaging.

The gory details are here:

  http://lists.openstack.org/pipermail/openstack-dev/2013-May/009586.html

Change-Id: Idf89ca418df158e6f94279c9c5fa44f23073a9d7
2013-05-29 06:54:55 +01:00
Clark Boylan
b5bf227db4 Perform a sync with oslo-incubator.
This oslo-incubator sync pulls in a new log.py which will make quantum's
default log output format the same as nova, glance and cinder (once
cinder's corresponding oslo sync merges). This common log format
simplifies log indexing as part of CI and makes lives easier for
deployers.

This sync does add a requirement on six as jsonutils depends on it. It
updates install_venv_common.py to be python26 compatible. It also brings
in a bunch of recent python3 compatibility that was added to oslo.

Fixes bug 1183144

Change-Id: Id0f196d7b5680e5950e4a27d66042bf00ccd49e6
2013-05-23 15:58:33 -07:00
Jenkins
b03240b9bf Merge "Require oslo.config 1.2.0a2" 2013-05-23 21:33:42 +00:00
Mark McLoughlin
8da2fb7c56 Require oslo.config 1.2.0a2
Fixes bug #1182662

Commit 362bd7f switched us from using 'QUOTA' as a config file section
name to using 'quota'.

This broke backwards compatibility support for 'QUOTA' because the
version of oslo.config that has that compat support had not yet been
released. The gory details are summarized here:

  http://lists.openstack.org/pipermail/openstack-dev/2013-May/009448.html

Change-Id: I7826087147e0713edaaea85a72283998295e2281
2013-05-23 21:07:42 +01:00
Monty Taylor
a5062315f5 Revert "Fix ./run_tests.sh --pep8"
We are explicitly trying to get rid of scripts like this and flake8 makes
this one non-necessary.
Fix run_tests.sh to run flake8 properly.

This reverts commit 42243d6eb221d52bf6f62f835726cbe026e43447

Change-Id: I435e34b6acde7931a75f456ccc88da6476581643
2013-05-22 13:51:07 +09:00
Jenkins
59d6ad2035 Merge "Docstrings formatted according to pep257" 2013-05-17 17:44:57 +00:00
Monty Taylor
bdba865d77 Move to pbr.
Closes bug 1179007

Change-Id: I3666e373389da6ad9a21a195a42918d4dec50cb5
2013-05-17 08:31:44 -07:00
Sergey Skripnick
933259f675 Docstrings formatted according to pep257
Bug #1020184

Removed H404 from PEP8 ignore list.

Change-Id: Iabc75281c5d92c5b399c24c9b65aca139f204b0a
2013-05-17 18:20:55 +03:00
YAMAMOTO Takashi
3a50a702f9 relax amqplib and kombu version requirements
as nova did while ago.

this particular version of kombu doesn't work if newer msgpack happens
to be installed on the system.

bug 1178512

Change-Id: I2749623036723b5a772b1c4c01dc07437e421925
2013-05-16 09:24:00 +09:00
Akihiro MOTOKI
42243d6eb2 Fix ./run_tests.sh --pep8
Create a common script to call flake8 to share flake8 options and
make tox and run_tests.sh use this script.

Fixes bug: 1179331

Change-Id: I92dc54fa3f4bb22aa39bde226b6d769088f9a2e3
2013-05-14 11:28:37 +09:00
Monty Taylor
061efc3ecc Update flake8 pinned versions.
We've learned this lesson the hard way in the past...

Change-Id: I02c75853234c16f3666185998202431cc7a4f2eb
2013-05-11 16:36:52 -04:00
Mark McLoughlin
9581e5b71b Copy the RHEL6 eventlet workaround from Oslo
Tests in oslo-incubator now need the horrendous hack to workaround an
issue with eventlet on RHEL6. We've moved the patch_tox_venv tool
and redhat-eventlet.patch into oslo-incubator, so add them to
openstack-common.conf.

Change-Id: I1acfec282b64d7582144b155119bedb1741db2f7
2013-05-02 10:31:16 +01:00
Maru Newby
a13295b9a8 Enable automatic validation of many HACKING rules.
* Add hacking to the tox build - a set of flake8 plugins that
   perform automatic validation of many HACKING.rst rules.
 * This patch configures hacking in the tox build and performs
   the mechanical cleanup required to allow the checks to pass.
 * See https://pypi.python.org/pypi/hacking

Change-Id: Ie9b3eb5627a9b6dd181f79225abae422e6cf3777
2013-04-11 19:48:28 +00:00
Maru Newby
a9e763914d Switch to flake8 from pep8.
* flake8 supports more checks than pep8 (e.g. detection of
   unused imports and variables), and has an extension mechanism.
   A plugin to support automatic HACKING validation is planned.
 * See: http://flake8.readthedocs.org/

Change-Id: I8c9314c606802109a4d01908dbc74ecb792ad0ac
2013-04-04 04:57:52 +00:00
Jenkins
c7b3db89c4 Merge "Pin SQLAlchemy to 0.7.x" 2013-03-15 19:27:01 +00:00
Dirk Mueller
2f2aaf2a89 Pin SQLAlchemy to 0.7.x
0.7.10 has been released and is compatible with 0.7.x. Instead
of pinning to 0.7.9, simply pin to 0.7.x to avoid SQLAlchemy 0.8

Unfortuantely '<0.8' matches '0.8.0b2', which is what we don't want.
Therefore pinning it to '<=0.7.99' instead.

This matches a corresponding change in openstack/requirements

Fixes: Bug #1153983

Change-Id: Icf680a933c6092cce52706fd9616a0d208164d1e
2013-03-15 14:20:55 +01:00
Mark McClain
c231e28c02 Sync latest Oslo components for updated copyright.
fixes bug 1154837

This resolves the issue by updating with the latest Oslo changes. These
changes correct the copyright attribution missing from an earlier Oslo
change.

Change-Id: Ic04197bf4bf026b1b48920a5a99397e6183f5ff3
2013-03-13 18:27:31 -04:00
Jenkins
2d45f49ef4 Merge "drop rfc.sh" 2013-03-13 22:01:03 +00:00
Mark McClain
2b72c85a68 drop rfc.sh
fixes bug 1154763

git-review has long replaced rfc.sh, so this can be removed.

Change-Id: Icccbaa1ab393834370790ffb93f431b3435586be
2013-03-13 16:01:55 -04:00
Gary Kotton
e4b44c2856 Replace "OpenStack LLC" with "OpenStack Foundation"
fixes bug 1154702

Change-Id: I78b1d2c9975a1a4f32b0785cce45f1e471783d8c
2013-03-13 15:06:24 -04:00
Mark McLoughlin
7588c58ff8 Switch to final 1.1.0 oslo.config release
Fixes bug #1128256

oslo.config has now been released to PyPI in time for Grizzly RC1 so
we can switch to using it directly.

Change-Id: I655f831718ae5f4e25e941ee206fe195214a9a91
2013-03-12 16:35:47 +00:00
Jenkins
6e9fe5d287 Merge "Update tox.ini to support RHEL 6.x." 2013-03-11 08:22:17 +00:00
Jenkins
7b60092563 Merge "Update to Quantum Client 2.2.0" 2013-03-09 00:47:01 +00:00
Aaron Rosen
57fae4ff69 Update to Quantum Client 2.2.0
This patch updates tools/pip-requires to use the python-quantumclient 2.2
It also limits the version to <3.0.0 to prevent breaking something accidently
when 3.0.0 is released.

Fixes bug 1152695

Change-Id: Iec52ffe91793567c7707843a80a282bd51eb0c76
2013-03-08 10:06:53 -08:00
Dan Prince
33c3cc559c Update tox.ini to support RHEL 6.x.
In order to support running unit tests on RHEL 6.x we need to patch
eventlet with contrib/redhat-eventlet.patch. We already
have support for this in the tools/install_venv_common.py but we
need to make a couple changes to allow tox to consume this:

1) Sync in the latest intall_venv_common.py from oslo. This changes
 patch to use the -N option (ignore already applied patches) and
 makes it safe to call the patching function more than once.

2) Add a new patch_tox_venv.py script in tools.

3) Update tox.ini to call patch_tox_venv.py before it runs tests and
 coverage.

NOTE: This will hopefully go away eventually once this patch lands:

 https://bitbucket.org/eventlet/eventlet/issue/89/add-a-timeout-argument-to-subprocesspopen#comment-3342969

Change-Id: I3e2b07c3f718e4aede5c5f231ff0cdb7721ec885
2013-03-08 08:52:25 -05:00