Library "unittest2" has not released a new version since
Jun 30 2015 [1]. Neutron should remove the references to
this library and point to "unittest" instead.
[1] https://pypi.org/project/unittest2/#history
Change-Id: I7d55adc262280c0c2f13b9b81ecc582e1729afa0
Closes-Bug: #1859190
The mtu is already non-nullable, it no longer needs to
judge the mtu when updating the network.
Related-Bug: #1842261
Change-Id: Ic097bc2ae50198a3bda45e4a8161c22190ef1964
The CRUD methods in the ML2 plugin must pass the data in the request
body to the extension manager, so it can be processed by all the ML2
extensions enabled in the deployment. The create_port_bulk method is
instead passing the dictionary generated after adding the port to the
DB. This will cause that fields in the request body intended for
extensions will not be processed.
Change-Id: I2fe8e2b98c05ba739e9e93b4bd5880eb97bdaef8
When a subnet is created and allocated, the gateway IP is created
based on the subnet CIDR. In case of IPv6 prefix delegation, this
CIDR is a temporary one. In this case the gateway IP cannot be
assigned yet and the value stored in the DB should be "None".
IpamBackendMixin._gateway_ip_str must read properly the IP version
stored in the "subnet" variable, under the key "ip_version"
instead of "version".
Closes-Bug: #1856726
Closes-Bug: #1856675
Change-Id: I9313c880cc458f08dc3a1b0ff13187b764ba7042
Fixed a couple of things for ovs_all_ports=False.
First state that it also cleans up ports created by Nova.
Second since [1] it only cleans up the integration bridge.
[1] https://opendev.org/openstack/neutron/commit/b09b4460
Change-Id: I41dda554e8cb4b4ca36515d64f17ad5bf52f3b49
Closes-Bug: #1853582
Now that "IPWrapper.add_device_to_namespace" is implemented with
Pyroute2, the function should catch the correct exceptions:
- NetlinkError in case of duplicated interface
- OSError in case of corrupted namespace
Change-Id: I12b5710dc3bfdcc4c6b1e96bbfbfab9e59684065
Closes-Bug: #1856853
The update_acls code can potentially iterate over the same ACL
twice. This temporary workaround silently ignores an attempt to
delete the same row twice in the same transaction, since that
should be safe. Ultimately, refactoring the ACL code to use sets
and possibly handle the fact that an ACL could be referenced from
multiple rows should be done.
Change-Id: I895eaf4006583fedc2657a4eb527df1ff992c5bc
Related-bug: #1857016
It may happend that one router's port is going to be
removed and another one (same IP but new subnet) is going to be added
to the router in short time.
That can lead to the problem that IP which is allocated to the new
port is not added to keepalived's vips list because same IP address
is already in this list (this exising IP address belongs to old port).
But few seconds later old port is removed and finally router ends
up with new port configured without IP address.
To avoid such case, this patch switches order of processing new
and deleted ports in _process_internal_ports() method in RouterInfo
class.
So now first old ports will be removed and than new ports will be
configured so there will be no case when IP address is already added
to VIPs list when it is going to be removed in few seconds.
Change-Id: I72dc4a06a806731ec5124fa11c9f69c7dd6cbbb0
Closes-Bug: #1857021
We observe an excessive amount of routers created on
compute node on which some virtual machines got a fixed
ip on floating network.
Rpc servers should filter out those unnecessary routers
during syncing.
Change-Id: I299031a505f05cd0469e2476b867b9dbca59c5bf
Partial-Bug: #1840579
During the test case teardown process, the clean up methods should
check that the "keepalived" process spawned is actually stopped. If
not, the process should be killed (SIGKILL instead of SIGTERM, sent
in "KeepalivedManager.disable()")
TrivalFix
Change-Id: Ifeae4593f56b40de81f234c557349563c1cd6f8c
All the user of neutron-grenade from Ussuri gate
onwards has been switched to grenade-py3 job (except
neutron which is running neutron-grenade-multinode).
We can remove the job definition also now and all
stable gate using this job will find the job definition
from neutron stable branches.
Depends-On: https://review.opendev.org/#/c/694234/
Change-Id: I631f0bfbe7e4ee2df89e2eca2060331796e7a0b2
When creating a network the mtu of the network is
checked against the maximum mtu value.
This should also be done on network update.
Change-Id: Ie7ea79cb753f360bb0bca7df8484710b5d32ccf7
Closes-Bug: #1848152
Solve an issue when checking the node UUID hash and how this dictionary
(node - hash) was built.
Change-Id: I9396d8af17d281eef15777e70a7d8fc0791f20b2
Related-Blueprint: neutron-ovn-merge
As described in [0] a new attribute ``dns_publish_fixed_ip`` is added
to subnets, allowing to specify directly whether DNS records should be
published for this subnet. This overrides the previous behaviour that
makes this decision based on various properties of the network that
the subnet is contained in, see [1].
[0] https://launchpad.net/bugs/1784879
[1] https://docs.openstack.org/neutron/latest/admin/config-dns-int-ext-serv.html
Change-Id: I14605ead2694d9e9422b3d7b519aed2e3c340e2a
Partial-Bug: 1784879
The new hacking release found some pep8 errors, fix them.
Unfortunately, moving to 2.0.0 pulled a thread with other
dependencies causing issues, so for now pin it below
1.2.0 to get the gate functioning again.
Change-Id: Ic8ee670e03dde0669231477a4209b01eb8fba7fd
skb mark is not supported when using ovs hw-offload and using it
breaks the vxlan offload.
This patch clear skb mark only if ovs hw-offload is disabled.
This should be fine as ovs with hw-offload runs on the
compute node (DVR is not supported), so clear the skb mark for
the qrouter is not needed.
Closes-Bug: #1855888
Change-Id: I71f45fcd9b7e7bdacaafc7fa96c775e88333ab48
"testtool" library do not pass arguments to the test methods when
executing the tests, except for those ones decorated with mock
patches.
TrivialFix
Change-Id: I623f9a80541b7fd06edce05722577f7cb4d7a653
Rodolfo Alonso Hernandez