TEMPEST_CONFIG_DIR needs to be set for the api job to execute
successfully. Previously this was being set by the gate but local
execution required manually setting the variable.
Change-Id: Ic1364388e812a5fca26f37049242f7d09ee75fef
Remove entry point pointing to external vendor package.
This console script entry point already exists in the vendor repo.
Change-Id: Ib85acffc155ae6b49477f90d06346269330220b5
Closes-bug: #1431627
Brocade code decomposition of VDX mechanism driver,
includes moving out the driver and unit tests. Left
behind are the DB model for migration and config
Closes bug: #1427793
Change-Id: I3b06a1800cce1ddbb87c6ebd7981e3f249df5060
_remove_unused_security_group_info is refactored into smaller
functions, to make this block easier to understand.
Implements blueprint refactor-iptables-firewall-driver
Change-Id: I4107f1a702d059337e7b2d701a5d0372ee2cfe11
Updates required to the upstream neutron ML2 cisco nexus MD code to
support stackforge repo changes.
Original development done under cisco-openstack repo. File history for
these changes can be found under the staging/junoplus branch.
Change-Id: Idc9da84cefa4131a84b911f77d99a3b1647103a8
Closes-Bug: 1429879
The current default for api_workers is 0. This patch changes it to
use the number of CPUs available, which is the default that will
provide best performance. This is consistent with some other
OpenStack service (Nova and Swift, at least, perhaps others).
Note that devstack is updated in another patch to ensure multiple API
workers is being tested for Neutron the same way it's tested for
several other services:
https://review.openstack.org/140482
Co-Authored-By: Eugene Nikanorov <enikanorov@mirantis.com>
DocImpact
UpgradeImpact
Change-Id: I4d76baf68b014fc80693f53874734783089abda2
Use oslo_db helper that will allow to restart the whole
transaction in case it needs a certain operation to be repeated.
This is a workaround for the REPEATABLE READ problem where
retrying logic will not work because queries inside a transation
will not see updates made by other transactions.
So, run every attempt in a separate transaction.
Change-Id: I68f9ae8019879725df58f5da2c83bb699a548255
Closes-Bug: #1382064
This patch introduces support for rootwrap daemon mode. It adds
a new config option, AGENT.root_helper_daemon with no default. To
enable, set to something like:
root_helper_daemon = sudo neutron-rootwrap-daemon /etc/neutron/rootwrap.conf
The patch currently assumes that the root_helper_daemon value, and specifically
the rootwrap config, will not change once calls to execute() happen. While it
would not be hard to generate a rootwrap daemon client for each new config, I
couldn't think of a legitimate reason to support it and left it out as YAGNI.
This patch does change the behavior of the addl_env argument to create_process
and execute. Previously, an environment dict would be passed to Popen. If
a root helper was used, this environemnt would actually be passed to 'sudo'
which would filter it before passing it to the underlying command. In the case
of daemon mode, this would cause a problem as the enviornment is filtered by
sudo only once, at daemon startup. Any environment variables added at execute
time would then just be passed directly to the underyling command unfiltered.
oslo.rootwrap 1.6.0 fixes this issue by denying the passing of environment
variables to the daemon altogether. Instead, anything using rootwrap and needing
to pass additional environment variables should define an EnvFilter and run the
command with env var=val cmd. utils.execute/create_process have been modified to
run code in this way (which netns.execute already did).
No code in neutron currently uses both run_as_root=True and addl_env, so this
change does not require any change in code or filters.
DocImpact
Implements: blueprint rootwrap-daemon-mode
Change-Id: I567334bb611253c7b9d830d50c5be308a5153baf
This is an initial patch in a series that, by using an event framework,
cleans up the relationship between ML2 and L3, so that they are no longer
tightly coupled. A follow-up will take address the coupling during the
port delete operation.
The newly introduced notification hooks not only benefit the L3 service
plugin, but any other plugin that has an interest in knowing about port
events.
Long term, the notification bits can move in a more 'common' place so that
other plugins can take advantage of them, but as mentioned in a parent patch,
the perestroika is not quite there yet.
Related-blueprint: services-split
Related-blueprint: plugin-interface-perestroika
Change-Id: I6527b1cb53a71a1f68329a7a3b1878094558f8c2
Since VPNaaS has been updated, the get_snat_ns_name() method
is no longer needed.
Change-Id: Id852614efc5ef20f8dc2c8ed5cd0b97b354e995e
Closes-Bug: #1430967
Update the status of the Big Switch Networks code split
in the contribute devref.
Partial-implements: blueprint core-vendor-decomposition
Change-Id: I46d762bb637793b51b46a9d7ae88ceef0efffecf
It's mostly a matter of changing imports to a new location.
Non-obvious changes needed:
* pass overwrite= argument to oslo_context since oslo.log reads context
from its thread local store and not local.store from incubator
* don't store context at local.store now that there is no code that
would consume it
* LOG.deprecated() -> versionutils.report_deprecated_feature()
* dropped LOG.audit check from hacking rule since now the method does
not exist
* WritableLogger is now located in oslo_log.loggers
Dropped log module from the tree. Also dropped local module that is now
of no use (and obsolete, as per oslo team).
Added versionutils back to openstack-common.conf since now we use the
module directly from neutron code and not just as a dependency of some
other oslo-incubator module.
Note: tempest tests are expected to be broken now, so instead of fixing
all the oslo.log related issues for the subtree in this patch, I only
added TODOs with directions for later fix.
Closes-Bug: #1425013
Change-Id: I310e059a815377579de6bb2aa204de168e72571e
Neutron server returns HTTP code 200 when users execute
net-list-on-dhcp-agent with invalid agent_id.
Users expect HTTP code 404 to be returned.
Change-Id: I41652a9bf4a81835abb6646ea870781472757623
Closes-bug: 1425138
We repeated os.makedirs(dir, 0o755) in several places. We should use
common neutron.agent.linux.utils.ensure_dir. Unit tests are also added.
Change-Id: Iaeae5ff7dc6676420c000d6501f69a5997ad4b6c
Closes-bug: 1419042
This is a temporary patch until we get an Oslo messaging
release that supports Targets with multiple namespaces:
https://review.openstack.org/#/c/163673/
Change-Id: I96e01c00991a9d8602ebc89dbad5206b805c67eb
Related-Bug: #1430984
Moving back-end drivers of Arista L3
Service Plugin from neutron tree to
stackforge networking-arista.
Change-Id: I0b10ce12bc10fb74c905ec11e64be8da12f341f4
Closes-bug: 1428909
Related-blueprint: core-vendor-decomposition
Jenkins