557 Commits

Author SHA1 Message Date
Jenkins
0a491131ec Merge "Add remote vs local FAQ for callbacks" 2016-03-13 15:10:54 +00:00
Jenkins
032a01ec14 Merge "Revise deputy instructions to include deprecation warnings" 2016-03-13 08:37:53 +00:00
Kevin Benton
afe1a83400 Block delete_(network|subnet) transactioned calls
These functions assume that they won't be called inside of a
transaction for two reasons. The first is an infinite loop that
will only terminate if it can actually retrieve the latest
information from the database. The second is that ML2's post-commit
operations are expected to occur after data was actually committed
so mechanism drivers that do DB lookups using a different session
may break.

This adds an explicit guard that prevents these two functions from
being called within an active DB session. The rest of the ML2
functions should eventually be converted to this style as well
(see the partial bug).

Related-Bug: #1551958
Partial-Bug: #1540844
Change-Id: I5c00b186585369ef6c8e2b9cb5a43b8bba0e5a7c
2016-03-12 14:20:01 +00:00
Jenkins
f36fe29556 Merge "L3HA: Do not wrap create/delete in transaction" 2016-03-12 07:28:16 +00:00
Jenkins
d94ad2db0a Merge "Add deprecation tag" 2016-03-12 03:35:41 +00:00
Kevin Benton
d1c501cd1d L3HA: Do not wrap create/delete in transaction
This is unsafe when calling ML2 because ML2 assumes that its
functions will not be called inside of a transaction. This is
not only an issue for drivers that try to do DB lookups using
a different session in the post commit operation, but it's a
big issue for the delete methods.

The delete subnet and network methods in ML2 have 'while True'
loops that catch concurrency errors and retry the operation after
looking up info. If these are called inside a transaction, the
lookups will contain stale information and it can lead to the
while True loop never terminating!

Closes-Bug: #1551958
Change-Id: I33dc084ed15e5491fdda19da712a746ca87fbc8c
2016-03-11 23:59:10 +00:00
Armando Migliaccio
4b8f63173a Fix latest doc errors that crept in
Change-Id: I1e3923ba9703eee3f7439fb337450b47d2f5a780
2016-03-11 15:43:23 -08:00
Armando Migliaccio
b6b4136466 Add remote vs local FAQ for callbacks
Change-Id: I4993c9a0101fab23d04852f753ea6e9b74ff0712
2016-03-11 15:40:52 -08:00
Armando Migliaccio
3cc2e4af75 Revise deputy instructions to include deprecation warnings
Change-Id: I612df254c0e097fb17a200d84609bd0360d31dc6
2016-03-11 23:36:52 +00:00
Armando Migliaccio
87cbad42e0 Add deprecation tag
We need to become more diligent and rigorous about the options and/or
system behaviors that we deprecate. We need to watch for field's
feedback and ensure that we provide an alternative route once a
deprecation is followed up by a removal.

Right now, there's no way to have a comprehensive view of what has
been deprecated in a cycle and what removals have to happen. Adding
this tag is the first step to get this sorted.

Change-Id: Id25ed35c8a23c0e6f6fc1b47545c8d1bab3e8dc7
2016-03-11 15:36:33 -08:00
Andreas Jaeger
cd3ff20898 Remove unused pngmath Sphinx extension
There's no RST file that uses ".. math" and thus
the pngmath Sphinx extension is not used and can
get removed.

Change-Id: I3ea4b529025c8ac3c4092f3720124647861e6668
2016-03-11 12:00:07 +01:00
Jenkins
5809759f87 Merge "policies: add an official 'l3-bgp' bug tag" 2016-03-10 22:36:53 +00:00
Ihar Hrachyshka
e2fefe86ef policies: add an official 'l3-bgp' bug tag
Change-Id: I342e97461fdd061d7dcc3eeeae744d0fc87de608
2016-03-10 18:40:46 +00:00
Jenkins
9cdd1310fb Merge "Updates to Bug Deputy section of Bugs DevRef" 2016-03-09 22:47:29 +00:00
Saisrikiran Mudigonda
31aa3516f5 Nit: Occurances of OpenStack
Incorrect capitalization replaced with "OpenStack"

Change-Id: I7b4c9c4d46ebc95aef34c4a001e62b88899aa196
2016-03-04 12:46:21 -08:00
Jenkins
a1d7bd40c0 Merge "Objects DB api: added composite key to handle multiple primary key" 2016-03-04 08:33:50 +00:00
Andreas Scheuring
909e75b02b Updates to Bug Deputy section of Bugs DevRef
- Updating links to Neutron and NeutronClient bugs site
- Adding information how to deal with doc bugs

Change-Id: I696061ac2d1a0c62877f5ab2322355c531d3e6f9
2016-03-03 15:40:48 +01:00
Jenkins
c76ca6122d Merge "devref: added details on the new l2 agent API mechanism" 2016-03-03 12:08:48 +00:00
Jenkins
2e6d5b4ee3 Merge "Fix docs tox target for local runs" 2016-03-03 11:26:36 +00:00
Ihar Hrachyshka
5b3d969af5 devref: added details on the new l2 agent API mechanism
The code landed as I7cb61f30689dff2d7895d444060dedc1532a63ec.

Now this patch documents the new feature for subprojects benefit.

Change-Id: I191e253daffd83b271ab770bd5d49babae553c49
2016-03-03 10:15:13 +00:00
Ihar Hrachyshka
81fb4da11c Fix docs tox target for local runs
The following error occurs when you try to execute the docs target
locally:

Warning, treated as error:
<...>/doc/source/devref/quality_of_service.rst:340: ERROR: Unknown
target name: "http://unix.stackexchange.com/a/100797".

It fails locally only, because in gate job, we don't treat warnings as
errors.

Change-Id: I6703be19d3458d036fdd1378fe6e85784ab54191
2016-03-02 15:52:53 +01:00
Hirofumi Ichihara
ec1457dd75 Add tag mechanism for network resources
Introduce a generic mechanism to allow the user to set tags
on Neutron resources. This patch adds the function for "network"
resource with tags.

APIImpact
DocImpact: allow users to set tags on network resources

Partial-Implements: blueprint add-tags-to-core-resources
Related-Bug: #1489291
Change-Id: I4d9e80d2c46d07fc22de8015eac4bd3dacf4c03a
2016-03-02 05:43:14 +09:00
Jenkins
b380b15d4c Merge "RPC Callback rolling upgrades reporting, and integration" 2016-03-01 18:54:44 +00:00
Jenkins
49fa08969d Merge "Add API extension for reporting IP availability usage statistics" 2016-03-01 18:51:18 +00:00
Artur Korzeniewski
4b227c3771 Objects DB api: added composite key to handle multiple primary key
Moving CRUD DB operation for objects from db/api.py to objects/db/api.py
Renaming object get_by_id(id) to get_object(**kwargs)

Many models in Neutron DB have complex primary keys, concatenated from
a few properties. This patch adds ability to define multiple primary keys
in NeutronDbObject, which are automatically evaluated into DB query
when performing operations.

Partial-Bug: #1541928
Change-Id: I0f63a62418db76415ddd40c30c778ff7541b93dc
2016-03-01 17:05:11 +00:00
Jenkins
be922997e7 Merge "Add support for QoS for LinuxBridge agent" 2016-03-01 16:35:25 +00:00
Sławek Kapłoński
45410d76be Add support for QoS for LinuxBridge agent
There is a new QoS extension driver for the linuxbridge agent
being added. This driver provides support for QoS configuring
on the linuxbridge agent.
This patch introduces two new config options for Linuxbridge agent:
kernel_hz - HZ value of host kernel,
tbf_latency - value of latency in tbf qdisc to calculate size of queue.

Co-Authored-By: vikram.choudhary <vikram.choudhary@huawei.com>

Change-Id: I457ca2569b5d4a916ba09e71040505cd0ad3257b
Closes-Bug: #1500012
Closes-Bug: #1550514
DocImpact Update agent configuration to show settings related to
          QoS and bandwidth limiting
2016-03-01 10:45:02 +00:00
Miguel Angel Ajo
97a272a892 RPC Callback rolling upgrades reporting, and integration
This is the second patch to allow upgrades on RPC versioned
objects callbacks.

This enables resource version notifications from agents to all
neutron servers via fanout for updating the version sets in
memory, and via agent status updates for DB storage, so any
neutron server can retrieve such information at boot.

Closes-Bug: #1535247

Change-Id: I67c1323267aaf7e49f4a359ff50b94e52dba4380
2016-03-01 11:20:48 +01:00
Mike Dorman
2f741ca5f9 Add API extension for reporting IP availability usage statistics
Implements an API extension for reporting availibility of IP
addresses on Neutron networks/subnets based on the blueprint
proposed at https://review.openstack.org/#/c/180803/

This provides an easy way for operators to count the number of
used and total IP addresses on any or all networks and/or
subnets.

Co-Authored-By: David Bingham <dbingham@godaddy.com>
Co-Authored-By: Craig Jellick <craig.jellick@gmail.com>

APIImpact
DocImpact: As a new API, will need all new docs. See devref for details.

Implements: blueprint network-ip-usage-api
Closes-Bug: 1457986
Change-Id: I81406054d46b2c0e0ffcd56e898e329f943ba46f
2016-02-29 05:31:48 +00:00
Assaf Muller
5b9d294ce6 Fix tox -e docs
Change-Id: Iee6cfd370fbd11a311535a73c230d45a699b13e3
2016-02-24 17:58:45 -05:00
Jenkins
9492ac1a52 Merge "Fix generate_records_for_existing in migrations" 2016-02-24 10:47:30 +00:00
Jenkins
03e24280f1 Merge "stadium: revise the introduction to the document" 2016-02-23 04:40:11 +00:00
Jenkins
d8238e5b53 Merge "stadium: Add a guideline about contributor overlap" 2016-02-23 04:16:11 +00:00
Cedric Brandily
f069f69bd6 Fix generate_records_for_existing in migrations
generate_records_for_existing[2] assumes wrongly that:

 session.execute(...).insert_primary_key

returns a value BUT it returns a list of last inserted primary keys.
This trouble affects at least mysql and postgresql backends but not
pymysql (which silently unwraps the list), it explains why grenade tests
didn't catch this trouble.

This change corrects generate_records_for_existing by extracting last
inserted primary key from insert_primary_key list.

[1] neutron.db.migration.alembic_migrations.versions.mitaka.contract\
     .8a6d8bdae39_migrate_neutron_resources_table

Closes-Bug: #1546762
Change-Id: I607e485ab02f1d98874095b32ce53dfdd9cd1d51
2016-02-23 00:18:59 +01:00
Armando Migliaccio
76c446bb5d Document the ability to load service plugins at startup
Change-Id: I1368f3505b68ea20e2585e23d10d90fcd2bac1f6
Closes-bug: #1544383
2016-02-20 02:19:22 +00:00
Jenkins
171351d5fb Merge "Adopt Grafana to plot Neutron Failure Rates" 2016-02-19 07:25:52 +00:00
Armando Migliaccio
8f15d724e4 Adopt Grafana to plot Neutron Failure Rates
Maintaining these dashboards in tree is a bit painful, the queries
can be brittle, the URLs are not human readable, and furthermore the
graphs are not interactive (e.g. zoomable).

We should adopt Grafana, and to see how this looks like, please check
tempest failure rate inline.

Change-Id: I422fc04015fa50e2176e41128adc41d7a22fe02b
2016-02-19 01:48:52 +00:00
Victor Morales
384fe5f9a6 Add missing character
This missing character was causing a warning during the creation of
documentation.  This warning message was considered an error ending the
process to create documentation.

Change-Id: I745389150c23ffabe25eab0ead78dfc850885e9d
Closes-Bug: #1547164
2016-02-18 12:33:40 -06:00
Armando Migliaccio
5aa0ddefa1 stadium: revise the introduction to the document
Reorganize the first sections of the document, and
elaborate on Neutron mission.

Change-Id: Ib33e91e7797312806424b26e64722916e591e086
2016-02-18 17:53:11 +00:00
Russell Bryant
987d0dbc44 stadium: Add a guideline about contributor overlap
This patch introduces a criterion whereby sub-projects are considered
for inclusion (or exclusion) under the Neutron fold based on team
overlap, i.e. on who is driving the development of the sub-project
from inception to production.

For instance, Neutron team members may occasionally need to create
new repos for experimentation, or for the development of new
(potentially overlapping) functional areas to be incubated as an
integral part of the Neutron end-to-end system.

This patch is the last in a series that introduces criteria for
classification of projects for inclusion/exclusion to/out of the
Neutron 'stadium'. These criteria will always be applied jointly
when assessing a project for inclusion/exclusion at discretion of
the Neutron team.

Patches that complete the inclusion/exclusion process will follow
to discuss the rationale for inclusion/exclusion of the remainder
of the sub-projects.

Change-Id: Ie8e65a94ff9ec238e7c28a8b85d92835675d0c4c
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Armando Migliaccio <armamig@gmail.com>
2016-02-18 09:48:25 -08:00
Jenkins
b1aec35adf Merge "Add bug tag for auto allocated topology" 2016-02-18 02:57:29 +00:00
Jenkins
5dd7c5fcd2 Merge "Open vSwitch conntrack based firewall driver" 2016-02-17 22:15:07 +00:00
Assaf Muller
14c1f8de9d Add bug tag for auto allocated topology
Change-Id: Idd8dcb70c94a30878538278c3036bea741228704
2016-02-17 14:14:57 -05:00
Jenkins
b8acd4cb9d Merge "Fix typo 'indepedent' in alembic_migration.rst" 2016-02-17 10:00:42 +00:00
Jenkins
7b6671c136 Merge "Add to the neutron bug deputy directions" 2016-02-17 00:22:29 +00:00
Jakub Libosvar
ef29f7eb9a Open vSwitch conntrack based firewall driver
This firewall requires OVS 2.5+ version supporting conntrack and kernel
conntrack datapath support (kernel>=4.3). For more information, see
https://github.com/openvswitch/ovs/blob/master/FAQ.md

As part of this new entry points for current reference firewalls were
added.

Configuration:
in openvswitch_agent.ini:
    - in securitygroup section set firewall_driver to openvswitch

DocImpact
Closes-bug: #1461000

Co-Authored-By: Miguel Angel Ajo Pelayo <mangelajo@redhat.com>
Co-Authored-By: Amir Sadoughi <amir.sadoughi@rackspace.com>

Change-Id: I13e5cda8b5f3a13a60b14d80e54f198f32d7a529
2016-02-16 16:47:21 +00:00
Nate Johnston
4b3a77a86c Add to the neutron bug deputy directions
Based on my experience as the Neutron Bug Deputy, I would like to add
some extra information to the Bug Deputy directions, so that later Bug
Deputies will be well prepared.

Change-Id: I3ddae7b6af082acb66218253e27da1f709cbd7b7
2016-02-15 09:57:29 -05:00
Yalei Wang
c24e9da2f8 Add precommit_XXX event for security group and rules
Current BEFORE_CREATE/DELETE/UPDATE event is outside of the DB
transaction. Unlike the precommit primitive in ML2 mech drivers, they
don't work in the same DB transaction of resource, so if we want to
operate the DB in mech driver related to security group, there would be
more unsync issues if we use BEFORE_XXX event directly. Moving the
BEFORE_XXX event inside may also break some current codes, as maybe RPC
call included.

This patch adds new PRECOMMIT_CREATE/DELETE/UPDATE event type for
callback function, and use it in the securitygroup/rules DB transaction.
PRECOMMIT_XXX is in the DB transaction and only purpose is to do DB
operations in its callback. A CallbackFailure will be triggered when
exception comes from the callback of the new event.

Change-Id: Icd2849bd84dab6733a572e8c85f242afcefc6c78
Closes-Bug: #1522172
2016-02-14 22:36:27 +08:00
James Arendt
887316ae43 Fix typo 'indepedent' in alembic_migration.rst
Change to 'independent'.

Closes-Bug: #1546237
Change-Id: I31acc5ae6d88ea56c9aded94b46573126f557fce
2016-02-12 01:34:49 -08:00
Jenkins
1dce58a960 Merge "Update translation setup for neutron subprojects" 2016-02-11 20:17:29 +00:00