bug 942713. This bug confuses the validate_networks() method of
QuantumManager in Nova, causing it to believe that it is valid for a
tenant to plug into a particular network when in fact that network is not
owned by the tenant, nor the "provider".
The patch also adds unit tests to confirm correct plugin behavior.
This patch fixes the issue for the Sample Plugin, the OVS plugin,
the Linux Bridge plugin, and the Ryu plugin, all of which has the
same DB model. Validated the fix with the unit tests.
I couldn't run the unit tests for the NVP plugin standalone, but by
inspection, the code seems to handle this case. I wasn't able to run
the Cisco plugin unit tests, and that code uses its own DB model, so I
am uncertain whether this issue exists in that plugin.
Change-Id: I8c4a5f3eb151b91a1076821dc1916842510dfb90
blueprint ovs-driver-extention
This patch implements the blueprint ovs-driver-extention
https://blueprints.launchpad.net/quantum/+spec/ovs-driver-extension
This patch factors out ovs common logic from ovs plugin into ovscommon
and adds Ryu NOS plugin.
This patch enhances ovs plugin for generic OVS controller support and
This patch is to add ofp controller support to OVS.
Store ofp controller address in ovs quantum data base.
- nova firewall_driver
- nova linuxnet_interface_driver
There may be ports unmanaged by nova/quantum. Those ports are used
to connect vm to outside of physical machine. They needs special care.
---
Changes 12 -> 13:
- rebased to 543e150d6d
changed files are only MANIFEST.in, setup.py, tools/pip-requres
Changes 11 -> 12:
- ryu agent
eliminated from quantum.common import exceptions as exc
- ryu.db.api
eliminated ofp_has_servers
- ryu.nova
eliminated from quantum.plugins.ryu.nova import ovs_utils
and eliminate ovs_utils
Chnages 10 -> 11:
- rebased to a945d1a304
- more Maru's review
- setup.py: fix setup() argument
This isn't directly related to ryu plugin though
- improve fake ini file when unit test
remove fake ini file after unit tests.
use StringIO when no file is required.
- LOG: don't use %
Chnages 8 -> 9 -> 10:
- minor fixes: forgot to commit some hunks
Chnages 7 -> 8:
- rebased to d6bf2b7616
- catch up d6bf2b7616 change
introduced bin/quantum_ryu_agent
- addressed Maru's review
- avoid custom patching, use mock for test
and added mox and mock to pip-requires
- more pep8
- avoid \ for line continuation
- avoid single char variables
- db.api: first() -> one()
- utilize implicit conversion
var is not None -> var
- and more...
Changes 6 -> 7:
- update comment in ryu/run_tests.py
- make unit tests pass without ryu installed
i.e.
PLUGIN_DIR=quantum/plugins/ryu/ ./run_tests.sh
works now
Chages 5 -> 6:
- remove comment
Change 4 -> 5:
- eliminate relative imports
- copyright
- doc string
- naming (s/CONF_FILE/conf_file/g)
- add " check to ryu/nova/ovs_utils
- ryu/nova/linux_net: comment
- ryu agent: eliminated unused methods
- updated ryu/README: add http://www.osrg.net/ryu/using_with_openstack.html
- added unit tests
Changes 3 -> 4:
- reflected Dan's review
- on-OVS in ryu.ini
- update @author
- some naming
Changes 2 -> 3:
- rebased to 04d144ae0b
- abandoned to share code and duplicated codes from openvswitch plugin
for ovs plugin stability.
- dropped setup_ryu.sh and added README
- update nova driver to catch up upstream change (gflags -> cfg)
Changes 1 -> 2:
- unbreak openvswtich unit test
- MANIFEST.in
Changes 3 -> new 1:
- rebased to 1eb3c693b5
- factor out common loginc from openvswitch plugin into ovscommon
- Introduced a new independent ryu plugin
- try new review due to the previous effort was marked abandoned.
> https://review.openstack.org/#change,3055
> Change-Id: I17801a7a74d4087838a8a26c1b1f97f28c2dcef3
Changes:
- rebased to 9c5c2caef1
- some clean ups
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Change-Id: Ia9fe87525cebccc87b7c18a533f48607272cd97f
Fixes ovs-plugin to return appropriate error code when create port API is passed a port state value other than ACTIVE or DOWN. Fixes bug 919265.
Also added unit-test to test the behavior and verified it using ovs-plugin with devstack.
Change-Id: Ibd4e7bfdf4483c7ad1ef4ca70a336cb164493ae1
Enhance existing Quantum OVS Plugin with a tunneling agent that
enables Hypervisors to be connected via GRE tunnels. The new agent
can be enabled/disabled via configuration file and provides backwards
compatibility with existing non-tunneling OVS Agent.
Change-Id: Id3b79430726b162fcb84f99df152d88a5766328f
Missing text files such as LICENSE and various READMEs are now
included in the tarball source distribution. The Makefile and shell
script for installing the openvswitch agent on xen are also now
included. The openvswitch and linuxbridge agents are included, and
executable wrapper scripts for the agents are provided. The cisco and
linuxbridge nova drivers are now setup to be run from the quantum
namespace rather than copied to nova. Finally, the setup_*.py scripts
have been removed from the project. Fixes bug 925074.
Test by running "python setup.py sdist" and examining the generated
tarball.
Change-Id: I33d336a5eb13678e6d527b575958393b337b6f3d
Signed-off-by: Bob Kukura <rkukura@redhat.com>
Squashed commit of the following:
commit 6c4995736a56349923d34353031eb301780fc6d2
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Sat Jan 21 22:31:09 2012 -0800
Some more explanation in the README.
Changing defaults in the conf file.
commit 924b118468d7bd21737e9e2cf468ff83d0a20764
Author: Shweta <shpadubi@cisco.com>
Date: Sat Jan 21 20:58:39 2012 -0500
Adding Unit Tests for LinuxBridge Agent
commit 12115650257483172c5e2bc889634dbdf3596d27
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Sat Jan 21 05:21:24 2012 -0800
Adding sqlite requirement
Changing default mysql port number
Fixing log statement
commit 0ad1400e5dfc445b94e9024d92321eb3cd0588a5
Merge: 1b7ba8f 9c5c2ca
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Sat Jan 21 05:12:44 2012 -0800
Merge remote branch 'upstream/master' into snaiksat/linux-bridge-plugin
commit 1b7ba8f7e7b6657734b669194ddfdcfcbfc833be
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Sat Jan 21 04:04:50 2012 -0800
Fixes to get the tests to run correctly.
Also incorporated changes to be able to run both sqlite and mysql DBs.
commit 4cead17576c293319dfdfd363dd18e81ba196b3b
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Fri Jan 20 15:32:35 2012 -0800
Fixed inccorect calls to the DB
commit c4f325729fbd06ee3f5d3520da4d23b2cd8c353b
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Fri Jan 20 12:18:18 2012 -0800
Removing the specialized db modules (which used InnoDB engine) and
instead using the Quantum DB now.
Incorporated changes to setup so that the Linux Bridge plugin can be
installed.
Other changes to README and tests.
commit b9498939d723e353808cface87f4453e33e94b41
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Mon Jan 16 20:00:14 2012 -0800
Adding unit tests
commit a0ab990fdcbf67a950d08c6b5b6d20ceb850619a
Merge: 60e38cc f268b5e
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Mon Jan 16 18:02:55 2012 -0800
Merge remote branch 'upstream/master' into snaiksat/linux-bridge-plugin
commit 60e38cc44886b5c8c9e47d89d8912d1dee23fbd1
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Mon Jan 16 13:44:37 2012 -0800
This contains a fix for the earlier reported issue with the DHCP
failing.
The gateway IP address is now applied both to the bridge, and the
gateway interface.
commit ffea86a3465b8a5ed93b13f818e0afaefa6787ee
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Sun Jan 15 20:00:38 2012 -0800
Fixing an issue in the agent, sometimes the bridges for deleted networks
were not getting cleaned up
commit 87f76fc34f1c70cd82576b8698d704853c892422
Merge: c8b097a 60d171e
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Sun Jan 15 19:40:33 2012 -0800
Merge remote branch 'upstream/master' into snaiksat/linux-bridge-plugin
commit c8b097abc2060b2eae01d84f9fed2c89851d93fd
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Sun Jan 15 19:37:08 2012 -0800
Simplified the logic for creating the bridge on the nova network host.
commit 499dbacd4c5352c5320f3b6e5e8cd7f3629dbcc8
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Fri Jan 13 16:07:53 2012 -0800
Fix for the DHCP issue, now applying Gateway IP to the bridge
Also MAC address from original tap device are applied to bridge
and vlan subinterface
commit 6b4a2aea59702e2c12eeacc86101df9f6770d5ec
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Sat Jan 7 14:29:00 2012 -0800
Optimizations for processing in the loop
commit 01aa47d3572439b193077432c63bf2b85c629edb
Merge: 184f5dd 05df087
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Sun Jan 1 19:04:17 2012 -0800
Changes to incorporate Operational Status
Merge remote branch 'origin' into snaiksat/linux-bridge-plugin
Conflicts:
quantum/db/api.py
commit 05df0870191fac0353fe12a33efff68ef7ed0784
Merge: 31d586b 5b23b5e
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Fri Dec 30 12:30:05 2011 -0800
Merge remote branch 'upstream/master'
commit 184f5dd8b73bc51025509792c15203ee73cd015e
Author: Sumit Naiksatam <snaiksat@cisco.com>
Date: Mon Dec 12 02:09:12 2011 -0800
Initial checkin for Linux Bridge L2 plugin.
Change-Id: I5b27538be6a768a6f7eb77409197f7d8b4bbc628
Restructured API error codes for Quantum API v1.1
This changeset provides the following changes:
- Only standard HTTP errors for Quantum API v1.1
- Customized fault response body formatting according to API version
- Changes to unit tests to deal with version specific status codes
NOTE: Client side changes are not in this branch.
They should be implemented within bp/quantum-client-1.1.
NOTE-2: Fixing references to QuantumHTTPErrors in extensions framework
Change-Id: I56f50b5c59d73fd6f02905106f0c2a3c8341a741
This allows us to return NotImplemented() from an extension if the plugin
doesn't support a given function.
Change-Id: I73c6dec959aea7b2bde1378222b62e6fc82a5d43
This makes setting and calculating the versioning of quantum more
like other OpenStack projects, simplifying the work of the CI
and Release Management teams.
Addresses bug 916018 which prevents the quantum-tarball job from
running correctly.
Change-Id: I5b006ccc3d31c5d213c703853dfa38f04d983918
Fixes bug #911663
The None, True, and False values are singletons.
All variable *comparisons* to singletons should use 'is' or 'is not'.
All variable *evaluations* to boolean should use 'if' or 'if not'.
All Object type comparisons should use isinstance()
instead of comparing types directly.
Change-Id: Id5c797d3339d0d7015bac386088133540f0c0c9e
This simplifies a number of Jenkins jobs which currently, other
than directory names, could be the same for all OpenStack
projects. By renaming the virtualenv directory, the redundant
Jenkins virtualenv build and copy jobs can be eliminated.
Change-Id: I93c7f6577b4c3a76b021f002bda59fcb8fac3f95
Fixes bug 906636.
The cisco plugin included ncclient, but does not use it when testing.
The openvswitch plugin included SQLAlchemy which is already required
by quantum itself.
I've also changed the install_venv.py script to only look at
tools/pip-requires, so that it behaves more like the rest of the
OpenStack projects. In Jenkins that's the only file we look at
to see if we need to rebuild the virtualenv, so it would be best
if the project only hade one pip-requires.
Also added .gitignore to ignore files created during testing.
Change-Id: Ic460452ec89aa8377c975ca63b57563119860e6b
This utility offers a simplify way to insert and remove network services
in the path of the traffic to the server VMs, by splitting the network
into two, and having the service bridge between the two networks,
in the process applying the service. This model is called In-Path
(Bump in the Wire)
Change-Id: If7e9ad2dcb8124e7d82ac837c5b62c0d09b00bcd
Implements operational status API for OVS plugin. Uses existing
database model for operational status. For network, status is always
up. For a port, status is down unless there is an agent that
indicates that the port is active on its compute host.
Updated: use Salvatore's config hook to set default op-status for OVS
in OVS run_tests.py
Updated: fixed issue in _make_port_dict() found by Brad.
Change-Id: I0560cbde9dc69bd4211d9aaf12cef204df2f7664
We can't use merge if we're removing a field from the port object so use add
instead. Also, pass the session to port_get so that we don't run into the
"this port is already bound to session x" error.
Change-Id: I54a8484c8f6429ad18fb0c5e088720d21fc16299
Addressing Dan's comments.
This changeset provides:
- improved framework for API versioning, with separated controllers for each API version
- Taken from nova:'Resource' class in WSGI framework. This class is a container for serializers, deserializers and controller
- Better deserialization thanks to resource class. _parse_request_params has been removed
- Improved management of HTTP client errors
NOTE: this changeset does not update the framework used by API extensions.
Change-Id: I88a669ce418225c415e0da22e951762d0708e0a5
Change-Id: Ib7ff79c166e34c4f99a8df55feb0191f37555597
Removed the trailing whitespaces in the README
Change-Id: Ic2299bf35d9e0d8512ae4f57976884d12ba92159
Jenkins