82d468ba7f
At some point, we've switched to an alternative process launcher that uses named pipes to communicate with the child processes. This implementation has some issues, truncating the process output in some situations. This change switches back to subprocess.Popen, which is a much easier and convenient way to perform exec calls. We're also ensuring that the os module is not patched (which would cause subprocess.Popen to fail on Windows due to an eventlet limitation, the reason why the above mentioned implementation was first introduced). We're also ensuring that such calls do not block other greenthreads by leveraging eventlet.tpool. Side note: I had to store subprocess.Popen in a variable in order to avoid having OpenStack bandit complaining, even though we're explicitly passing "shell=False": http://paste.openstack.org/raw/658319/ Closes-Bug: #1709931 Change-Id: Ib58e12030e69ea10862452c2f141a7a5f2527621
39 lines
1.4 KiB
Python
39 lines
1.4 KiB
Python
# Copyright (c) 2015 Cloudbase Solutions.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import os
|
|
|
|
import eventlet
|
|
from oslo_utils import importutils
|
|
|
|
|
|
def monkey_patch():
|
|
# NOTE(slaweq): to workaround issue with import cycles in
|
|
# eventlet < 0.22.0;
|
|
# This issue is fixed in eventlet with patch
|
|
# https://github.com/eventlet/eventlet/commit/b756447bab51046dfc6f1e0e299cc997ab343701
|
|
# For details please check https://bugs.launchpad.net/neutron/+bug/1745013
|
|
eventlet.hubs.get_hub()
|
|
if os.name != 'nt':
|
|
eventlet.monkey_patch()
|
|
|
|
p_c_e = importutils.import_module('pyroute2.config.asyncio')
|
|
p_c_e.asyncio_config()
|
|
else:
|
|
# eventlet monkey patching the os module causes subprocess.Popen to
|
|
# fail on Windows when using pipes due to missing non-blocking IO
|
|
# support.
|
|
eventlet.monkey_patch(os=False)
|