380 lines
16 KiB
Python
380 lines
16 KiB
Python
# Copyright 2014 OpenStack Foundation
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import contextlib
|
|
import datetime
|
|
|
|
import mock
|
|
from oslo_config import cfg
|
|
from oslo_utils import importutils
|
|
from oslo_utils import timeutils
|
|
import testscenarios
|
|
|
|
from neutron.common import constants
|
|
from neutron.common import topics
|
|
from neutron import context
|
|
from neutron.db import agents_db
|
|
from neutron.db import agentschedulers_db as sched_db
|
|
from neutron.db import models_v2
|
|
from neutron.extensions import dhcpagentscheduler
|
|
from neutron.scheduler import dhcp_agent_scheduler
|
|
from neutron.tests.unit import testlib_api
|
|
from neutron.tests.unit import testlib_plugin
|
|
|
|
# Required to generate tests from scenarios. Not compatible with nose.
|
|
load_tests = testscenarios.load_tests_apply_scenarios
|
|
|
|
|
|
class TestDhcpSchedulerBaseTestCase(testlib_api.SqlTestCase):
|
|
|
|
def setUp(self):
|
|
super(TestDhcpSchedulerBaseTestCase, self).setUp()
|
|
self.ctx = context.get_admin_context()
|
|
self.network = {'id': 'foo_network_id'}
|
|
self.network_id = 'foo_network_id'
|
|
self._save_networks([self.network_id])
|
|
|
|
def _get_agents(self, hosts):
|
|
return [
|
|
agents_db.Agent(
|
|
binary='neutron-dhcp-agent',
|
|
host=host,
|
|
topic=topics.DHCP_AGENT,
|
|
configurations="",
|
|
agent_type=constants.AGENT_TYPE_DHCP,
|
|
created_at=timeutils.utcnow(),
|
|
started_at=timeutils.utcnow(),
|
|
heartbeat_timestamp=timeutils.utcnow())
|
|
for host in hosts
|
|
]
|
|
|
|
def _save_agents(self, agents):
|
|
for agent in agents:
|
|
with self.ctx.session.begin(subtransactions=True):
|
|
self.ctx.session.add(agent)
|
|
|
|
def _create_and_set_agents_down(self, hosts, down_agent_count=0):
|
|
dhcp_agents = self._get_agents(hosts)
|
|
# bring down the specified agents
|
|
for agent in dhcp_agents[:down_agent_count]:
|
|
old_time = agent['heartbeat_timestamp']
|
|
hour_old = old_time - datetime.timedelta(hours=1)
|
|
agent['heartbeat_timestamp'] = hour_old
|
|
agent['started_at'] = hour_old
|
|
self._save_agents(dhcp_agents)
|
|
return dhcp_agents
|
|
|
|
def _save_networks(self, networks):
|
|
for network_id in networks:
|
|
with self.ctx.session.begin(subtransactions=True):
|
|
self.ctx.session.add(models_v2.Network(id=network_id))
|
|
|
|
def _test_schedule_bind_network(self, agents, network_id):
|
|
scheduler = dhcp_agent_scheduler.ChanceScheduler()
|
|
scheduler.resource_filter.bind(self.ctx, agents, network_id)
|
|
results = self.ctx.session.query(
|
|
sched_db.NetworkDhcpAgentBinding).filter_by(
|
|
network_id=network_id).all()
|
|
self.assertEqual(len(agents), len(results))
|
|
for result in results:
|
|
self.assertEqual(network_id, result.network_id)
|
|
|
|
|
|
class TestDhcpScheduler(TestDhcpSchedulerBaseTestCase):
|
|
|
|
def test_schedule_bind_network_single_agent(self):
|
|
agents = self._create_and_set_agents_down(['host-a'])
|
|
self._test_schedule_bind_network(agents, self.network_id)
|
|
|
|
def test_schedule_bind_network_multi_agents(self):
|
|
agents = self._create_and_set_agents_down(['host-a', 'host-b'])
|
|
self._test_schedule_bind_network(agents, self.network_id)
|
|
|
|
def test_schedule_bind_network_multi_agent_fail_one(self):
|
|
agents = self._create_and_set_agents_down(['host-a'])
|
|
self._test_schedule_bind_network(agents, self.network_id)
|
|
with mock.patch.object(dhcp_agent_scheduler.LOG, 'info') as fake_log:
|
|
self._test_schedule_bind_network(agents, self.network_id)
|
|
self.assertEqual(1, fake_log.call_count)
|
|
|
|
|
|
class TestAutoScheduleNetworks(TestDhcpSchedulerBaseTestCase):
|
|
"""Unit test scenarios for ChanceScheduler.auto_schedule_networks.
|
|
|
|
network_present
|
|
Network is present or not
|
|
|
|
enable_dhcp
|
|
Dhcp is enabled or disabled in the subnet of the network
|
|
|
|
scheduled_already
|
|
Network is already scheduled to the agent or not
|
|
|
|
agent_down
|
|
Dhcp agent is down or alive
|
|
|
|
valid_host
|
|
If true, then an valid host is passed to schedule the network,
|
|
else an invalid host is passed.
|
|
"""
|
|
scenarios = [
|
|
('Network present',
|
|
dict(network_present=True,
|
|
enable_dhcp=True,
|
|
scheduled_already=False,
|
|
agent_down=False,
|
|
valid_host=True)),
|
|
|
|
('No network',
|
|
dict(network_present=False,
|
|
enable_dhcp=False,
|
|
scheduled_already=False,
|
|
agent_down=False,
|
|
valid_host=True)),
|
|
|
|
('Network already scheduled',
|
|
dict(network_present=True,
|
|
enable_dhcp=True,
|
|
scheduled_already=True,
|
|
agent_down=False,
|
|
valid_host=True)),
|
|
|
|
('Agent down',
|
|
dict(network_present=True,
|
|
enable_dhcp=True,
|
|
scheduled_already=False,
|
|
agent_down=False,
|
|
valid_host=True)),
|
|
|
|
('dhcp disabled',
|
|
dict(network_present=True,
|
|
enable_dhcp=False,
|
|
scheduled_already=False,
|
|
agent_down=False,
|
|
valid_host=False)),
|
|
|
|
('Invalid host',
|
|
dict(network_present=True,
|
|
enable_dhcp=True,
|
|
scheduled_already=False,
|
|
agent_down=False,
|
|
valid_host=False)),
|
|
]
|
|
|
|
def test_auto_schedule_network(self):
|
|
plugin = mock.MagicMock()
|
|
plugin.get_subnets.return_value = (
|
|
[{"network_id": self.network_id, "enable_dhcp": self.enable_dhcp}]
|
|
if self.network_present else [])
|
|
scheduler = dhcp_agent_scheduler.ChanceScheduler()
|
|
if self.network_present:
|
|
down_agent_count = 1 if self.agent_down else 0
|
|
agents = self._create_and_set_agents_down(
|
|
['host-a'], down_agent_count=down_agent_count)
|
|
if self.scheduled_already:
|
|
self._test_schedule_bind_network(agents, self.network_id)
|
|
|
|
expected_result = (self.network_present and self.enable_dhcp)
|
|
expected_hosted_agents = (1 if expected_result and
|
|
self.valid_host else 0)
|
|
host = "host-a" if self.valid_host else "host-b"
|
|
observed_ret_value = scheduler.auto_schedule_networks(
|
|
plugin, self.ctx, host)
|
|
self.assertEqual(expected_result, observed_ret_value)
|
|
hosted_agents = self.ctx.session.query(
|
|
sched_db.NetworkDhcpAgentBinding).all()
|
|
self.assertEqual(expected_hosted_agents, len(hosted_agents))
|
|
|
|
|
|
class TestNetworksFailover(TestDhcpSchedulerBaseTestCase,
|
|
sched_db.DhcpAgentSchedulerDbMixin):
|
|
def test_reschedule_network_from_down_agent(self):
|
|
agents = self._create_and_set_agents_down(['host-a', 'host-b'], 1)
|
|
self._test_schedule_bind_network([agents[0]], self.network_id)
|
|
self._save_networks(["foo-network-2"])
|
|
self._test_schedule_bind_network([agents[1]], "foo-network-2")
|
|
with contextlib.nested(
|
|
mock.patch.object(self, 'remove_network_from_dhcp_agent'),
|
|
mock.patch.object(self, 'schedule_network',
|
|
return_value=[agents[1]]),
|
|
mock.patch.object(self, 'get_network', create=True,
|
|
return_value={'id': self.network_id})
|
|
) as (rn, sch, getn):
|
|
notifier = mock.MagicMock()
|
|
self.agent_notifiers[constants.AGENT_TYPE_DHCP] = notifier
|
|
self.remove_networks_from_down_agents()
|
|
rn.assert_called_with(mock.ANY, agents[0].id, self.network_id,
|
|
notify=False)
|
|
sch.assert_called_with(mock.ANY, {'id': self.network_id})
|
|
notifier.network_added_to_agent.assert_called_with(
|
|
mock.ANY, self.network_id, agents[1].host)
|
|
|
|
def _test_failed_rescheduling(self, rn_side_effect=None):
|
|
agents = self._create_and_set_agents_down(['host-a'], 1)
|
|
self._test_schedule_bind_network([agents[0]], self.network_id)
|
|
with contextlib.nested(
|
|
mock.patch.object(
|
|
self, 'remove_network_from_dhcp_agent',
|
|
side_effect=rn_side_effect),
|
|
mock.patch.object(self, 'schedule_network',
|
|
return_value=None),
|
|
mock.patch.object(self, 'get_network', create=True,
|
|
return_value={'id': self.network_id})
|
|
) as (rn, sch, getn):
|
|
notifier = mock.MagicMock()
|
|
self.agent_notifiers[constants.AGENT_TYPE_DHCP] = notifier
|
|
self.remove_networks_from_down_agents()
|
|
rn.assert_called_with(mock.ANY, agents[0].id, self.network_id,
|
|
notify=False)
|
|
sch.assert_called_with(mock.ANY, {'id': self.network_id})
|
|
self.assertFalse(notifier.network_added_to_agent.called)
|
|
|
|
def test_reschedule_network_from_down_agent_failed(self):
|
|
self._test_failed_rescheduling()
|
|
|
|
def test_reschedule_network_from_down_agent_concurrent_removal(self):
|
|
self._test_failed_rescheduling(
|
|
rn_side_effect=dhcpagentscheduler.NetworkNotHostedByDhcpAgent(
|
|
network_id='foo', agent_id='bar'))
|
|
|
|
def test_filter_bindings(self):
|
|
bindings = [
|
|
sched_db.NetworkDhcpAgentBinding(network_id='foo1',
|
|
dhcp_agent={'id': 'id1'}),
|
|
sched_db.NetworkDhcpAgentBinding(network_id='foo2',
|
|
dhcp_agent={'id': 'id1'}),
|
|
sched_db.NetworkDhcpAgentBinding(network_id='foo3',
|
|
dhcp_agent={'id': 'id2'}),
|
|
sched_db.NetworkDhcpAgentBinding(network_id='foo4',
|
|
dhcp_agent={'id': 'id2'})]
|
|
with mock.patch.object(self, 'agent_starting_up',
|
|
side_effect=[True, False]):
|
|
res = [b for b in self._filter_bindings(None, bindings)]
|
|
# once per each agent id1 and id2
|
|
self.assertEqual(2, len(res))
|
|
res_ids = [b.network_id for b in res]
|
|
self.assertIn('foo3', res_ids)
|
|
self.assertIn('foo4', res_ids)
|
|
|
|
|
|
class DHCPAgentWeightSchedulerTestCase(TestDhcpSchedulerBaseTestCase,
|
|
testlib_plugin.PluginSetupHelper):
|
|
"""Unit test scenarios for WeightScheduler.schedule."""
|
|
|
|
hostc = {
|
|
'binary': 'neutron-dhcp-agent',
|
|
'host': 'host-c',
|
|
'topic': 'DHCP_AGENT',
|
|
'configurations': {'dhcp_driver': 'dhcp_driver',
|
|
'networks': 0,
|
|
'use_namespaces': True,
|
|
},
|
|
'agent_type': constants.AGENT_TYPE_DHCP}
|
|
|
|
hostd = {
|
|
'binary': 'neutron-dhcp-agent',
|
|
'host': 'host-d',
|
|
'topic': 'DHCP_AGENT',
|
|
'configurations': {'dhcp_driver': 'dhcp_driver',
|
|
'networks': 1,
|
|
'use_namespaces': True,
|
|
},
|
|
'agent_type': constants.AGENT_TYPE_DHCP}
|
|
|
|
def setUp(self):
|
|
super(DHCPAgentWeightSchedulerTestCase, self).setUp()
|
|
DB_PLUGIN_KLASS = 'neutron.plugins.ml2.plugin.Ml2Plugin'
|
|
self.setup_coreplugin(DB_PLUGIN_KLASS)
|
|
cfg.CONF.set_override("network_scheduler_driver",
|
|
'neutron.scheduler.dhcp_agent_scheduler.WeightScheduler')
|
|
self.dhcp_periodic_p = mock.patch(
|
|
'neutron.db.agentschedulers_db.DhcpAgentSchedulerDbMixin.'
|
|
'start_periodic_dhcp_agent_status_check')
|
|
self.patched_dhcp_periodic = self.dhcp_periodic_p.start()
|
|
self.plugin = importutils.import_object('neutron.plugins.ml2.plugin.'
|
|
'Ml2Plugin')
|
|
self.assertEqual(1, self.patched_dhcp_periodic.call_count)
|
|
self.plugin.network_scheduler = importutils.import_object(
|
|
'neutron.scheduler.dhcp_agent_scheduler.WeightScheduler'
|
|
)
|
|
cfg.CONF.set_override('dhcp_agents_per_network', 1)
|
|
cfg.CONF.set_override("dhcp_load_type", "networks")
|
|
|
|
def test_scheduler_one_agents_per_network(self):
|
|
cfg.CONF.set_override('dhcp_agents_per_network', 1)
|
|
self._save_networks(['1111'])
|
|
agents = self._get_agents(['host-c', 'host-d'])
|
|
self._save_agents(agents)
|
|
self.plugin.network_scheduler.schedule(self.plugin, self.ctx,
|
|
{'id': '1111'})
|
|
agents = self.plugin.get_dhcp_agents_hosting_networks(self.ctx,
|
|
['1111'])
|
|
self.assertEqual(1, len(agents))
|
|
|
|
def test_scheduler_two_agents_per_network(self):
|
|
cfg.CONF.set_override('dhcp_agents_per_network', 2)
|
|
self._save_networks(['1111'])
|
|
agents = self._get_agents(['host-c', 'host-d'])
|
|
self._save_agents(agents)
|
|
self.plugin.network_scheduler.schedule(self.plugin, self.ctx,
|
|
{'id': '1111'})
|
|
agents = self.plugin.get_dhcp_agents_hosting_networks(self.ctx,
|
|
['1111'])
|
|
self.assertEqual(2, len(agents))
|
|
|
|
def test_scheduler_no_active_agents(self):
|
|
self._save_networks(['1111'])
|
|
self.plugin.network_scheduler.schedule(self.plugin, self.ctx,
|
|
{'id': '1111'})
|
|
agents = self.plugin.get_dhcp_agents_hosting_networks(self.ctx,
|
|
['1111'])
|
|
self.assertEqual(0, len(agents))
|
|
|
|
def test_scheduler_equal_distribution(self):
|
|
cfg.CONF.set_override('dhcp_agents_per_network', 1)
|
|
self._save_networks(['1111', '2222', '3333'])
|
|
agents = self._get_agents(['host-c', 'host-d'])
|
|
self._save_agents(agents)
|
|
callback = agents_db.AgentExtRpcCallback()
|
|
callback.report_state(self.ctx,
|
|
agent_state={'agent_state': self.hostc},
|
|
time=timeutils.strtime())
|
|
callback.report_state(self.ctx,
|
|
agent_state={'agent_state': self.hostd},
|
|
time=timeutils.strtime())
|
|
self.plugin.network_scheduler.schedule(self.plugin, self.ctx,
|
|
{'id': '1111'})
|
|
agent1 = self.plugin.get_dhcp_agents_hosting_networks(self.ctx,
|
|
['1111'])
|
|
self.hostd['configurations']['networks'] = 2
|
|
callback.report_state(self.ctx,
|
|
agent_state={'agent_state': self.hostd},
|
|
time=timeutils.strtime())
|
|
self.plugin.network_scheduler.schedule(self.plugin, self.ctx,
|
|
{'id': '2222'})
|
|
agent2 = self.plugin.get_dhcp_agents_hosting_networks(self.ctx,
|
|
['2222'])
|
|
self.hostc['configurations']['networks'] = 4
|
|
callback.report_state(self.ctx,
|
|
agent_state={'agent_state': self.hostc},
|
|
time=timeutils.strtime())
|
|
self.plugin.network_scheduler.schedule(self.plugin, self.ctx,
|
|
{'id': '3333'})
|
|
agent3 = self.plugin.get_dhcp_agents_hosting_networks(self.ctx,
|
|
['3333'])
|
|
self.assertEqual('host-c', agent1[0]['host'])
|
|
self.assertEqual('host-c', agent2[0]['host'])
|
|
self.assertEqual('host-d', agent3[0]['host'])
|