openstack
/
neutron
Code Issues Proposed changes
neutron/neutron/objects
History
Matthew Booth de3681ed3b Fix invalid JSON generated by quota details 
The value fetched by Quotasv2_detail.get_resources() is ultimately
returned by Reservation.get_total_reservations_map. The total_reserved
value is returned by a sqlalchemy sum(), and is of a type defined by
the database driver in use. PyMySQL returns a Decimal here, which
the api layer serialises to JSON as a string.

Note that if a resource has no reservations then its value will be
defaulted in DbQuotaDriver.get_detailed_tenant_quotas to the integer
value 0. This means that the value is an integer if zero, or a string
otherwise. This causes parsing difficulties for client libraries which
do strict type checking.

Testing note:
This method is already covered by the unit test
TestQuotaDbApi.test_get_reservations_for_resource, which also already
tests the return value and, implicitly, its type. However, it does not
currently fail because the unit tests run with SQLite rather than MySQL.
SQLite returns an int where MySQL returns a Decimal, which does not
trigger the bug.

TestQuotaDbApi.test_get_reservations_for_resource is sufficient to
demonstrate that the patch doesn't regress SQLite. We were not able to
think of a deterministic way to write a Tempest test for this, which
would cover MySQL. Ideally we would have the ability to run the DB test
suites under MySQL and PostreSQL in addition to SQLite using oslo.db's
OpportunisticDbFixture, but the scope of that is larger than this
change.

Closes-Bug: #1918565
Change-Id: Icda0d63f2f5ea72bde423296c76aa46646fa98a8
(cherry picked from commit 9ed17cec2d)
 		2021-03-19 15:15:58 +00:00
..
db remove the neutron.db._model_query module 2019-01-25 08:55:25 -07:00
extensions use object standardattributes from neutron-lib 2019-06-12 13:57:00 -06:00
logapi use object event_types from neutron-lib 2019-06-18 14:25:02 -06:00
plugins Fix queries to retrieve allocations with network_segment_range 2020-03-16 16:16:30 +00:00
port use AuthenticIPNetwork and AuthenticEUI from neutron-lib 2019-06-25 08:47:48 -06:00
qos Fix objname error in QosPolicy 2019-08-13 17:13:09 -04:00
README.rst Objects: Add README for neutron/objects directory tree 2016-10-07 15:12:20 +00:00
__init__.py Use dirname in object recursive import 2017-04-20 04:35:10 -07:00
address_scope.py Relax subnet pool network affinity constraints 2019-07-31 10:01:55 -05:00
agent.py Merge "postgresql compatibility for get_l3_agent routines" 2019-04-12 13:01:27 +00:00
auto_allocate.py [OVO] Switch to use own registry 2017-11-22 17:44:22 +01:00
base.py use object standardattributes from neutron-lib 2019-06-12 13:57:00 -06:00
common_types.py use AuthenticIPNetwork and AuthenticEUI from neutron-lib 2019-06-25 08:47:48 -06:00
conntrack_helper.py Conntrack Helper - OVO and db script 2019-05-20 18:00:18 +02:00
flavor.py [OVO] Switch to use own registry 2017-11-22 17:44:22 +01:00
floatingip.py Integration of Floating IP OVO 2017-12-04 19:30:02 +09:00
ipam.py [OVO] Switch to use own registry 2017-11-22 17:44:22 +01:00
l3_hamode.py remove neutron.common.constants 2019-04-04 14:10:26 -06:00
l3agent.py Fix pep8 E128 warnings in non-test code 2019-03-12 21:22:33 +00:00
metering.py use AuthenticIPNetwork and AuthenticEUI from neutron-lib 2019-06-25 08:47:48 -06:00
network.py Fix pep8 E128 warnings in non-test code 2019-03-12 21:22:33 +00:00
network_segment_range.py Workaround in NetworkSegmentRange OVO until "project_id" migration 2020-04-24 10:33:18 +00:00
port_forwarding.py Fix pylint R1714 (consider-using-in) refactor messages 2019-02-21 21:11:34 +00:00
ports.py Auto-delete dhcp ports on segment delete 2020-07-13 12:43:04 +02:00
provisioning_blocks.py [OVO] Switch to use own registry 2017-11-22 17:44:22 +01:00
quota.py Fix invalid JSON generated by quota details 2021-03-19 15:15:58 +00:00
rbac.py Use RBACBaseObject OVO in neutron/db/rbac_db_mixin.py 2018-11-08 13:41:36 +00:00
rbac_db.py Fix list security groups performance with RBAC 2019-07-07 17:44:56 -05:00
router.py Add "Port" to "RouterPort" foreign_keys 2019-09-07 09:29:44 +00:00
securitygroup.py Filter by owner SGs when retrieving the SG rules 2020-04-14 18:37:12 +00:00
servicetype.py [OVO] Switch to use own registry 2017-11-22 17:44:22 +01:00
stdattrs.py use object standardattributes from neutron-lib 2019-06-12 13:57:00 -06:00
subnet.py [OVN] Allow IP allocation with different segments for OVN service ports 2020-07-27 11:53:37 +00:00
subnetpool.py Allow objects to opt in new engine facade 2018-02-09 04:07:34 +00:00
tag.py Fix pep8 E128 warnings in non-test code 2019-03-12 21:22:33 +00:00
trunk.py Switch to new engine facade for TrunkPlugin and TrunkSkeleton 2019-07-04 14:24:17 +00:00

README.rst

Neutron Objects

Directory

This directory is designed to contain all modules which have objects definitions shipped with core Neutron. The files and directories located inside of this directory should follow the guidelines below.

Structure

The Neutron objects tree should have the following structure:

  • The expected directory structure is flat, except for the ML2 plugins. All ML2 plugin objects should fall under the plugins subdirectory (i.e. plugins/ml2/gre_allocation).
  • Module names should use singular forms for nouns (network.py, not networks.py).