972cdef50c
Add decorations where required. There are roughly a dozen classes in Neutron that define abstract methods or properties but are not decorated with @six.add_metaclass(abc.ABCMeta). Without this decoration, children can be created without defining the required methods or properties. Decorating RBACColumns in db/rbac_db_models.py causes failures and will be reported separately. Decorating unit tests is of dubious benifit and should be addressed separately (if at all). There are also several more places where metaclassing isn't correct, to be taken care of in follow-on patches. For example, BaseScheduler is using the fact the None doesn't have a filter_agents() method, which gives developers confusing error messages when they incorrectly implement the interface, and they won't see any error until schedule() is called. As an aside, the docstring for this base class is also incorrect. Change-Id: I2b2cce37d9b0d40559a715a7d510a969b8ba9963 Closes-Bug: #1577648
44 lines
1.8 KiB
Python
44 lines
1.8 KiB
Python
# Copyright (c) 2015 OpenStack Foundation.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import abc
|
|
|
|
import six
|
|
|
|
|
|
@six.add_metaclass(abc.ABCMeta)
|
|
class BaseResourceFilter(object):
|
|
"""Encapsulate logic that is specific to the resource type."""
|
|
@abc.abstractmethod
|
|
def filter_agents(self, plugin, context, resource):
|
|
"""Return the agents that can host the resource."""
|
|
|
|
def bind(self, context, agents, resource_id):
|
|
"""Bind the resource to the agents."""
|
|
with context.session.begin(subtransactions=True):
|
|
res = {}
|
|
for agent in agents:
|
|
# Load is being incremented here to reflect latest agent load
|
|
# even within the agent report interval. This will be very
|
|
# much necessary when bulk resource creation happens within a
|
|
# agent report interval time.
|
|
# NOTE: The resource being bound might or might not be of the
|
|
# same type which is accounted for the load. It isn't a
|
|
# problem because "+ 1" here does not meant to predict
|
|
# precisely what the load of the agent will be. The value will
|
|
# be corrected by the agent on the next report interval.
|
|
res['load'] = agent.load + 1
|
|
agent.update(res)
|