openstack
/
neutron
Code Issues Proposed changes
neutron/neutron/db
History
Fernando Royo 92efd8e45b Dont raise RouterInterfaceNotFound on overlap check router ports 
A corner case of the fix done in [1] could happend if, as a race
scenario, parallel requests evaluate other ports that could be deleted
during the process if they had already determined a overlapping, in that
case a RouterInterfaceNotFound exception was raised and the request
finished with that exception and a 404 status code.

This patch removes the exception due to a port not found, because if the
port is not found, the related subnet should not participate in the
overlap evaluation, so it makes no sense to break the process for a port
that no longer exists. It also improves the previous validation to
perform the overlapping check, being performed only when we have
at least more than one subnet, as the overlapping check with only one
subnet did not make sense.

Closes-Bug: #1998226

[1] https://review.opendev.org/c/openstack/neutron/+/859143

Change-Id: If4afe6f525c46f9cf7f02d8aae27dfc56144fd62
 		2022-12-02 17:37:40 +00:00
..
allowed_address_pairs Clean up deprecated sqla model import paths 2017-02-25 03:42:34 +00:00
availability_zone Always create a "router_extra_attributes" register per router 2022-11-18 08:51:43 +00:00
extra_dhcp_opt Cleanup _find_related_obj 2017-02-25 06:29:33 +00:00
metering Replace "tenant_id" with "project_id" in metering service 2021-10-28 09:42:52 +00:00
migration db: add segment_index to the unique constraint 2022-11-23 08:43:21 +01:00
models db: add segment_index to the unique constraint 2022-11-23 08:43:21 +01:00
network_dhcp_agent_binding Move migration to proper dir and fix objects tests 2019-11-04 17:44:44 +00:00
port_security Cleanup _find_related_obj 2017-02-25 06:29:33 +00:00
qos Add network QoS inheritance to floating IP 2021-11-24 09:01:09 +00:00
quota Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
__init__.py
…
_utils.py Finish the new DB engine facade migration 2020-11-24 09:20:35 +00:00
address_group_db.py Unify the states format for address group payloads 2021-10-26 19:16:46 -05:00
address_scope_db.py Allow sharing of address scopes via RBAC mechanism 2020-03-19 16:51:39 +02:00
agents_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
agentschedulers_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
allowedaddresspairs_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
data_plane_status_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
db_base_plugin_common.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
db_base_plugin_v2.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
dns_db.py Fix pep8 E128 warnings in non-test code 2019-03-12 21:22:33 +00:00
dvr_mac_db.py [sqlalchemy-20] Add missing DB contexts in L3 methods 2022-05-15 11:39:54 +00:00
external_net_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
extradhcpopt_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
extraroute_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
flavors_db.py delete common_db_mixin 2019-04-17 11:25:41 -06:00
ipam_backend_mixin.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
ipam_pluggable_backend.py Allow to pass EUI64 IP address as fixed ip for the port 2022-10-01 22:13:37 +02:00
l3_agentschedulers_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
l3_attrs_db.py Always create a "router_extra_attributes" register per router 2022-11-18 08:51:43 +00:00
l3_db.py Dont raise RouterInterfaceNotFound on overlap check router ports 2022-12-02 17:37:40 +00:00
l3_dvr_db.py Merge "Always create a "router_extra_attributes" register per router" 2022-11-23 08:05:48 +00:00
l3_dvr_ha_scheduler_db.py Fix connection between 2 dvr routers 2018-11-01 18:01:25 +01:00
l3_dvrscheduler_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
l3_fip_pools_db.py Revert "Set system_scope='all' in elevated context" 2021-06-15 10:29:20 +02:00
l3_fip_port_details.py remove the neutron.db._resource_extend module 2019-01-02 13:02:06 -07:00
l3_fip_qos.py [QoS][L3] Use floating IP OVO QoS fields 2022-03-15 09:14:24 +00:00
l3_gateway_ip_qos.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
l3_gwmode_db.py Improve Router callback system's publish events 2021-12-05 04:36:36 +00:00
l3_hamode_db.py Merge "Always create a "router_extra_attributes" register per router" 2022-11-23 08:05:48 +00:00
l3_hascheduler_db.py use payloads for PORT AFTER_UPDATE events 2021-07-07 21:01:24 +00:00
local_ip_db.py Add Local IP Extension and DB 2021-11-11 10:08:23 +03:00
models_v2.py Fix remaining typos in comments and tests 2022-07-06 21:20:27 +05:30
network_ip_availability_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
ovn_hash_ring_db.py Revert "Move the "ovn_hash_ring" clean up to maintenance worker" 2022-09-23 14:09:26 +00:00
ovn_revision_numbers_db.py Merge "[OVN] Prevent maintenance task fail resource stdattr does not exist" 2022-11-28 18:45:40 +00:00
port_device_profile_db.py Add port device profile extension 2021-01-22 16:17:30 +00:00
port_numa_affinity_policy_db.py Add port NUMA affinity policy 2020-11-13 15:49:34 +00:00
portsecurity_db.py remove the neutron.db._resource_extend module 2019-01-02 13:02:06 -07:00
portsecurity_db_common.py Start enforcing E125 flake8 directive 2019-07-19 23:39:41 -04:00
provisioning_blocks.py Use neutron-lib method is_session_active 2022-08-11 05:58:44 +02:00
rbac_db_mixin.py Replace "target_tenant" with "target_project" in RBAC OVOs and models 2021-12-03 10:48:57 +00:00
rbac_db_models.py Replace "target_tenant" with "target_project" in RBAC OVOs and models 2021-12-03 10:48:57 +00:00
securitygroups_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
securitygroups_rpc_base.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
segments_db.py use payloads for SEGMENT events 2021-05-05 15:17:50 +03:00
servicetype_db.py Fix some pylint indentation warnings 2022-11-03 19:50:54 -04:00
standardattrdescription_db.py Use neutron-lib standard_attr 2021-09-15 09:19:26 +00:00
subnet_service_type_mixin.py remove the neutron.db._resource_extend module 2019-01-02 13:02:06 -07:00
uplink_status_propagation_db.py [SR-IOV] Default "propagate_uplink_status" flag to True 2022-03-21 11:43:08 +00:00
vlantransparent_db.py remove the neutron.db._resource_extend module 2019-01-02 13:02:06 -07:00