openstack
/
neutron
Code Issues Proposed changes
neutron/neutron/agent
History
Ihar Hrachyshka 59b9735af1 tests: confirm that _output_hosts_file does not log too often 
I3ad7864eeb2f959549ed356a1e34fa18804395cc didn't include any regression unit
tests to validate that the method won't ever log too often again,
reintroducing performance drop in later patches. It didn't play well
with stable backports of the fix, where context was lost when doing the
backport, that left the bug unfixed in stable/juno even though the patch
was merged there [1].

The patch adds an explicit note in the code that suggests not to add new
log messages inside the loop to avoid regression, and a unit test was
added to capture it.

Once the test is merged in master, it will be proposed for stable/juno
inclusion, with additional changes that would fix the regression again.

Conflicts:
	neutron/agent/linux/dhcp.py
	neutron/tests/unit/test_linux_dhcp.py

Local changes:
- remove LOG.debug messages that sneaked into the for loop with a
  backport.

Related-Bug: #1414218
Change-Id: I5d43021932d6a994638c348eda277dd8337cf041
(cherry picked from commit 3b74095a93)
 		2015-04-23 11:37:47 +02:00
..
common Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
linux tests: confirm that _output_hosts_file does not log too often 2015-04-23 11:37:47 +02:00
metadata Merge "Rename workers to api_workers and simplify code" 2014-09-29 16:58:40 +00:00
__init__.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
dhcp_agent.py Fix enable_metadata_network flag 2014-12-05 14:06:03 +01:00
firewall.py Add missing methods to NoopFirewallDriver 2014-10-07 15:58:52 +00:00
l2population_rpc.py Remove @author(s) from copyright statements 2014-09-15 21:40:09 +09:00
l3_agent.py Improve exception handling in _process_router_update() 2015-02-25 15:50:57 +03:00
l3_ha_agent.py Default route missing for IPv6 subnets in HA Router 2015-03-05 15:12:07 +00:00
netns_cleanup_util.py Remove unused arg to config.setup_logging() 2014-09-05 12:05:17 +10:00
ovs_cleanup_util.py Remove unused arg to config.setup_logging() 2014-09-05 12:05:17 +10:00
rpc.py Fix AttributeError during startup of ovs agent in DVR mode 2015-01-23 09:38:11 -08:00
securitygroups_rpc.py Fix a race condition adding a security group rule 2014-12-25 00:44:11 +00:00