71b305cb9e
Recent pep8 upgrade and corresponding pycodestyle update break
pep8 job due to the new rules.
This commit fixes the following new errors:
- E266 too many leading '#' for block comment
- E501 line too long
- H903 Windows style line endings not allowed in code
The following errors are added to the ignore list
as there are many errors:
- E402 module level import not at top of file
- E731 do not assign a lambda expression, use a def
- W503 line break before binary operator
Conflicts:
neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/test_linuxbridge_neutron_agent.py
Change-Id: I1fd3357479bb2ba3d89de92739ffac99900761b6
(cherry picked from commit 7a714aeb13
)
193 lines
6.8 KiB
INI
193 lines
6.8 KiB
INI
[tox]
|
|
envlist = docs,py35,py27,pep8
|
|
minversion = 2.3.2
|
|
skipsdist = True
|
|
|
|
[testenv]
|
|
setenv = VIRTUAL_ENV={envdir}
|
|
PYTHONWARNINGS=default::DeprecationWarning
|
|
passenv = TRACE_FAILONLY GENERATE_HASHES http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY
|
|
usedevelop = True
|
|
install_command =
|
|
pip install -U -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=stable/queens} {opts} {packages}
|
|
deps = -r{toxinidir}/requirements.txt
|
|
-r{toxinidir}/test-requirements.txt
|
|
whitelist_externals = sh
|
|
commands =
|
|
{toxinidir}/tools/ostestr_compat_shim.sh {posargs}
|
|
# there is also secret magic in ostestr which lets you run in a fail only
|
|
# mode. To do this define the TRACE_FAILONLY environmental variable.
|
|
|
|
[testenv:common]
|
|
# Fake job to define environment variables shared between dsvm/non-dsvm jobs
|
|
setenv = OS_TEST_TIMEOUT={env:OS_TEST_TIMEOUT:180}
|
|
commands = false
|
|
|
|
[testenv:dsvm]
|
|
# Fake job to define environment variables shared between dsvm jobs
|
|
setenv = OS_SUDO_TESTING=1
|
|
OS_ROOTWRAP_CMD=sudo {envdir}/bin/neutron-rootwrap {envdir}/etc/neutron/rootwrap.conf
|
|
OS_ROOTWRAP_DAEMON_CMD=sudo {envdir}/bin/neutron-rootwrap-daemon {envdir}/etc/neutron/rootwrap.conf
|
|
OS_FAIL_ON_MISSING_DEPS=1
|
|
OS_LOG_PATH={env:OS_LOG_PATH:/opt/stack/logs}
|
|
commands = false
|
|
|
|
[testenv:functional]
|
|
basepython = python2.7
|
|
setenv = {[testenv]setenv}
|
|
{[testenv:common]setenv}
|
|
OS_TEST_PATH=./neutron/tests/functional
|
|
OS_LOG_PATH={env:OS_LOG_PATH:/opt/stack/logs}
|
|
deps =
|
|
{[testenv]deps}
|
|
-r{toxinidir}/neutron/tests/functional/requirements.txt
|
|
|
|
[testenv:functional-python35]
|
|
basepython = python3.5
|
|
setenv = {[testenv:functional]setenv}
|
|
deps =
|
|
{[testenv:functional]deps}
|
|
|
|
[testenv:dsvm-functional]
|
|
basepython = python2.7
|
|
setenv = {[testenv:functional]setenv}
|
|
{[testenv:dsvm]setenv}
|
|
deps =
|
|
{[testenv:functional]deps}
|
|
commands =
|
|
{toxinidir}/tools/deploy_rootwrap.sh {toxinidir} {envdir}/etc {envdir}/bin
|
|
{toxinidir}/tools/ostestr_compat_shim.sh {posargs}
|
|
|
|
[testenv:dsvm-functional-python35]
|
|
basepython = python3.5
|
|
setenv = {[testenv:dsvm-functional]setenv}
|
|
deps =
|
|
{[testenv:dsvm-functional]deps}
|
|
commands =
|
|
{toxinidir}/tools/deploy_rootwrap.sh {toxinidir} {envdir}/etc {envdir}/bin
|
|
{toxinidir}/tools/ostestr_compat_shim.sh {posargs}
|
|
|
|
[testenv:dsvm-fullstack]
|
|
setenv = {[testenv]setenv}
|
|
{[testenv:common]setenv}
|
|
{[testenv:dsvm]setenv}
|
|
# workaround for DB teardown lock contention (bug/1541742)
|
|
OS_TEST_TIMEOUT={env:OS_TEST_TIMEOUT:600}
|
|
OS_TEST_PATH=./neutron/tests/fullstack
|
|
deps =
|
|
{[testenv:functional]deps}
|
|
commands =
|
|
{toxinidir}/tools/generate_dhclient_script_for_fullstack.sh {envdir}
|
|
{toxinidir}/tools/deploy_rootwrap.sh {toxinidir} {envdir}/etc {envdir}/bin
|
|
{[testenv]commands}
|
|
|
|
[testenv:dsvm-fullstack-python35]
|
|
basepython = python3.5
|
|
setenv = {[testenv:dsvm-fullstack]setenv}
|
|
deps =
|
|
{[testenv:dsvm-fullstack]deps}
|
|
commands =
|
|
{[testenv:dsvm-fullstack]commands}
|
|
|
|
|
|
[testenv:releasenotes]
|
|
commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
|
|
|
|
[testenv:pep8]
|
|
basepython = python2.7
|
|
deps =
|
|
{[testenv]deps}
|
|
commands=
|
|
# If it is easier to add a check via a shell script, consider adding it in this file
|
|
sh ./tools/misc-sanity-checks.sh
|
|
{toxinidir}/tools/check_unit_test_structure.sh
|
|
# Checks for coding and style guidelines
|
|
flake8
|
|
sh ./tools/coding-checks.sh --pylint '{posargs}'
|
|
neutron-db-manage --config-file neutron/tests/etc/neutron.conf check_migration
|
|
python ./tools/list_moved_globals.py
|
|
{[testenv:genconfig]commands}
|
|
{[testenv:bashate]commands}
|
|
{[testenv:bandit]commands}
|
|
whitelist_externals =
|
|
sh
|
|
bash
|
|
|
|
[testenv:cover]
|
|
basepython = python2.7
|
|
commands =
|
|
python setup.py testr --coverage --testr-args='{posargs}'
|
|
coverage report --fail-under=82 --skip-covered
|
|
|
|
[testenv:venv]
|
|
commands = {posargs}
|
|
|
|
[testenv:docs]
|
|
commands = sphinx-build -W -b html doc/source doc/build/html
|
|
|
|
[testenv:linkcheck]
|
|
commands = sphinx-build -W -b linkcheck doc/source doc/build/linkcheck
|
|
|
|
[flake8]
|
|
# E125 continuation line does not distinguish itself from next logical line
|
|
# E126 continuation line over-indented for hanging indent
|
|
# E128 continuation line under-indented for visual indent
|
|
# E129 visually indented line with same indent as next logical line
|
|
# E265 block comment should start with '# '
|
|
# H404 multi line docstring should start with a summary
|
|
# H405 multi line docstring summary not separated with an empty line
|
|
# N530 direct neutron imports not allowed
|
|
# TODO(ihrachys) figure out what to do with N534 and N536
|
|
# N534 Untranslated exception message
|
|
# N536 Use assertIsNone rather than assertEqual to check for None values
|
|
# TODO(amotoki) check the following new rules should be fixed or ignored
|
|
# E402 module level import not at top of file
|
|
# E731 do not assign a lambda expression, use a def
|
|
# W503 line break before binary operator
|
|
ignore = E125,E126,E128,E129,E265,E402,E731,W503,H404,H405,N530,N534,N536
|
|
# H106: Don't put vim configuration in source files
|
|
# H203: Use assertIs(Not)None to check for None
|
|
# H904: Delay string interpolations at logging calls
|
|
enable-extensions=H106,H203,H904
|
|
show-source = true
|
|
exclude = ./.*,build,dist,doc
|
|
import-order-style = pep8
|
|
|
|
[hacking]
|
|
import_exceptions = neutron._i18n
|
|
local-check-factory = neutron.hacking.checks.factory
|
|
|
|
[testenv:bandit]
|
|
# B101: Use of assert detected
|
|
# B104: Possible binding to all interfaces
|
|
# B108: Probable insecure usage of temp file/directory
|
|
# B111: Execute with run_as_root=True identified, possible security issue
|
|
# B311: Standard pseudo-random generators are not suitable for security/cryptographic purpose
|
|
deps = -r{toxinidir}/test-requirements.txt
|
|
commands = bandit -r neutron -x tests -n5 -s B101,B104,B108,B111,B311
|
|
|
|
[testenv:bashate]
|
|
commands = bash -c "find {toxinidir} \
|
|
-not \( -type d -name .tox\* -prune \) \
|
|
-not \( -type d -name .venv\* -prune \) \
|
|
-type f \
|
|
-name \*.sh \
|
|
# E005 file does not begin with #! or have a .sh prefix
|
|
# E006 check for lines longer than 79 columns
|
|
# E042 local declaration hides errors
|
|
# E043 Arithmetic compound has inconsistent return semantics
|
|
-print0 | xargs -0 bashate -v -iE006 -eE005,E042,E043"
|
|
|
|
[testenv:genconfig]
|
|
commands = {toxinidir}/tools/generate_config_file_samples.sh
|
|
|
|
# This environment can be used to quickly validate that all needed system
|
|
# packages required to successfully execute test targets are installed
|
|
[testenv:bindep]
|
|
# Do not install any requirements. We want this to be fast and work even if
|
|
# system dependencies are missing, since it's used to tell you what system
|
|
# dependencies are missing! This also means that bindep must be installed
|
|
# separately, outside of the requirements files.
|
|
deps = bindep
|
|
commands = bindep test
|