openstack/neutron
Code Issues Proposed changes
6f3ae396ed
neutron/neutron/tests/unit
History
Bertrand Lallau 6f3ae396ed Don't allow user to set firewall rule with port and no protocol 
Creating firewall rules specifying a destination port and/or a source
port without a protocol, generates rules without src or dest port
restriction. This was a real security issue for cloud users.

This patch generates a 400 Bad request "Source/destination port
requires a protocol" in case of creation/update of firewall rules
specifying a destination port and/or a source port and without protocol.

DocImpact
Closes-Bug: #1365961

Change-Id: I4a3a1d9ae7ec4b2a864b3edc83d65ef7f80cbba5
2014-09-10 11:47:54 +02:00
..
agent Throw exception instances instead of classes 2014-09-07 12:56:30 +04:00
api Do not schedule network when creating reserved DHCP port 2014-07-30 07:42:20 +09:00
bigswitch Big Switch: Separate L3 functions into L3 service 2014-09-01 12:50:32 -07:00
brocade Remove auto-generation of db schema from models at startup 2014-08-15 17:21:17 -04:00
cisco Throw exception instances instead of classes 2014-09-07 12:56:30 +04:00
db Don't allow user to set firewall rule with port and no protocol 2014-09-10 11:47:54 +02:00
embrane Remove auto-generation of db schema from models at startup 2014-08-15 17:21:17 -04:00
extensions Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
hyperv Refresh rpc_backend values in unit tests to those from oslo.messaging 2014-08-22 11:02:25 +02:00
ibm Refresh rpc_backend values in unit tests to those from oslo.messaging 2014-08-22 11:02:25 +02:00
linuxbridge Make SecurityGroupsRpcCallback a separate callback class 2014-08-30 10:19:42 +08:00
metaplugin Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
midonet Implement Midonet Juno Network Api calls 2014-07-31 15:51:10 +09:00
ml2 Merge "Update DVR Binding when router_id changes" 2014-09-09 03:04:36 +00:00
mlnx Merge "Fix incorrect number of args to string format" 2014-08-27 09:42:31 +00:00
nec Make SecurityGroupsRpcCallback a separate callback class 2014-08-30 10:19:42 +08:00
notifiers Replace loopingcall in notifier with a delayed send 2014-04-22 16:22:02 +00:00
nuage Implements sync mechanism between Neutron and Nuage VSD 2014-09-02 00:25:10 -07:00
ofagent Merge "ofagent: Implement physical_interface_mappings" 2014-09-03 01:59:32 +00:00
oneconvergence Make SecurityGroupsRpcCallback a separate callback class 2014-08-30 10:19:42 +08:00
opencontrail Remove auto-generation of db schema from models at startup 2014-08-15 17:21:17 -04:00
openvswitch Make SecurityGroupsRpcCallback a separate callback class 2014-08-30 10:19:42 +08:00
plumgrid Security groups extension for PLUMgrid plugin 2014-07-13 23:48:27 -07:00
ryu Make SecurityGroupsRpcCallback a separate callback class 2014-08-30 10:19:42 +08:00
services Merge "Cisco VPN with in-band CSR (interim solution)" 2014-09-03 01:59:16 +00:00
sriovnicagent Refresh rpc_backend values in unit tests to those from oslo.messaging 2014-08-22 11:02:25 +02:00
vmware Throw exception instances instead of classes 2014-09-07 12:56:30 +04:00
__init__.py Fix state_path in tests 2014-08-29 17:42:07 +03:00
_test_extension_portbindings.py Return 403 instead of 404 on attr policy failures 2014-08-06 07:40:39 -07:00
_test_rootwrap_exec.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
database_stubs.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
dummy_plugin.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
extension_stubs.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_agent_config.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_agent_ext_plugin.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_agent_linux_utils.py Make log level in linux.utils.execute configurable 2014-08-26 13:19:34 +04:00
test_agent_netns_cleanup.py Call config_parse in base test setup 2014-07-27 13:31:12 -07:00
test_agent_ovs_cleanup.py Call config_parse in base test setup 2014-07-27 13:31:12 -07:00
test_agent_rpc.py Remove redundant topic from rpc calls 2014-08-05 10:14:20 +00:00
test_api_api_common.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_api_v2_extension.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_api_v2_resource.py Send HTTP exceptions in the format expected by neutronclient 2014-08-18 17:21:45 +04:00
test_api_v2.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_attributes.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_auth.py add auth token to context 2014-08-12 11:17:21 +09:00
test_basetestcase.py Prevent SystemExits when running tests 2014-09-01 15:05:16 -07:00
test_common_log.py Use method's logger in log decorator 2014-07-15 11:08:33 +02:00
test_common_utils.py Log exceptions inside spawned functions 2014-07-24 21:21:02 +08:00
test_config.py Fix state_path in tests 2014-08-29 17:42:07 +03:00
test_db_migration.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_db_plugin_level.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_db_plugin.py Merge "Removing sorted() function from assertEqual()" 2014-08-26 09:03:04 +00:00
test_debug_commands.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_dhcp_agent.py Merge "Don't spawn metadata-proxy for non-isolated nets" 2014-09-04 06:40:54 +00:00
test_dhcp_rpc.py Make DhcpRpcCallback a separate callback class 2014-08-28 14:25:32 +00:00
test_dhcp_scheduler.py Remove auto-generation of db schema from models at startup 2014-08-15 17:21:17 -04:00
test_extension_allowedaddresspairs.py no quota for allowed address pair 2014-07-17 23:06:10 +08:00
test_extension_ext_gw_mode.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_extension_ext_net.py Return 403 instead of 404 on attr policy failures 2014-08-06 07:40:39 -07:00
test_extension_extended_attribute.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_extension_extradhcpopts.py extra_dhcp_opt add checks for empty strings 2013-12-13 08:40:28 -07:00
test_extension_extraroute.py Change all occurences of no_delete to do_delete 2014-07-13 14:09:26 +03:00
test_extension_firewall.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_extension_pnet.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_extension_portsecurity.py Return 403 instead of 404 on attr policy failures 2014-08-06 07:40:39 -07:00
test_extension_security_group.py Change all occurences of no_delete to do_delete 2014-07-13 14:09:26 +03:00
test_extensions.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_hacking.py Use jsonutils instead of stdlib json 2014-08-14 12:45:58 +02:00
test_iptables_firewall.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_iptables_manager.py Stop tracking connections in DVR FIP Namespace 2014-09-05 15:41:48 -04:00
test_ipv6.py Reset IPv6 detection flag after IPv6 tests 2014-09-04 22:02:28 -07:00
test_l3_agent.py Merge "Fix interface IP address for DVR with gateway" 2014-09-03 16:52:17 +00:00
test_l3_plugin.py Make L3RpcCallback a separate callback class 2014-08-27 09:54:25 +09:00
test_l3_schedulers.py Remove subnet_id from check_ports_exist_on_l3agent 2014-09-08 16:11:41 +00:00
test_linux_daemon.py Make pid file locking non-blocking 2014-05-21 13:29:01 -07:00
test_linux_dhcp.py Throw exception instances instead of classes 2014-09-07 12:56:30 +04:00
test_linux_external_process.py Implements ProcessMonitor to watch over external processes 2014-09-02 06:20:08 +02:00
test_linux_interface.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_linux_ip_lib.py Merge "Make log level in linux.utils.execute configurable" 2014-09-02 21:17:49 +00:00
test_metadata_agent.py Fix 404 error fetching metadata when using DVR 2014-08-12 12:26:31 -07:00
test_metadata_namespace_proxy.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_neutron_context.py add auth token to context 2014-08-12 11:17:21 +09:00
test_neutron_manager.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_policy.py Use jsonutils instead of stdlib json 2014-08-14 12:45:58 +02:00
test_post_mortem_debug.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_provider_configuration.py Remove the useless vim modelines 2014-06-21 15:07:31 +08:00
test_quota_ext.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_routerserviceinsertion.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_security_groups_rpc.py Merge "Stop tracking connections in DVR FIP Namespace" 2014-09-07 02:53:58 +00:00
test_servicetype.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00
test_wsgi.py Ignore http_proxy while connecting to test WSGI server 2014-08-14 11:39:24 +10:00
testlib_api.py Remove auto-generation of db schema from models at startup 2014-08-15 17:21:17 -04:00
testlib_plugin.py Refactor plugin setup helpers out of test.base 2014-08-25 14:44:27 +02:00