Policies for those API actions should not rely on the "PROJECT_READER"
or "PROJECT_MEMBER" rules as this resource don't have project_id
attribute and instead belongs to the project of the parent resource
(which is l3_router).
This patch updates those rules to:
base.ADMIN_OR_PARENT_OWNER_MEMBER
base.ADMIN_OR_PARENT_OWNER_READER
Closes-bug: #2126759
Change-Id: Id67346262a3dbe4717273073b5f8c6a385d2180d
Signed-off-by: Slawek Kaplonski <skaplons@redhat.com>
(cherry picked from commit 0edbfe26d0)
276 lines
9.3 KiB
Python
276 lines
9.3 KiB
Python
# Copyright (c) 2021 Red Hat Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from unittest import mock
|
|
|
|
from oslo_policy import policy as base_policy
|
|
from oslo_utils import uuidutils
|
|
|
|
from neutron import policy
|
|
from neutron.tests.unit.conf.policies import test_base as base
|
|
|
|
|
|
class L3ConntrackHelperAPITestCase(base.PolicyBaseTestCase):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.router = {
|
|
'id': uuidutils.generate_uuid(),
|
|
'tenant_id': self.project_id,
|
|
'project_id': self.project_id}
|
|
self.alt_router = {
|
|
'id': uuidutils.generate_uuid(),
|
|
'tenant_id': self.alt_project_id,
|
|
'project_id': self.alt_project_id}
|
|
|
|
self.target = {
|
|
'router_id': self.router['id'],
|
|
'ext_parent_router_id': self.router['id']}
|
|
self.alt_target = {
|
|
'router_id': self.alt_router['id'],
|
|
'ext_parent_router_id': self.alt_router['id']}
|
|
|
|
routers = {
|
|
self.router['id']: self.router,
|
|
self.alt_router['id']: self.alt_router,
|
|
}
|
|
|
|
def get_router(context, router_id, fields=None):
|
|
return routers[router_id]
|
|
|
|
self.plugin_mock = mock.Mock()
|
|
self.plugin_mock.get_router.side_effect = get_router
|
|
mock.patch(
|
|
'neutron_lib.plugins.directory.get_plugin',
|
|
return_value=self.plugin_mock).start()
|
|
|
|
|
|
class SystemAdminTests(L3ConntrackHelperAPITestCase):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.context = self.system_admin_ctx
|
|
|
|
def test_create_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.InvalidScope,
|
|
policy.enforce,
|
|
self.context, 'create_router_conntrack_helper', self.target)
|
|
self.assertRaises(
|
|
base_policy.InvalidScope,
|
|
policy.enforce,
|
|
self.context, 'create_router_conntrack_helper', self.alt_target)
|
|
|
|
def test_get_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.InvalidScope,
|
|
policy.enforce,
|
|
self.context, 'get_router_conntrack_helper', self.target)
|
|
self.assertRaises(
|
|
base_policy.InvalidScope,
|
|
policy.enforce,
|
|
self.context, 'get_router_conntrack_helper', self.alt_target)
|
|
|
|
def test_update_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.InvalidScope,
|
|
policy.enforce,
|
|
self.context, 'update_router_conntrack_helper', self.target)
|
|
self.assertRaises(
|
|
base_policy.InvalidScope,
|
|
policy.enforce,
|
|
self.context, 'update_router_conntrack_helper', self.alt_target)
|
|
|
|
def test_delete_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.InvalidScope,
|
|
policy.enforce,
|
|
self.context, 'delete_router_conntrack_helper', self.target)
|
|
self.assertRaises(
|
|
base_policy.InvalidScope,
|
|
policy.enforce,
|
|
self.context, 'delete_router_conntrack_helper', self.alt_target)
|
|
|
|
|
|
class SystemMemberTests(SystemAdminTests):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.context = self.system_member_ctx
|
|
|
|
|
|
class SystemReaderTests(SystemMemberTests):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.context = self.system_reader_ctx
|
|
|
|
|
|
class AdminTests(L3ConntrackHelperAPITestCase):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.context = self.project_admin_ctx
|
|
|
|
def test_create_router_conntrack_helper(self):
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'create_router_conntrack_helper', self.target))
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'create_router_conntrack_helper', self.alt_target))
|
|
|
|
def test_get_router_conntrack_helper(self):
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'get_router_conntrack_helper', self.target))
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'get_router_conntrack_helper', self.alt_target))
|
|
|
|
def test_update_router_conntrack_helper(self):
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'update_router_conntrack_helper', self.target))
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'update_router_conntrack_helper', self.alt_target))
|
|
|
|
def test_delete_router_conntrack_helper(self):
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'delete_router_conntrack_helper', self.target))
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'delete_router_conntrack_helper', self.alt_target))
|
|
|
|
|
|
class ProjectManagerTests(AdminTests):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.context = self.project_manager_ctx
|
|
|
|
def test_create_router_conntrack_helper(self):
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'create_router_conntrack_helper', self.target))
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'create_router_conntrack_helper', self.alt_target)
|
|
|
|
def test_get_router_conntrack_helper(self):
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'get_router_conntrack_helper', self.target))
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'get_router_conntrack_helper', self.alt_target)
|
|
|
|
def test_update_router_conntrack_helper(self):
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'update_router_conntrack_helper', self.target))
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'update_router_conntrack_helper', self.alt_target)
|
|
|
|
def test_delete_router_conntrack_helper(self):
|
|
self.assertTrue(
|
|
policy.enforce(self.context,
|
|
'delete_router_conntrack_helper', self.target))
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'delete_router_conntrack_helper', self.alt_target)
|
|
|
|
|
|
class ProjectMemberTests(ProjectManagerTests):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.context = self.project_member_ctx
|
|
|
|
|
|
class ProjectReaderTests(ProjectMemberTests):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.context = self.project_reader_ctx
|
|
|
|
def test_create_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'create_router_conntrack_helper', self.target)
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'create_router_conntrack_helper', self.alt_target)
|
|
|
|
def test_update_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'update_router_conntrack_helper', self.target)
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'update_router_conntrack_helper', self.alt_target)
|
|
|
|
def test_delete_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'delete_router_conntrack_helper', self.target)
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'delete_router_conntrack_helper', self.alt_target)
|
|
|
|
|
|
class ServiceRoleTests(L3ConntrackHelperAPITestCase):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.context = self.service_ctx
|
|
|
|
def test_create_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'create_router_conntrack_helper', self.target)
|
|
|
|
def test_get_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'get_router_conntrack_helper', self.target)
|
|
|
|
def test_update_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'update_router_conntrack_helper', self.target)
|
|
|
|
def test_delete_router_conntrack_helper(self):
|
|
self.assertRaises(
|
|
base_policy.PolicyNotAuthorized,
|
|
policy.enforce,
|
|
self.context, 'delete_router_conntrack_helper', self.target)
|