openstack
/
neutron
Code Issues Proposed changes
neutron/neutron/tests/unit/services
History
Flavio Fernandes b3647782e4 port_forwarding: validate args before invoking db update 
Add validator to update_floatingip_port_forwarding so codepath does not
attempt performing invalid database operation. With that, operation fails
right away, with a hint on the offending argument(s).

This is a backport that combines changes from 2 changes that go together:
https://review.opendev.org/#/c/738145/
https://review.opendev.org/#/c/744993/

Note: pep8 failed with following error:
  ./neutron/tests/unit/services/portforwarding/test_pf_plugin.py:237:9:
  ./neutron/tests/unit/services/portforwarding/test_pf_plugin.py:261:9:
    N322  Possible use of no-op mock method. please use assert_called_once_with.
        mock_pf_get_objects.assert_called_once()
        ^
So additional changes were needed for backport.

Change-Id: I8284b22c5d691bfd9eadeb8590c3d4b27d261b04
Closes-Bug: #1878299
(cherry picked from commit f379740348)
(cherry picked from commit 838399f0a4)
 		2020-08-20 14:36:34 +00:00
..
auto_allocate remove neutron.common.exceptions 2019-02-01 14:35:00 -07:00
l3_router Fix pep8 E128 warnings in non-test code 2019-03-12 21:22:33 +00:00
logapi Add QoS minimum egress bandwidth rule into ovs-agent 2019-02-26 11:05:04 +00:00
metering Retry creating iptables managers and adding metering rules 2019-11-06 14:11:38 +00:00
network_segment_range Fix error 500 during segment range creation 2019-04-09 06:48:54 +00:00
placement_report Locate RP-tree parent by hypervisor name 2019-12-23 12:11:14 +01:00
portforwarding port_forwarding: validate args before invoking db update 2020-08-20 14:36:34 +00:00
qos Refactor qos_plugin._extend_port_resource_request 2019-07-05 16:39:11 +00:00
revisions Use created subnet in port generator in "test_port_ip_update_revises" 2019-09-06 13:11:51 +02:00
trunk Increase number of retries in _process_trunk_subport_bindings 2019-08-29 08:18:35 +00:00
__init__.py Empty files should not contain copyright or license 2014-10-20 00:50:32 +00:00
test_provider_configuration.py use plugin constants from neutron-lib 2017-10-16 09:32:20 -06:00