286 lines
12 KiB
Python
286 lines
12 KiB
Python
# Copyright 2016 OVH SAS
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
|
|
from neutron_lib import constants
|
|
from oslo_config import cfg
|
|
from oslo_utils import uuidutils
|
|
|
|
from neutron.agent.linux import tc_lib
|
|
from neutron.objects.qos import rule
|
|
from neutron.plugins.ml2.drivers.linuxbridge.agent.common import config # noqa
|
|
from neutron.plugins.ml2.drivers.linuxbridge.agent.extension_drivers import (
|
|
qos_driver)
|
|
from neutron.tests import base
|
|
|
|
|
|
TEST_LATENCY_VALUE = 100
|
|
DSCP_VALUE = 32
|
|
|
|
|
|
class QosLinuxbridgeAgentDriverTestCase(base.BaseTestCase):
|
|
|
|
def setUp(self):
|
|
super(QosLinuxbridgeAgentDriverTestCase, self).setUp()
|
|
cfg.CONF.set_override("tbf_latency", TEST_LATENCY_VALUE, "QOS")
|
|
self.qos_driver = qos_driver.QosLinuxbridgeAgentDriver()
|
|
self.qos_driver.initialize()
|
|
self.rule_egress_bw_limit = self._create_bw_limit_rule_obj(
|
|
constants.EGRESS_DIRECTION)
|
|
self.rule_ingress_bw_limit = self._create_bw_limit_rule_obj(
|
|
constants.INGRESS_DIRECTION)
|
|
self.rule_dscp_marking = self._create_dscp_marking_rule_obj()
|
|
self.port = self._create_fake_port(uuidutils.generate_uuid())
|
|
|
|
def _create_bw_limit_rule_obj(self, direction):
|
|
rule_obj = rule.QosBandwidthLimitRule()
|
|
rule_obj.id = uuidutils.generate_uuid()
|
|
rule_obj.max_kbps = 2
|
|
rule_obj.max_burst_kbps = 200
|
|
rule_obj.direction = direction
|
|
rule_obj.obj_reset_changes()
|
|
return rule_obj
|
|
|
|
def _create_dscp_marking_rule_obj(self):
|
|
rule_obj = rule.QosDscpMarkingRule()
|
|
rule_obj.id = uuidutils.generate_uuid()
|
|
rule_obj.dscp_mark = DSCP_VALUE
|
|
rule_obj.obj_reset_changes()
|
|
return rule_obj
|
|
|
|
def _create_fake_port(self, policy_id):
|
|
return {'qos_policy_id': policy_id,
|
|
'network_qos_policy_id': None,
|
|
'device': 'fake_tap'}
|
|
|
|
def _dscp_mark_chain_name(self, device):
|
|
return "qos-o%s" % device[3:]
|
|
|
|
def _dscp_postrouting_rule(self, device):
|
|
return ("-m physdev --physdev-in %s --physdev-is-bridged "
|
|
"-j $qos-o%s") % (device, device[3:])
|
|
|
|
def _dscp_rule(self, dscp_mark_value):
|
|
return "-j DSCP --set-dscp %s" % format(dscp_mark_value, '#04x')
|
|
|
|
def _dscp_rule_tag(self, device):
|
|
return "dscp-%s" % device
|
|
|
|
def test_initialize_iptables_manager_passed_through_api(self):
|
|
iptables_manager = mock.Mock()
|
|
qos_drv = qos_driver.QosLinuxbridgeAgentDriver()
|
|
with mock.patch.object(
|
|
qos_drv, "agent_api"
|
|
) as agent_api, mock.patch(
|
|
"neutron.agent.linux.iptables_manager.IptablesManager"
|
|
) as IptablesManager:
|
|
agent_api.get_iptables_manager.return_value = (
|
|
iptables_manager)
|
|
qos_drv.initialize()
|
|
self.assertEqual(iptables_manager, qos_drv.iptables_manager)
|
|
self.assertNotEqual(IptablesManager(), qos_drv.iptables_manager)
|
|
iptables_manager.initialize_mangle_table.assert_called_once_with()
|
|
|
|
def test_initialize_iptables_manager_not_passed_through_api(self):
|
|
qos_drv = qos_driver.QosLinuxbridgeAgentDriver()
|
|
with mock.patch.object(
|
|
qos_drv, "agent_api"
|
|
) as agent_api, mock.patch(
|
|
"neutron.agent.linux.iptables_manager.IptablesManager"
|
|
) as IptablesManager:
|
|
agent_api.get_iptables_manager.return_value = None
|
|
qos_drv.initialize()
|
|
self.assertEqual(IptablesManager(), qos_drv.iptables_manager)
|
|
IptablesManager().initialize_mangle_table.assert_called_once_with()
|
|
|
|
def test_initialize_iptables_manager_no_agent_api(self):
|
|
qos_drv = qos_driver.QosLinuxbridgeAgentDriver()
|
|
with mock.patch(
|
|
"neutron.agent.linux.iptables_manager.IptablesManager"
|
|
) as IptablesManager:
|
|
qos_driver.agent_api = None
|
|
qos_drv.initialize()
|
|
self.assertEqual(IptablesManager(), qos_drv.iptables_manager)
|
|
IptablesManager().initialize_mangle_table.assert_called_once_with()
|
|
|
|
def test_create_egress_bandwidth_limit(self):
|
|
with mock.patch.object(
|
|
tc_lib.TcCommand, "set_filters_bw_limit"
|
|
) as set_filters_bw_limit, mock.patch.object(
|
|
tc_lib.TcCommand, "set_tbf_bw_limit"
|
|
) as set_tbf_limit:
|
|
self.qos_driver.create_bandwidth_limit(self.port,
|
|
self.rule_egress_bw_limit)
|
|
set_filters_bw_limit.assert_called_once_with(
|
|
self.rule_egress_bw_limit.max_kbps,
|
|
self.rule_egress_bw_limit.max_burst_kbps,
|
|
)
|
|
set_tbf_limit.assert_not_called()
|
|
|
|
def test_create_ingress_bandwidth_limit(self):
|
|
with mock.patch.object(
|
|
tc_lib.TcCommand, "set_filters_bw_limit"
|
|
) as set_filters_bw_limit, mock.patch.object(
|
|
tc_lib.TcCommand, "set_tbf_bw_limit"
|
|
) as set_tbf_limit:
|
|
self.qos_driver.create_bandwidth_limit(self.port,
|
|
self.rule_ingress_bw_limit)
|
|
set_filters_bw_limit.assert_not_called()
|
|
set_tbf_limit.assert_called_once_with(
|
|
self.rule_ingress_bw_limit.max_kbps,
|
|
self.rule_ingress_bw_limit.max_burst_kbps,
|
|
TEST_LATENCY_VALUE
|
|
)
|
|
|
|
def test_update_egress_bandwidth_limit(self):
|
|
with mock.patch.object(
|
|
tc_lib.TcCommand, "update_filters_bw_limit"
|
|
) as update_filters_bw_limit, mock.patch.object(
|
|
tc_lib.TcCommand, "set_tbf_bw_limit"
|
|
) as set_tbf_bw_limit:
|
|
self.qos_driver.update_bandwidth_limit(self.port,
|
|
self.rule_egress_bw_limit)
|
|
update_filters_bw_limit.assert_called_once_with(
|
|
self.rule_egress_bw_limit.max_kbps,
|
|
self.rule_egress_bw_limit.max_burst_kbps,
|
|
)
|
|
set_tbf_bw_limit.assert_not_called()
|
|
|
|
def test_update_ingress_bandwidth_limit(self):
|
|
with mock.patch.object(
|
|
tc_lib.TcCommand, "update_filters_bw_limit"
|
|
) as update_filters_bw_limit, mock.patch.object(
|
|
tc_lib.TcCommand, "set_tbf_bw_limit"
|
|
) as set_tbf_bw_limit:
|
|
self.qos_driver.update_bandwidth_limit(self.port,
|
|
self.rule_ingress_bw_limit)
|
|
update_filters_bw_limit.assert_not_called()
|
|
set_tbf_bw_limit.assert_called_once_with(
|
|
self.rule_egress_bw_limit.max_kbps,
|
|
self.rule_egress_bw_limit.max_burst_kbps,
|
|
TEST_LATENCY_VALUE
|
|
)
|
|
|
|
def test_delete_bandwidth_limit(self):
|
|
with mock.patch.object(
|
|
tc_lib.TcCommand, "delete_filters_bw_limit"
|
|
) as delete_filters_bw_limit:
|
|
self.qos_driver.delete_bandwidth_limit(self.port)
|
|
delete_filters_bw_limit.assert_called_once_with()
|
|
|
|
def test_delete_ingress_bandwidth_limit(self):
|
|
with mock.patch.object(
|
|
tc_lib.TcCommand, "delete_tbf_bw_limit"
|
|
) as delete_tbf_bw_limit:
|
|
self.qos_driver.delete_bandwidth_limit_ingress(self.port)
|
|
delete_tbf_bw_limit.assert_called_once_with()
|
|
|
|
def test_create_dscp_marking(self):
|
|
expected_calls = [
|
|
mock.call.add_chain(
|
|
self._dscp_mark_chain_name(self.port['device'])),
|
|
mock.call.add_rule(
|
|
"POSTROUTING",
|
|
self._dscp_postrouting_rule(self.port['device'])),
|
|
mock.call.add_rule(
|
|
self._dscp_mark_chain_name(self.port['device']),
|
|
self._dscp_rule(DSCP_VALUE),
|
|
tag=self._dscp_rule_tag(self.port['device'])
|
|
)
|
|
]
|
|
with mock.patch.object(
|
|
self.qos_driver, "iptables_manager") as iptables_manager:
|
|
|
|
iptables_manager.ip4['mangle'] = mock.Mock()
|
|
iptables_manager.ip6['mangle'] = mock.Mock()
|
|
self.qos_driver.create_dscp_marking(
|
|
self.port, self.rule_dscp_marking)
|
|
iptables_manager.ipv4['mangle'].assert_has_calls(expected_calls)
|
|
iptables_manager.ipv6['mangle'].assert_has_calls(expected_calls)
|
|
|
|
def test_update_dscp_marking(self):
|
|
expected_calls = [
|
|
mock.call.clear_rules_by_tag(
|
|
self._dscp_rule_tag(self.port['device'])),
|
|
mock.call.add_chain(
|
|
self._dscp_mark_chain_name(self.port['device'])),
|
|
mock.call.add_rule(
|
|
"POSTROUTING",
|
|
self._dscp_postrouting_rule(self.port['device'])),
|
|
mock.call.add_rule(
|
|
self._dscp_mark_chain_name(self.port['device']),
|
|
self._dscp_rule(DSCP_VALUE),
|
|
tag=self._dscp_rule_tag(self.port['device'])
|
|
)
|
|
]
|
|
with mock.patch.object(
|
|
self.qos_driver, "iptables_manager") as iptables_manager:
|
|
|
|
iptables_manager.ip4['mangle'] = mock.Mock()
|
|
iptables_manager.ip6['mangle'] = mock.Mock()
|
|
self.qos_driver.update_dscp_marking(
|
|
self.port, self.rule_dscp_marking)
|
|
iptables_manager.ipv4['mangle'].assert_has_calls(expected_calls)
|
|
iptables_manager.ipv6['mangle'].assert_has_calls(expected_calls)
|
|
|
|
def test_delete_dscp_marking_chain_empty(self):
|
|
dscp_chain_name = self._dscp_mark_chain_name(self.port['device'])
|
|
expected_calls = [
|
|
mock.call.clear_rules_by_tag(
|
|
self._dscp_rule_tag(self.port['device'])),
|
|
mock.call.remove_chain(
|
|
dscp_chain_name),
|
|
]
|
|
with mock.patch.object(
|
|
self.qos_driver, "iptables_manager") as iptables_manager:
|
|
|
|
iptables_manager.ip4['mangle'] = mock.Mock()
|
|
iptables_manager.ip6['mangle'] = mock.Mock()
|
|
iptables_manager.get_chain = mock.Mock(return_value=[])
|
|
self.qos_driver.delete_dscp_marking(self.port)
|
|
iptables_manager.ipv4['mangle'].assert_has_calls(expected_calls)
|
|
iptables_manager.ipv6['mangle'].assert_has_calls(expected_calls)
|
|
iptables_manager.get_chain.assert_has_calls([
|
|
mock.call("mangle", dscp_chain_name,
|
|
ip_version=constants.IP_VERSION_4),
|
|
mock.call("mangle", dscp_chain_name,
|
|
ip_version=constants.IP_VERSION_6)
|
|
])
|
|
|
|
def test_delete_dscp_marking_chain_not_empty(self):
|
|
dscp_chain_name = self._dscp_mark_chain_name(self.port['device'])
|
|
expected_calls = [
|
|
mock.call.clear_rules_by_tag(
|
|
self._dscp_rule_tag(self.port['device'])),
|
|
]
|
|
with mock.patch.object(
|
|
self.qos_driver, "iptables_manager") as iptables_manager:
|
|
|
|
iptables_manager.ip4['mangle'] = mock.Mock()
|
|
iptables_manager.ip6['mangle'] = mock.Mock()
|
|
iptables_manager.get_chain = mock.Mock(
|
|
return_value=["some other rule"])
|
|
self.qos_driver.delete_dscp_marking(self.port)
|
|
iptables_manager.ipv4['mangle'].assert_has_calls(expected_calls)
|
|
iptables_manager.ipv6['mangle'].assert_has_calls(expected_calls)
|
|
iptables_manager.get_chain.assert_has_calls([
|
|
mock.call("mangle", dscp_chain_name,
|
|
ip_version=constants.IP_VERSION_4),
|
|
mock.call("mangle", dscp_chain_name,
|
|
ip_version=constants.IP_VERSION_6)
|
|
])
|
|
iptables_manager.ipv4['mangle'].remove_chain.assert_not_called()
|
|
iptables_manager.ipv4['mangle'].remove_rule.assert_not_called()
|