openstack
/
nova-powervm
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

> Cool, you got zuul to go green.
 > 
 > Though the content is good, I'd advise you to get into good commit
 > habits, per [1].
 > 
 > Specifically:
 > - This commit should be split into three. The lower-constraints.txt/requirements.txt
 > changes should go first. Then you can put the two driver changes on
 > top of that one. (Those two need not be in series with each other,
 > as they're unrelated.)
 > - Your commit messages should be properly formatted, with a short
 > descriptive title and a good explanation in the body. See [2].
 > 
 > [1] https://wiki.openstack.org/wiki/GitCommitMessages
 > [2] https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages

Thanks for guiding me. will do the changes

Patch-set: 1
Reviewer: Gerrit User 28063 <28063@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 28063 2019-07-21 11:52:07 +00:00 committed by Gerrit Code Review
parent 5fa5d44b2e
commit 02a6b70aeb
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available