From 702934c26a54314a1e4d58451034ecd872901d71 Mon Sep 17 00:00:00 2001 From: Gerrit User 14070 <14070@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 26 Jul 2019 13:12:48 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: Code-Review+2 (4 comments) This is an appropriate port from the in-tree change. A couple of nits noted if you need to respin for any reason. Patch-set: 1 Reviewer: Gerrit User 14070 <14070@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2 --- 9ee5a973d7fe02695ae33e4fbdac4b14c84f23a9 | 90 ++++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 9ee5a973d7fe02695ae33e4fbdac4b14c84f23a9 diff --git a/9ee5a973d7fe02695ae33e4fbdac4b14c84f23a9 b/9ee5a973d7fe02695ae33e4fbdac4b14c84f23a9 new file mode 100644 index 00000000..ccc3ddc4 --- /dev/null +++ b/9ee5a973d7fe02695ae33e4fbdac4b14c84f23a9 @@ -0,0 +1,90 @@ +{ + "comments": [ + { + "key": { + "uuid": "7faddb67_e31597e6", + "filename": "/COMMIT_MSG", + "patchSetId": 1 + }, + "lineNbr": 26, + "author": { + "id": 14070 + }, + "writtenOn": "2019-07-26T13:12:48Z", + "side": 1, + "message": "Could mention that it\u0027s not an exact port because you had to update the references to the standard resource classes.", + "revId": "9ee5a973d7fe02695ae33e4fbdac4b14c84f23a9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "7faddb67_4327cb65", + "filename": "/COMMIT_MSG", + "patchSetId": 1 + }, + "lineNbr": 29, + "author": { + "id": 14070 + }, + "writtenOn": "2019-07-26T13:12:48Z", + "side": 1, + "message": "Putting this link on one line will cause the gerrit web UI to render it properly. (You\u0027re allowed to cheat on the 79c rule for things like this.)", + "range": { + "startLine": 27, + "startChar": 0, + "endLine": 29, + "endChar": 37 + }, + "revId": "9ee5a973d7fe02695ae33e4fbdac4b14c84f23a9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "7faddb67_632a072d", + "filename": "nova_powervm/virt/powervm/driver.py", + "patchSetId": 1 + }, + "lineNbr": 1013, + "author": { + "id": 14070 + }, + "writtenOn": "2019-07-26T13:12:48Z", + "side": 1, + "message": "exist (recognizing this is a direct copy/paste from the in-tree change)", + "range": { + "startLine": 1013, + "startChar": 50, + "endLine": 1013, + "endChar": 56 + }, + "revId": "9ee5a973d7fe02695ae33e4fbdac4b14c84f23a9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "7faddb67_0321d34d", + "filename": "nova_powervm/virt/powervm/driver.py", + "patchSetId": 1 + }, + "lineNbr": 1015, + "author": { + "id": 14070 + }, + "writtenOn": "2019-07-26T13:12:48Z", + "side": 1, + "message": "fall back (ditto)", + "range": { + "startLine": 1015, + "startChar": 22, + "endLine": 1015, + "endChar": 30 + }, + "revId": "9ee5a973d7fe02695ae33e4fbdac4b14c84f23a9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file